From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: linux-serial <linux-serial@vger.kernel.org>,
"Jiri Slaby" <jirislaby@kernel.org>,
"Lukas Wunner" <lukas@wunner.de>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Vicente Bergas" <vicencb@gmail.com>,
"Johan Hovold" <johan@kernel.org>,
heiko@sntech.de, giulio.benetti@micronovasrl.com,
"Heikki Krogerus" <heikki.krogerus@linux.intel.com>,
linux-api@vger.kernel.org,
"Ivan Kokshaysky" <ink@jurassic.park.msu.ru>,
"Matt Turner" <mattst88@gmail.com>,
linux-alpha@vger.kernel.org,
"Thomas Bogendoerfer" <tsbogend@alpha.franken.de>,
linux-mips@vger.kernel.org,
"James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
"Helge Deller" <deller@gmx.de>,
linux-parisc@vger.kernel.org,
"Michael Ellerman" <mpe@ellerman.id.au>,
"Benjamin Herrenschmidt" <benh@kernel.crashing.org>,
"Paul Mackerras" <paulus@samba.org>,
linuxppc-dev@lists.ozlabs.org,
"David S. Miller" <davem@davemloft.net>,
sparclinux@vger.kernel.org, "Arnd Bergmann" <arnd@arndb.de>,
linux-arch@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH v5 05/10] serial: termbits: ADDRB to indicate 9th bit addressing mode
Date: Tue, 26 Apr 2022 19:29:08 +0300 (EEST) [thread overview]
Message-ID: <9a9dda88-b239-9c63-82d-2f7678fdbf9@linux.intel.com> (raw)
In-Reply-To: <Ymf9UhyXj7o8cNhq@kroah.com>
[-- Attachment #1: Type: text/plain, Size: 905 bytes --]
On Tue, 26 Apr 2022, Greg KH wrote:
> On Tue, Apr 26, 2022 at 05:01:31PM +0300, Ilpo Järvinen wrote:
> >
> > ADDRB value is the same for all archs (it's just this octal vs hex
> > notation I've followed as per the nearby defines within the same file
> > which makes them look different).
> >
> > Should I perhaps add to my cleanup list conversion of all those octal ones
> > to hex?
>
> Argh, yes, please, let's do that now, I totally missed that. Will let
> us see how to unify them as well.
Unifying them might turn out impractical, here's a rough idea now many
copies ... | uniq -c finds for the defines (based on more aggressively
cleaned up lines than the patch will have):
89 1
74 2
14 3
58 4
11 5
54 6
There just tends to be 1 or 2 archs which are different from the others.
...I'll send the actual octal-to-hex patch once the arch builds complete.
--
i.
next prev parent reply other threads:[~2022-04-26 16:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220426122448.38997-1-ilpo.jarvinen@linux.intel.com>
2022-04-26 12:24 ` [PATCH v5 05/10] serial: termbits: ADDRB to indicate 9th bit addressing mode Ilpo Järvinen
2022-04-26 12:52 ` Greg KH
2022-04-26 13:12 ` Ilpo Järvinen
2022-04-26 14:01 ` Ilpo Järvinen
2022-04-26 14:10 ` Greg KH
2022-04-26 16:29 ` Ilpo Järvinen [this message]
2022-04-26 12:24 ` [PATCH v5 06/10] serial: General support for multipoint addresses Ilpo Järvinen
2022-04-26 12:56 ` Greg KH
2022-04-26 13:36 ` Ilpo Järvinen
2022-04-26 13:58 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a9dda88-b239-9c63-82d-2f7678fdbf9@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=James.Bottomley@hansenpartnership.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=benh@kernel.crashing.org \
--cc=davem@davemloft.net \
--cc=deller@gmx.de \
--cc=giulio.benetti@micronovasrl.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=heiko@sntech.de \
--cc=ink@jurassic.park.msu.ru \
--cc=jirislaby@kernel.org \
--cc=johan@kernel.org \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lukas@wunner.de \
--cc=mattst88@gmail.com \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
--cc=sparclinux@vger.kernel.org \
--cc=tsbogend@alpha.franken.de \
--cc=u.kleine-koenig@pengutronix.de \
--cc=vicencb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).