* [RFT PATCH 1/2] stmmac: dwmac-loongson: drop useless check for compatible fallback @ 2023-06-16 10:31 Krzysztof Kozlowski 2023-06-16 10:31 ` [RFT PATCH 2/2] MIPS: dts: loongson: drop incorrect dwmac fallback compatible Krzysztof Kozlowski 2023-06-16 18:52 ` [RFT PATCH 1/2] stmmac: dwmac-loongson: drop useless check for compatible fallback Conor Dooley 0 siblings, 2 replies; 6+ messages in thread From: Krzysztof Kozlowski @ 2023-06-16 10:31 UTC (permalink / raw) To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Thomas Bogendoerfer, Giuseppe Cavallaro, Alexandre Torgue, Jose Abreu, David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni, Maxime Coquelin, devicetree, linux-mips, linux-kernel, netdev, linux-stm32, linux-arm-kernel Cc: Krzysztof Kozlowski Device binds to proper PCI ID (LOONGSON, 0x7a03), already listed in DTS, so checking for some other compatible does not make sense. It cannot be bound to unsupported platform. Drop useless, incorrect (space in between) and undocumented compatible. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c index a25c187d3185..900972521b59 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c @@ -59,11 +59,6 @@ static int loongson_dwmac_probe(struct pci_dev *pdev, const struct pci_device_id return -ENODEV; } - if (!of_device_is_compatible(np, "loongson, pci-gmac")) { - pr_info("dwmac_loongson_pci: Incompatible OF node\n"); - return -ENODEV; - } - plat = devm_kzalloc(&pdev->dev, sizeof(*plat), GFP_KERNEL); if (!plat) return -ENOMEM; -- 2.34.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* [RFT PATCH 2/2] MIPS: dts: loongson: drop incorrect dwmac fallback compatible 2023-06-16 10:31 [RFT PATCH 1/2] stmmac: dwmac-loongson: drop useless check for compatible fallback Krzysztof Kozlowski @ 2023-06-16 10:31 ` Krzysztof Kozlowski 2023-06-16 18:52 ` Conor Dooley 2023-06-16 18:52 ` [RFT PATCH 1/2] stmmac: dwmac-loongson: drop useless check for compatible fallback Conor Dooley 1 sibling, 1 reply; 6+ messages in thread From: Krzysztof Kozlowski @ 2023-06-16 10:31 UTC (permalink / raw) To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Thomas Bogendoerfer, Giuseppe Cavallaro, Alexandre Torgue, Jose Abreu, David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni, Maxime Coquelin, devicetree, linux-mips, linux-kernel, netdev, linux-stm32, linux-arm-kernel Cc: Krzysztof Kozlowski Device binds to proper PCI ID (LOONGSON, 0x7a03), already listed in DTS, so checking for some other compatible does not make sense. It cannot be bound to unsupported platform. Drop useless, incorrect (space in between) and undocumented compatible. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- This patch depends on driver change, thus it should be accepted a release after the driver is merged. --- arch/mips/boot/dts/loongson/loongson64-2k1000.dtsi | 3 +-- arch/mips/boot/dts/loongson/ls7a-pch.dtsi | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/arch/mips/boot/dts/loongson/loongson64-2k1000.dtsi b/arch/mips/boot/dts/loongson/loongson64-2k1000.dtsi index 8143a61111e3..c16b521308cb 100644 --- a/arch/mips/boot/dts/loongson/loongson64-2k1000.dtsi +++ b/arch/mips/boot/dts/loongson/loongson64-2k1000.dtsi @@ -123,8 +123,7 @@ gmac@3,0 { compatible = "pci0014,7a03.0", "pci0014,7a03", "pciclass0c0320", - "pciclass0c03", - "loongson, pci-gmac"; + "pciclass0c03"; reg = <0x1800 0x0 0x0 0x0 0x0>; interrupts = <12 IRQ_TYPE_LEVEL_LOW>, diff --git a/arch/mips/boot/dts/loongson/ls7a-pch.dtsi b/arch/mips/boot/dts/loongson/ls7a-pch.dtsi index 2f45fce2cdc4..ed99ee316feb 100644 --- a/arch/mips/boot/dts/loongson/ls7a-pch.dtsi +++ b/arch/mips/boot/dts/loongson/ls7a-pch.dtsi @@ -186,8 +186,7 @@ gmac@3,0 { compatible = "pci0014,7a03.0", "pci0014,7a03", "pciclass020000", - "pciclass0200", - "loongson, pci-gmac"; + "pciclass0200"; reg = <0x1800 0x0 0x0 0x0 0x0>; interrupts = <12 IRQ_TYPE_LEVEL_HIGH>, -- 2.34.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [RFT PATCH 2/2] MIPS: dts: loongson: drop incorrect dwmac fallback compatible 2023-06-16 10:31 ` [RFT PATCH 2/2] MIPS: dts: loongson: drop incorrect dwmac fallback compatible Krzysztof Kozlowski @ 2023-06-16 18:52 ` Conor Dooley 0 siblings, 0 replies; 6+ messages in thread From: Conor Dooley @ 2023-06-16 18:52 UTC (permalink / raw) To: Krzysztof Kozlowski Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Thomas Bogendoerfer, Giuseppe Cavallaro, Alexandre Torgue, Jose Abreu, David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni, Maxime Coquelin, devicetree, linux-mips, linux-kernel, netdev, linux-stm32, linux-arm-kernel [-- Attachment #1: Type: text/plain, Size: 487 bytes --] On Fri, Jun 16, 2023 at 12:31:27PM +0200, Krzysztof Kozlowski wrote: > Device binds to proper PCI ID (LOONGSON, 0x7a03), already listed in DTS, > so checking for some other compatible does not make sense. It cannot be > bound to unsupported platform. > > Drop useless, incorrect (space in between) and undocumented compatible. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Reviewed-by: Conor Dooley <conor.dooley@microchip.com> Cheers, Conor. [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RFT PATCH 1/2] stmmac: dwmac-loongson: drop useless check for compatible fallback 2023-06-16 10:31 [RFT PATCH 1/2] stmmac: dwmac-loongson: drop useless check for compatible fallback Krzysztof Kozlowski 2023-06-16 10:31 ` [RFT PATCH 2/2] MIPS: dts: loongson: drop incorrect dwmac fallback compatible Krzysztof Kozlowski @ 2023-06-16 18:52 ` Conor Dooley 2023-12-10 6:48 ` Yanteng Si 1 sibling, 1 reply; 6+ messages in thread From: Conor Dooley @ 2023-06-16 18:52 UTC (permalink / raw) To: Krzysztof Kozlowski Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Thomas Bogendoerfer, Giuseppe Cavallaro, Alexandre Torgue, Jose Abreu, David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni, Maxime Coquelin, devicetree, linux-mips, linux-kernel, netdev, linux-stm32, linux-arm-kernel [-- Attachment #1: Type: text/plain, Size: 628 bytes --] On Fri, Jun 16, 2023 at 12:31:26PM +0200, Krzysztof Kozlowski wrote: > Device binds to proper PCI ID (LOONGSON, 0x7a03), already listed in DTS, > so checking for some other compatible does not make sense. It cannot be > bound to unsupported platform. > > Drop useless, incorrect (space in between) and undocumented compatible. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Might be worth noting that dropping it is required to allow the new loongarch dts stuff to be functional with a sane set of compatibles. Reviewed-by: Conor Dooley <conor.dooley@microchip.com> Cheers, Conor. [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RFT PATCH 1/2] stmmac: dwmac-loongson: drop useless check for compatible fallback 2023-06-16 18:52 ` [RFT PATCH 1/2] stmmac: dwmac-loongson: drop useless check for compatible fallback Conor Dooley @ 2023-12-10 6:48 ` Yanteng Si 2023-12-11 9:17 ` Jiaxun Yang 0 siblings, 1 reply; 6+ messages in thread From: Yanteng Si @ 2023-12-10 6:48 UTC (permalink / raw) To: Krzysztof Kozlowski, Thomas Bogendoerfer, jiaxun.yang, Andrew Lunn, Conor Dooley Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Giuseppe Cavallaro, Alexandre Torgue, Jose Abreu, David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni, Maxime Coquelin, devicetree, linux-mips, linux-kernel, netdev, linux-stm32, linux-arm-kernel 在 2023/6/17 02:52, Conor Dooley 写道: > On Fri, Jun 16, 2023 at 12:31:26PM +0200, Krzysztof Kozlowski wrote: >> Device binds to proper PCI ID (LOONGSON, 0x7a03), already listed in DTS, >> so checking for some other compatible does not make sense. It cannot be >> bound to unsupported platform. >> >> Drop useless, incorrect (space in between) and undocumented compatible. >> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Might be worth noting that dropping it is required to allow the > new loongarch dts stuff to be functional with a sane set of compatibles. > > Reviewed-by: Conor Dooley <conor.dooley@microchip.com> Thank you Krzysztof for your work. when I am adding more devices support to stmmac, I found that your two patches seemed to be forgotten. Thomas, Jiaxun. Can the two patches get an Acked-by? My stmmac patch thread: <https://lore.kernel.org/loongarch/cover.1699533745.git .siyanteng@loongson.cn/T/#md3108d29a5efe71b27f4c5ccf5d0217571bf6586> Thanks, Yanteng > > Cheers, > Conor. ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RFT PATCH 1/2] stmmac: dwmac-loongson: drop useless check for compatible fallback 2023-12-10 6:48 ` Yanteng Si @ 2023-12-11 9:17 ` Jiaxun Yang 0 siblings, 0 replies; 6+ messages in thread From: Jiaxun Yang @ 2023-12-11 9:17 UTC (permalink / raw) To: Yanteng Si, Krzysztof Kozlowski, Thomas Bogendoerfer, Andrew Lunn, Conor Dooley Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Giuseppe Cavallaro, Alexandre Torgue, Jose Abreu, David S . Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni, Maxime Coquelin, devicetree, linux-mips@vger.kernel.org, linux-kernel, netdev, linux-stm32, linux-arm-kernel 在2023年12月10日十二月 上午6:48，Yanteng Si写道： > 在 2023/6/17 02:52, Conor Dooley 写道: >> On Fri, Jun 16, 2023 at 12:31:26PM +0200, Krzysztof Kozlowski wrote: >>> Device binds to proper PCI ID (LOONGSON, 0x7a03), already listed in DTS, >>> so checking for some other compatible does not make sense. It cannot be >>> bound to unsupported platform. >>> >>> Drop useless, incorrect (space in between) and undocumented compatible. >>> >>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> Might be worth noting that dropping it is required to allow the >> new loongarch dts stuff to be functional with a sane set of compatibles. >> >> Reviewed-by: Conor Dooley <conor.dooley@microchip.com> > Thank you Krzysztof for your work. when I am > adding more devices support to stmmac, I found that your > two patches seemed to be forgotten. > Thomas, Jiaxun. Can the two patches get an Acked-by? > My stmmac patch thread: > <https://lore.kernel.org/loongarch/cover.1699533745.git > .siyanteng@loongson.cn/T/#md3108d29a5efe71b27f4c5ccf5d0217571bf6586> Acked-by: Jiaxun Yang <jiaxun.yang@flygoat.com> Better to resend without RFC :-) Thanks > Thanks, > Yanteng > >> >> Cheers, >> Conor. -- - Jiaxun ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-12-11 9:26 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2023-06-16 10:31 [RFT PATCH 1/2] stmmac: dwmac-loongson: drop useless check for compatible fallback Krzysztof Kozlowski 2023-06-16 10:31 ` [RFT PATCH 2/2] MIPS: dts: loongson: drop incorrect dwmac fallback compatible Krzysztof Kozlowski 2023-06-16 18:52 ` Conor Dooley 2023-06-16 18:52 ` [RFT PATCH 1/2] stmmac: dwmac-loongson: drop useless check for compatible fallback Conor Dooley 2023-12-10 6:48 ` Yanteng Si 2023-12-11 9:17 ` Jiaxun Yang
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).