From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Borislav Petkov" <bp@alien8.de>,
"Tony Luck" <tony.luck@intel.com>
Cc: Ralf Baechle <ralf@linux-mips.org>,
James Morse <james.morse@arm.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Robert Richter <rric@kernel.org>,
linux-edac@vger.kernel.org, linux-mips@vger.kernel.org,
kernel@pengutronix.de
Subject: Re: [PATCH 13/21] EDAC/octeon-lmc: Convert to platform remove callback returning void
Date: Tue, 10 Oct 2023 16:02:49 +0200 [thread overview]
Message-ID: <9ef5dbf2-c103-608c-9e57-98eaa36aa894@linaro.org> (raw)
In-Reply-To: <20231004131254.2673842-14-u.kleine-koenig@pengutronix.de>
On 4/10/23 15:12, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart
> from emitting a warning) and this typically results in resource leaks.
>
> To improve here there is a quest to make the remove callback return
> void. In the first step of this quest all drivers are converted to
> .remove_new(), which already returns void. Eventually after all drivers
> are converted, .remove_new() will be renamed to .remove().
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> drivers/edac/octeon_edac-lmc.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2023-10-10 14:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-04 13:12 [PATCH 00/21] EDAC: Convert to platform remove callback returning void Uwe Kleine-König
2023-10-04 13:12 ` [PATCH 12/21] EDAC/octeon-l2c: " Uwe Kleine-König
2023-10-10 14:03 ` Philippe Mathieu-Daudé
2023-10-04 13:12 ` [PATCH 13/21] EDAC/octeon-lmc: " Uwe Kleine-König
2023-10-10 14:02 ` Philippe Mathieu-Daudé [this message]
2023-10-04 13:12 ` [PATCH 14/21] EDAC/octeon-pc: " Uwe Kleine-König
2023-10-10 14:03 ` Philippe Mathieu-Daudé
2023-10-04 13:12 ` [PATCH 15/21] EDAC/octeon-pci: " Uwe Kleine-König
2023-10-10 14:03 ` Philippe Mathieu-Daudé
2023-11-20 16:20 ` [PATCH 00/21] EDAC: " Uwe Kleine-König
2023-11-20 17:21 ` Borislav Petkov
2023-11-20 22:36 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9ef5dbf2-c103-608c-9e57-98eaa36aa894@linaro.org \
--to=philmd@linaro.org \
--cc=bp@alien8.de \
--cc=james.morse@arm.com \
--cc=kernel@pengutronix.de \
--cc=linux-edac@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=ralf@linux-mips.org \
--cc=rric@kernel.org \
--cc=tony.luck@intel.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).