From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8671C433E0 for ; Tue, 11 Aug 2020 09:09:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8087420781 for ; Tue, 11 Aug 2020 09:09:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728380AbgHKJJe convert rfc822-to-8bit (ORCPT ); Tue, 11 Aug 2020 05:09:34 -0400 Received: from mail-ed1-f67.google.com ([209.85.208.67]:39503 "EHLO mail-ed1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728336AbgHKJJe (ORCPT ); Tue, 11 Aug 2020 05:09:34 -0400 Received: by mail-ed1-f67.google.com with SMTP id c10so8497449edk.6; Tue, 11 Aug 2020 02:09:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=7nAprOq2xfZCg8U+qPFrSCSPVHDN3Z4PSbLlksPqDaQ=; b=KZbRVuhOyyK9le2+9kicadsjCLCe942WCWBJWfgiwQcHAVQEnGTLhiWIfkh0Fz2lPo F1Dei75G/We1kp9Sq5QiHCOAvVCMGtRyadnlzhRP5mRhonBuCI8DlUpHYnOws8mHNDuz aEn0FdZ1ZSqnKwISo5upjzjid7dPyaPJhrjVdtQfObVLHXn+qWUPo9dhFaeduFcUPGfI gvHygsnERxeIoA3XsElWAEHDGhjitK2MOSXroKTEhat1uPtKMoQ5rZY8WinpWOUoCVwR mfJNWhEdq5hICUf4Ghc2xVRgneT11Zs0HOn5KPta3kazemQUum2m7FuKRd2MA+ErHfa5 Dxvw== X-Gm-Message-State: AOAM530NhfatOxATEaVFYTI5tMJvWTpN53FyH/ibYcNIHFLT8emGGjal akZaPWymLXQu7kF2HsL0AlnvKyLDnPeSZOqKT+RuQZzX X-Google-Smtp-Source: ABdhPJwsET5r+S0OddQDzlODnuDPEC1cxBkBpR48tmVZwKKukz6tCJ53SK+KdU7nBegaksGW9TaBIk4T/gZYhQf8RXE= X-Received: by 2002:a50:e70e:: with SMTP id a14mr9836310edn.93.1597136972345; Tue, 11 Aug 2020 02:09:32 -0700 (PDT) MIME-Version: 1.0 References: <20200807100411.2904279-1-noltari@gmail.com> <20200807100411.2904279-4-noltari@gmail.com> In-Reply-To: From: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= Date: Tue, 11 Aug 2020 11:09:20 +0200 Message-ID: Subject: Re: [PATCH v2 3/4] MIPS: BCM63xx: enable EHCI for DWV-S0 board To: Florian Fainelli Cc: =?UTF-8?B?w4FsdmFybyBGZXJuw6FuZGV6IFJvamFz?= , Thomas Bogendoerfer , Jonas Gorski , bcm-kernel-feedback-list , "open list:BROADCOM NVRAM DRIVER" , Linux ARM , open list Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Sender: linux-mips-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org Hi Florian, On Tue, Aug 11, 2020 at 4:33 AM Florian Fainelli wrote: > On 8/9/2020 11:49 AM, Philippe Mathieu-Daudé wrote: > > Hi Álvaro, > > > > On Fri, Aug 7, 2020 at 12:05 PM Álvaro Fernández Rojas > > wrote: > >> > >> EHCI and OHCI share the same USB ports. Therefore, if the board has OHCI > >> it should also have EHCI. > > > > This statement isn't correct. OHCI doesn't imply EHCI... > > (although the opposite is almost always true). > > > > Now per 6358-PB01-R the bcm6358 indeed has a EHCI controller. > > > > Do you mind rewording the commit description? > > Is not it that a single USB port is used and we need the EHCI controller > active in order for the correct speed negotiation to occur? Yes. What sounds odd is "if the board has OHCI it should also have EHCI." This is true for this particular board because its chipset is a bcm6358, but I'm worried it might later confuse other developers. For example the bcm6348 has a OHCI controller, but that doesn't imply its port can be used as EHCI. Regards, Phil. > -- > Florian