From: Huacai Chen <chenhuacai@kernel.org>
To: Marco Crivellari <marco.crivellari@suse.com>
Cc: linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Frederic Weisbecker <frederic@kernel.org>,
Anna-Maria Behnsen <anna-maria@linutronix.de>,
Thomas Gleixner <tglx@linutronix.de>,
Peter Zijlstra <peterz@infradead.org>,
"Maciej W . Rozycki" <macro@orcam.me.uk>
Subject: Re: [PATCH v7 2/2] MIPS: Move r4k_wait() to .cpuidle.text section
Date: Mon, 28 Apr 2025 10:26:51 +0800 [thread overview]
Message-ID: <CAAhV-H4dQ8hRfBm2JWmgMzYH5tuy4ph6hyOSXQBLOvtCQ+K9dQ@mail.gmail.com> (raw)
In-Reply-To: <20250403161143.361461-3-marco.crivellari@suse.com>
Hi, Marco,
On Fri, Apr 4, 2025 at 12:12 AM Marco Crivellari
<marco.crivellari@suse.com> wrote:
>
> Fix missing .cpuidle.text section assignment for r4k_wait() to correct
> backtracing with nmi_backtrace().
>
> Fixes: 97c8580e85cf ("MIPS: Annotate cpu_wait implementations with __cpuidle")
> Signed-off-by: Marco Crivellari <marco.crivellari@suse.com>
> Signed-off-by: Maciej W. Rozycki <macro@orcam.me.uk>
> Acked-by: Frederic Weisbecker <frederic@kernel.org>
> ---
> arch/mips/kernel/genex.S | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/mips/kernel/genex.S b/arch/mips/kernel/genex.S
> index 46d975d00298..2cf312d9a3b0 100644
> --- a/arch/mips/kernel/genex.S
> +++ b/arch/mips/kernel/genex.S
> @@ -104,6 +104,7 @@ handle_vcei:
>
> __FINIT
>
> + .section .cpuidle.text,"ax"
If you submit a new version, adding a space before "ax" will be a little better.
Huacai
> /* Align to 32 bytes for the maximum idle interrupt region size. */
> .align 5
> LEAF(r4k_wait)
> --
> 2.49.0
>
next prev parent reply other threads:[~2025-04-28 2:27 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-03 16:11 [PATCH v7 0/2] MIPS: Fix idle VS timer enqueue Marco Crivellari
2025-04-03 16:11 ` [PATCH v7 1/2] " Marco Crivellari
2025-04-11 14:03 ` Marco Crivellari
2025-04-25 8:30 ` Marco Crivellari
2025-04-27 9:53 ` Huacai Chen
2025-04-28 1:32 ` Maciej W. Rozycki
2025-04-28 7:22 ` Marco Crivellari
2025-04-03 16:11 ` [PATCH v7 2/2] MIPS: Move r4k_wait() to .cpuidle.text section Marco Crivellari
2025-04-28 2:26 ` Huacai Chen [this message]
2025-04-28 3:28 ` Maciej W. Rozycki
2025-04-28 4:11 ` Huacai Chen
2025-04-28 10:20 ` Marco Crivellari
2025-04-28 10:23 ` Thomas Bogendoerfer
2025-04-28 17:56 ` Maciej W. Rozycki
2025-04-30 3:15 ` Huacai Chen
2025-04-27 8:16 ` [PATCH v7 0/2] MIPS: Fix idle VS timer enqueue Thomas Bogendoerfer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAhV-H4dQ8hRfBm2JWmgMzYH5tuy4ph6hyOSXQBLOvtCQ+K9dQ@mail.gmail.com \
--to=chenhuacai@kernel.org \
--cc=anna-maria@linutronix.de \
--cc=frederic@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=macro@orcam.me.uk \
--cc=marco.crivellari@suse.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).