Re: [PATCH 1/2] PCI: mt7621: Add MODULE_* macros to MT7621 PCIe host controller driver

[yanteng si <siyanteng01@gmail.com>]

Sergio Paracuellos <sergio.paracuellos@gmail.com> 于2021年10月27日周三 下午8:00写道：
>
> Hi,
>
> On Wed, Oct 27, 2021 at 1:32 PM Yanteng Si <siyanteng01@gmail.com> wrote:
> >
> > Since commit 2bdd5238e756 ("PCI: mt7621: Add MediaTek MT7621 PCIe host controller driver")
> > the MT7621 PCIe host controller driver is built as a module but no MODULE_*() attributes
> > were specified, causing a build error due to missing license information.
> >
> > ERROR: modpost: missing MODULE_LICENSE() in drivers/pci/controller/pcie-mt7621.o
> >
> > Fix this by adding MODULE attributes to the driver.
> >
> > Signed-off-by: Yanteng Si <siyanteng@loongson.cn>
> > ---
> >  drivers/pci/controller/pcie-mt7621.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/pci/controller/pcie-mt7621.c b/drivers/pci/controller/pcie-mt7621.c
> > index b60dfb45ef7b..668b737f86fb 100644
> > --- a/drivers/pci/controller/pcie-mt7621.c
> > +++ b/drivers/pci/controller/pcie-mt7621.c
> > @@ -598,3 +598,5 @@ static struct platform_driver mt7621_pci_driver = {
> >         },
> >  };
> >  builtin_platform_driver(mt7621_pci_driver);
> > +
> > +MODULE_LICENSE("GPL v2");
>
> I guess this is needed for COMPILE_TEST scenarios?
yeah!
>
> Acked-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>

Thank you very much!

Thanks,
yanteng