From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Andy Shevchenko <andy@kernel.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
Paul Cercueil <paul@crapouillou.net>,
Harvey Hunt <harveyhuntnexus@gmail.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Daniel Scally <djrscally@gmail.com>,
Hans de Goede <hdegoede@redhat.com>,
Mark Gross <markgross@kernel.org>,
Heiner Kallweit <hkallweit1@gmail.com>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mmc@vger.kernel.org, linux-mips@vger.kernel.org,
linux-mtd@lists.infradead.org,
platform-driver-x86@vger.kernel.org,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Subject: Re: [PATCH 2/5] mtd: rawnand: ingenic: use gpiod_set_active_high()
Date: Thu, 14 Sep 2023 10:02:26 +0300 [thread overview]
Message-ID: <CAHp75Vd2a06rnGCEiJW0reN00amso0RyvgLT516nZiYLYZ-xcQ@mail.gmail.com> (raw)
In-Reply-To: <20230913222338.07d1625b@xps-13>
On Wed, Sep 13, 2023 at 11:23 PM Miquel Raynal
<miquel.raynal@bootlin.com> wrote:
> linus.walleij@linaro.org wrote on Wed, 13 Sep 2023 22:12:40 +0200:
> > On Wed, Sep 13, 2023 at 10:05 PM Andy Shevchenko
> > <andy.shevchenko@gmail.com> wrote:
> > > On Wed, Sep 13, 2023 at 2:50 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
...
> > > Why not moving this quirk to gpiolib-of.c?
> >
> > That's a better idea here I think, it's clearly a quirk for a
> > buggy device tree.
>
> Agreed, it's just for backward compatibility purposes in a single
> driver. I believe it should stay here.
I believe Linus was for moving.
gpiolib-of.c contains a lot of quirks, including this one. Calling
these new (or old) APIs for overriding polarity in many cases
shouldn't be needed if were no issues with DT or something like that.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-09-14 7:03 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-13 11:49 [PATCH 0/5] gpio: remove gpiod_toggle_active_low() Bartosz Golaszewski
2023-09-13 11:49 ` [PATCH 1/5] gpiolib: provide gpiod_set_active_[low/high]() Bartosz Golaszewski
2023-09-13 15:19 ` kernel test robot
2023-09-13 18:41 ` kernel test robot
2023-09-13 19:23 ` kernel test robot
2023-09-13 11:49 ` [PATCH 2/5] mtd: rawnand: ingenic: use gpiod_set_active_high() Bartosz Golaszewski
2023-09-13 12:01 ` Paul Cercueil
2023-09-13 15:37 ` Miquel Raynal
2023-09-13 20:05 ` Andy Shevchenko
2023-09-13 20:12 ` Linus Walleij
2023-09-13 20:23 ` Miquel Raynal
2023-09-14 7:02 ` Andy Shevchenko [this message]
2023-09-14 7:04 ` Andy Shevchenko
2023-09-14 8:30 ` Paul Cercueil
2023-09-14 9:30 ` Bartosz Golaszewski
2023-09-14 13:55 ` Linus Walleij
2023-09-13 11:49 ` [PATCH 3/5] mmc: slot-gpio: use gpiod_set_active_[low|high]() Bartosz Golaszewski
2023-09-13 12:24 ` Linus Walleij
2023-09-13 12:39 ` Bartosz Golaszewski
2023-09-14 8:31 ` Linus Walleij
2023-09-14 8:38 ` Linus Walleij
2023-09-13 11:50 ` [PATCH 4/5] platform/x86: int3472/discrete: use gpiod_set_active_low() Bartosz Golaszewski
2023-09-13 14:50 ` Hans de Goede
2023-09-13 11:50 ` [PATCH 5/5] gpiolib: remove gpiod_toggle_active_low() Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75Vd2a06rnGCEiJW0reN00amso0RyvgLT516nZiYLYZ-xcQ@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=andy@kernel.org \
--cc=bartosz.golaszewski@linaro.org \
--cc=brgl@bgdev.pl \
--cc=djrscally@gmail.com \
--cc=harveyhuntnexus@gmail.com \
--cc=hdegoede@redhat.com \
--cc=hkallweit1@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=markgross@kernel.org \
--cc=miquel.raynal@bootlin.com \
--cc=paul@crapouillou.net \
--cc=platform-driver-x86@vger.kernel.org \
--cc=richard@nod.at \
--cc=ulf.hansson@linaro.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).