From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 736B9C001DE for ; Mon, 31 Jul 2023 17:21:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232982AbjGaRVo (ORCPT ); Mon, 31 Jul 2023 13:21:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45632 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233172AbjGaRV1 (ORCPT ); Mon, 31 Jul 2023 13:21:27 -0400 Received: from mail-il1-x130.google.com (mail-il1-x130.google.com [IPv6:2607:f8b0:4864:20::130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B5944129 for ; Mon, 31 Jul 2023 10:21:20 -0700 (PDT) Received: by mail-il1-x130.google.com with SMTP id e9e14a558f8ab-3490b737f9aso6385ab.0 for ; Mon, 31 Jul 2023 10:21:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1690824079; x=1691428879; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=x1yc8T49I2SK2WZwiTxo7poffYgxmNdrGJbub/r4Zew=; b=3sVZ6Pvu0MXolTiQ3qzM8kGAaMnBBEr6wdfZ02tKrrgnWJIvo3F3TkblR8+mCeqLz7 1qXflSuEUvBPQ5UPzgIjQfEu4vFikLzhtIHvIPBXHMzl0AM/kqpA5ISl2NMmQYhDROP+ 9e8klrqjKR1eutqvlrh4m6oRlLgNeD45MZr0hKazL8rfmsz5VFIrEaoD9EbMPVM48OeE qCplx75r36D9baB9hAs1IgOBsL9TNbtYYnYvs0rvOqAoqW6tw1XlEV1PEwetGi2gpp4a kbIlhN/ej8BKcLn9QF4bsJVwJkRXrgYR7F2khR014azoZLG2kmXOWrtv2RUvhNa4ZpL3 3Pgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690824079; x=1691428879; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=x1yc8T49I2SK2WZwiTxo7poffYgxmNdrGJbub/r4Zew=; b=IMq9QCsWzZRlVmT/sLdmnDn31pNwSKTPqm/3wwFygMLaNK8Pyqq5KNtYOLZaOD8yGd gokv1B/psCF0QHHbTbAXI4gm1qDC66J1Iv5OYj9pUwgTJQjFSwOy11upWYW0kq7fRL0M 5B0ZRd1YJuvRaopRIzMUZUuo2TBGQTioqAoX7gb7b0FCDMpjonlIrdnw0nbuGqFXZXE/ JI/p6DYjTf4sHl+IUwrVqRAaXnAvvGFVoaSnvsV6ezwfw0kSbg9tMDfU+IKCwHYs2OB8 kDGFKybp9/UntbT+C+nIXBjkzE3OGKXD1+zvgcGJtBpDTfMGHoGYfmqQLu0oxrLgMfyM sICQ== X-Gm-Message-State: ABy/qLbOG2+0RqEHIPSC3guWcIWaXVfePeT++nUou/ONYsRsLal7ZuH6 j1/QiwiiPN4xMiFVYbPjdXzL63ewg0wJjZH6QxZ1iA== X-Google-Smtp-Source: APBJJlF2POzs0JiDlLB6/5fj5bT2PEm625iQ8R7ZMp4vjPEFJvEfQgAYflOknaXzwi3RrOdMIJI9UZP+pXJQibDjrAE= X-Received: by 2002:a05:6e02:144d:b0:346:48bd:da43 with SMTP id p13-20020a056e02144d00b0034648bdda43mr600950ilo.4.1690824079368; Mon, 31 Jul 2023 10:21:19 -0700 (PDT) MIME-Version: 1.0 References: <20230722022251.3446223-1-rananta@google.com> <20230722022251.3446223-2-rananta@google.com> <87v8e5r6s6.wl-maz@kernel.org> In-Reply-To: <87v8e5r6s6.wl-maz@kernel.org> From: Raghavendra Rao Ananta Date: Mon, 31 Jul 2023 10:21:08 -0700 Message-ID: Subject: Re: [PATCH v7 01/12] KVM: Rename kvm_arch_flush_remote_tlb() to kvm_arch_flush_remote_tlbs() To: Marc Zyngier Cc: Oliver Upton , James Morse , Suzuki K Poulose , Paolo Bonzini , Sean Christopherson , Huacai Chen , Zenghui Yu , Anup Patel , Atish Patra , Jing Zhang , Reiji Watanabe , Colton Lewis , David Matlack , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-mips@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Gavin Shan , =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= , Shaoqin Huang Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org On Thu, Jul 27, 2023 at 3:24=E2=80=AFAM Marc Zyngier wrote= : > > On Sat, 22 Jul 2023 03:22:40 +0100, > Raghavendra Rao Ananta wrote: > > > > From: David Matlack > > > > Rename kvm_arch_flush_remote_tlb() and the associated macro > > __KVM_HAVE_ARCH_FLUSH_REMOTE_TLB to kvm_arch_flush_remote_tlbs() and > > __KVM_HAVE_ARCH_FLUSH_REMOTE_TLBS respectively. > > > > Making the name plural matches kvm_flush_remote_tlbs() and makes it mor= e > > clear that this function can affect more than one remote TLB. > > > > No functional change intended. > > > > Signed-off-by: David Matlack > > Signed-off-by: Raghavendra Rao Ananta > > Reviewed-by: Gavin Shan > > Reviewed-by: Philippe Mathieu-Daud=C3=A9 > > Reviewed-by: Shaoqin Huang > > --- > > arch/mips/include/asm/kvm_host.h | 4 ++-- > > arch/mips/kvm/mips.c | 2 +- > > arch/x86/include/asm/kvm_host.h | 4 ++-- > > include/linux/kvm_host.h | 4 ++-- > > virt/kvm/kvm_main.c | 2 +- > > 5 files changed, 8 insertions(+), 8 deletions(-) > > > > diff --git a/arch/mips/include/asm/kvm_host.h b/arch/mips/include/asm/k= vm_host.h > > index 04cedf9f8811..9b0ad8f3bf32 100644 > > --- a/arch/mips/include/asm/kvm_host.h > > +++ b/arch/mips/include/asm/kvm_host.h > > @@ -896,7 +896,7 @@ static inline void kvm_arch_sched_in(struct kvm_vcp= u *vcpu, int cpu) {} > > static inline void kvm_arch_vcpu_blocking(struct kvm_vcpu *vcpu) {} > > static inline void kvm_arch_vcpu_unblocking(struct kvm_vcpu *vcpu) {} > > > > -#define __KVM_HAVE_ARCH_FLUSH_REMOTE_TLB > > -int kvm_arch_flush_remote_tlb(struct kvm *kvm); > > +#define __KVM_HAVE_ARCH_FLUSH_REMOTE_TLBS > > +int kvm_arch_flush_remote_tlbs(struct kvm *kvm); > > How about making this prototype global? I don't see a point in having > it per-architecture, specially as you are adding arm64 to that mix in > the following patch. > We can make it global, but I'm not sure what was the intention of the original author. My guess is that he was following the same style that we have for some of the other kvm_arch_*() functions (kvm_arch_free_vm() for example)? - Raghavendra > M. > > -- > Without deviation from the norm, progress is not possible.