linux-mips.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] MIPS: loongson32: Remove unused dma.h and nand.h
@ 2023-08-28 13:02 Keguang Zhang
  2023-08-28 13:15 ` Thomas Bogendoerfer
  0 siblings, 1 reply; 3+ messages in thread
From: Keguang Zhang @ 2023-08-28 13:02 UTC (permalink / raw)
  To: linux-mips, linux-kernel; +Cc: Thomas Bogendoerfer, Keguang Zhang

Since commit 7b3415f581c7 ("MIPS: Loongson32: Remove
unused platform devices"), no one is using dma.h and nand.h.
Therefore, remove these unused header files.

Signed-off-by: Keguang Zhang <keguang.zhang@gmail.com>
---
 arch/mips/include/asm/mach-loongson32/dma.h  | 21 ----------------
 arch/mips/include/asm/mach-loongson32/nand.h | 26 --------------------
 2 files changed, 47 deletions(-)
 delete mode 100644 arch/mips/include/asm/mach-loongson32/dma.h
 delete mode 100644 arch/mips/include/asm/mach-loongson32/nand.h

diff --git a/arch/mips/include/asm/mach-loongson32/dma.h b/arch/mips/include/asm/mach-loongson32/dma.h
deleted file mode 100644
index e917b3ccb2c2..000000000000
--- a/arch/mips/include/asm/mach-loongson32/dma.h
+++ /dev/null
@@ -1,21 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
-/*
- * Copyright (c) 2015 Zhang, Keguang <keguang.zhang@gmail.com>
- *
- * Loongson 1 NAND platform support.
- */
-
-#ifndef __ASM_MACH_LOONGSON32_DMA_H
-#define __ASM_MACH_LOONGSON32_DMA_H
-
-#define LS1X_DMA_CHANNEL0	0
-#define LS1X_DMA_CHANNEL1	1
-#define LS1X_DMA_CHANNEL2	2
-
-struct plat_ls1x_dma {
-	int nr_channels;
-};
-
-extern struct plat_ls1x_dma ls1b_dma_pdata;
-
-#endif /* __ASM_MACH_LOONGSON32_DMA_H */
diff --git a/arch/mips/include/asm/mach-loongson32/nand.h b/arch/mips/include/asm/mach-loongson32/nand.h
deleted file mode 100644
index aaf5ed19d78d..000000000000
--- a/arch/mips/include/asm/mach-loongson32/nand.h
+++ /dev/null
@@ -1,26 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
-/*
- * Copyright (c) 2015 Zhang, Keguang <keguang.zhang@gmail.com>
- *
- * Loongson 1 NAND platform support.
- */
-
-#ifndef __ASM_MACH_LOONGSON32_NAND_H
-#define __ASM_MACH_LOONGSON32_NAND_H
-
-#include <linux/dmaengine.h>
-#include <linux/mtd/partitions.h>
-
-struct plat_ls1x_nand {
-	struct mtd_partition *parts;
-	unsigned int nr_parts;
-
-	int hold_cycle;
-	int wait_cycle;
-};
-
-extern struct plat_ls1x_nand ls1b_nand_pdata;
-
-bool ls1x_dma_filter_fn(struct dma_chan *chan, void *param);
-
-#endif /* __ASM_MACH_LOONGSON32_NAND_H */

base-commit: be87eab1320e25c7d43cec7ee59bc607050abe85
-- 
2.39.2


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] MIPS: loongson32: Remove unused dma.h and nand.h
  2023-08-28 13:02 [PATCH] MIPS: loongson32: Remove unused dma.h and nand.h Keguang Zhang
@ 2023-08-28 13:15 ` Thomas Bogendoerfer
  2023-08-28 13:24   ` Keguang Zhang
  0 siblings, 1 reply; 3+ messages in thread
From: Thomas Bogendoerfer @ 2023-08-28 13:15 UTC (permalink / raw)
  To: Keguang Zhang; +Cc: linux-mips, linux-kernel

On Mon, Aug 28, 2023 at 09:02:23PM +0800, Keguang Zhang wrote:
> Since commit 7b3415f581c7 ("MIPS: Loongson32: Remove
> unused platform devices"), no one is using dma.h and nand.h.
> Therefore, remove these unused header files.

I don't think so:

/local/tbogendoerfer/korg/linux/arch/mips/loongson32/ls1b/board.c:11:17: fatal error: dma.h: No such file or directory
 #include <dma.h>

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] MIPS: loongson32: Remove unused dma.h and nand.h
  2023-08-28 13:15 ` Thomas Bogendoerfer
@ 2023-08-28 13:24   ` Keguang Zhang
  0 siblings, 0 replies; 3+ messages in thread
From: Keguang Zhang @ 2023-08-28 13:24 UTC (permalink / raw)
  To: Thomas Bogendoerfer; +Cc: linux-mips, linux-kernel

On Mon, Aug 28, 2023 at 9:15 PM Thomas Bogendoerfer
<tsbogend@alpha.franken.de> wrote:
>
> On Mon, Aug 28, 2023 at 09:02:23PM +0800, Keguang Zhang wrote:
> > Since commit 7b3415f581c7 ("MIPS: Loongson32: Remove
> > unused platform devices"), no one is using dma.h and nand.h.
> > Therefore, remove these unused header files.
>
> I don't think so:
>
> /local/tbogendoerfer/korg/linux/arch/mips/loongson32/ls1b/board.c:11:17: fatal error: dma.h: No such file or directory
>  #include <dma.h>
>
Sorry for my careless.
I will send v2 to fix this.

> Thomas.
>
> --
> Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
> good idea.                                                [ RFC1925, 2.3 ]



-- 
Best regards,

Keguang Zhang

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-08-28 13:25 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-28 13:02 [PATCH] MIPS: loongson32: Remove unused dma.h and nand.h Keguang Zhang
2023-08-28 13:15 ` Thomas Bogendoerfer
2023-08-28 13:24   ` Keguang Zhang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).