[PATCH RESEND v9 0/2] Add support for Loongson1 APB DMA

[PATCH RESEND v9 0/2] Add support for Loongson1 APB DMA

[Keguang Zhang via B4 Relay]

Add the driver and dt-binding document for Loongson1 APB DMA.

---
Changes in v9:
- Fix all the errors and warnings when building with W=1 and C=1
- Link to v8: https://lore.kernel.org/r/20240607-loongson1-dma-v8-0-f9992d257250@gmail.com

Changes in v8:
- Change 'interrupts' property to an items list
- Link to v7: https://lore.kernel.org/r/20240329-loongson1-dma-v7-0-37db58608de5@gmail.com

Changes in v7:
- Change the comptible to 'loongson,ls1*-apbdma' (suggested by Huacai Chen)
- Update the title and description part accordingly
- Rename the file to loongson,ls1b-apbdma.yaml
- Add a compatible string for LS1A
- Delete minItems of 'interrupts'
- Change patterns of 'interrupt-names' to const
- Rename the file to loongson1-apb-dma.c to keep the consistency
- Update Kconfig and Makefile accordingly
- Link to v6: https://lore.kernel.org/r/20240316-loongson1-dma-v6-0-90de2c3cc928@gmail.com

Changes in v6:
- Change the compatible to the fallback
- Implement .device_prep_dma_cyclic for Loongson1 sound driver,
- as well as .device_pause and .device_resume.
- Set the limitation LS1X_DMA_MAX_DESC and put all descriptors
- into one page to save memory
- Move dma_pool_zalloc() into ls1x_dma_alloc_desc()
- Drop dma_slave_config structure
- Use .remove_new instead of .remove
- Use KBUILD_MODNAME for the driver name
- Improve the debug information
- Some minor fixes

Changes in v5:
- Add the dt-binding document
- Add DT support
- Use DT information instead of platform data
- Use chan_id of struct dma_chan instead of own id
- Use of_dma_xlate_by_chan_id() instead of ls1x_dma_filter()
- Update the author information to my official name

Changes in v4:
- Use dma_slave_map to find the proper channel.
- Explicitly call devm_request_irq() and tasklet_kill().
- Fix namespace issue.
- Some minor fixes and cleanups.

Changes in v3:
- Rename ls1x_dma_filter_fn to ls1x_dma_filter.

Changes in v2:
- Change the config from 'DMA_LOONGSON1' to 'LOONGSON1_DMA',
- and rearrange it in alphabetical order in Kconfig and Makefile.
- Fix comment style.

---
Keguang Zhang (2):
      dt-bindings: dma: Add Loongson-1 APB DMA
      dmaengine: Loongson1: Add Loongson-1 APB DMA driver

 .../bindings/dma/loongson,ls1b-apbdma.yaml         |  67 +++
 drivers/dma/Kconfig                                |   9 +
 drivers/dma/Makefile                               |   1 +
 drivers/dma/loongson1-apb-dma.c                    | 665 +++++++++++++++++++++
 4 files changed, 742 insertions(+)
---
base-commit: d35b2284e966c0bef3e2182a5c5ea02177dd32e4
change-id: 20231120-loongson1-dma-163afe5708b9

Best regards,
-- 
Keguang Zhang <keguang.zhang@gmail.com>

[PATCH RESEND v9 1/2] dt-bindings: dma: Add Loongson-1 APB DMA

[Keguang Zhang via B4 Relay]

From: Keguang Zhang <keguang.zhang@gmail.com>

Add devicetree binding document for Loongson-1 APB DMA.

Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Reviewed-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
Signed-off-by: Keguang Zhang <keguang.zhang@gmail.com>
---
Changes in v9:
- None

Changes in v8:
- Change 'interrupts' property to an items list

Changes in v7:
- Change the comptible to 'loongson,ls1*-apbdma' (suggested by Huacai Chen)
- Update the title and description part accordingly
- Rename the file to loongson,ls1b-apbdma.yaml
- Add a compatible string for LS1A
- Delete minItems of 'interrupts'
- Change patterns of 'interrupt-names' to const

Changes in v6:
- Change the compatible to the fallback
- Some minor fixes

Changes in v5:
- A newly added patch
---
 .../bindings/dma/loongson,ls1b-apbdma.yaml         | 67 ++++++++++++++++++++++
 1 file changed, 67 insertions(+)

diff --git a/Documentation/devicetree/bindings/dma/loongson,ls1b-apbdma.yaml b/Documentation/devicetree/bindings/dma/loongson,ls1b-apbdma.yaml
new file mode 100644
index 000000000000..192c85c1199d
--- /dev/null
+++ b/Documentation/devicetree/bindings/dma/loongson,ls1b-apbdma.yaml
@@ -0,0 +1,67 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/dma/loongson,ls1b-apbdma.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Loongson-1 APB DMA Controller
+
+maintainers:
+  - Keguang Zhang <keguang.zhang@gmail.com>
+
+description:
+  Loongson-1 APB DMA controller provides 3 independent channels for
+  peripherals such as NAND, audio playback and capture.
+
+properties:
+  compatible:
+    oneOf:
+      - const: loongson,ls1b-apbdma
+      - items:
+          - enum:
+              - loongson,ls1a-apbdma
+              - loongson,ls1c-apbdma
+          - const: loongson,ls1b-apbdma
+
+  reg:
+    maxItems: 1
+
+  interrupts:
+    items:
+      - description: NAND interrupt
+      - description: Audio playback interrupt
+      - description: Audio capture interrupt
+
+  interrupt-names:
+    items:
+      - const: ch0
+      - const: ch1
+      - const: ch2
+
+  '#dma-cells':
+    const: 1
+
+required:
+  - compatible
+  - reg
+  - interrupts
+  - interrupt-names
+  - '#dma-cells'
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/interrupt-controller/irq.h>
+    dma-controller@1fd01160 {
+        compatible = "loongson,ls1b-apbdma";
+        reg = <0x1fd01160 0x4>;
+
+        interrupt-parent = <&intc0>;
+        interrupts = <13 IRQ_TYPE_EDGE_RISING>,
+                     <14 IRQ_TYPE_EDGE_RISING>,
+                     <15 IRQ_TYPE_EDGE_RISING>;
+        interrupt-names = "ch0", "ch1", "ch2";
+
+        #dma-cells = <1>;
+    };

-- 
2.43.0

[PATCH RESEND v9 2/2] dmaengine: Loongson1: Add Loongson-1 APB DMA driver

[Keguang Zhang via B4 Relay]

From: Keguang Zhang <keguang.zhang@gmail.com>

This patch adds APB DMA driver for Loongson-1 SoCs.

Reviewed-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
Signed-off-by: Keguang Zhang <keguang.zhang@gmail.com>
---
Changes in v9:
- Fix all the errors and warnings when building with W=1 and C=1

Changes in v8:
- None

Changes in v7:
- Change the comptible to 'loongson,ls1*-apbdma'
- Update Kconfig and Makefile accordingly
- Rename the file to loongson1-apb-dma.c to keep the consistency

Changes in v6:
- Implement .device_prep_dma_cyclic for Loongson1 audio driver,
- as well as .device_pause and .device_resume.
- Set the limitation LS1X_DMA_MAX_DESC and put all descriptors
- into one page to save memory
- Move dma_pool_zalloc() into ls1x_dma_alloc_desc()
- Drop dma_slave_config structure
- Use .remove_new instead of .remove
- Use KBUILD_MODNAME for the driver name
- Improve the debug information

Changes in v5:
- Add DT support
- Use DT data instead of platform data
- Use chan_id of struct dma_chan instead of own id
- Use of_dma_xlate_by_chan_id() instead of ls1x_dma_filter()
- Update the author information to my official name

Changes in v4:
- Use dma_slave_map to find the proper channel.
- Explicitly call devm_request_irq() and tasklet_kill().
- Fix namespace issue.
- Some minor fixes and cleanups.

Changes in v3:
- Rename ls1x_dma_filter_fn to ls1x_dma_filter.

Changes in v2:
- Change the config from 'DMA_LOONGSON1' to 'LOONGSON1_DMA',
- and rearrange it in alphabetical order in Kconfig and Makefile.
- Fix comment style.
---
 drivers/dma/Kconfig             |   9 +
 drivers/dma/Makefile            |   1 +
 drivers/dma/loongson1-apb-dma.c | 665 ++++++++++++++++++++++++++++++++++++++++
 3 files changed, 675 insertions(+)

diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig
index 002a5ec80620..f7b06c4cdf3f 100644
--- a/drivers/dma/Kconfig
+++ b/drivers/dma/Kconfig
@@ -369,6 +369,15 @@ config K3_DMA
 	  Support the DMA engine for Hisilicon K3 platform
 	  devices.
 
+config LOONGSON1_APB_DMA
+	tristate "Loongson1 APB DMA support"
+	depends on MACH_LOONGSON32 || COMPILE_TEST
+	select DMA_ENGINE
+	select DMA_VIRTUAL_CHANNELS
+	help
+	  This selects support for the APB DMA controller in Loongson1 SoCs,
+	  which is required by Loongson1 NAND and audio support.
+
 config LPC18XX_DMAMUX
 	bool "NXP LPC18xx/43xx DMA MUX for PL080"
 	depends on ARCH_LPC18XX || COMPILE_TEST
diff --git a/drivers/dma/Makefile b/drivers/dma/Makefile
index 802ca916f05f..eb04bb7f19d7 100644
--- a/drivers/dma/Makefile
+++ b/drivers/dma/Makefile
@@ -49,6 +49,7 @@ obj-$(CONFIG_INTEL_IDMA64) += idma64.o
 obj-$(CONFIG_INTEL_IOATDMA) += ioat/
 obj-y += idxd/
 obj-$(CONFIG_K3_DMA) += k3dma.o
+obj-$(CONFIG_LOONGSON1_APB_DMA) += loongson1-apb-dma.o
 obj-$(CONFIG_LPC18XX_DMAMUX) += lpc18xx-dmamux.o
 obj-$(CONFIG_LS2X_APB_DMA) += ls2x-apb-dma.o
 obj-$(CONFIG_MILBEAUT_HDMAC) += milbeaut-hdmac.o
diff --git a/drivers/dma/loongson1-apb-dma.c b/drivers/dma/loongson1-apb-dma.c
new file mode 100644
index 000000000000..fe259eccc71d
--- /dev/null
+++ b/drivers/dma/loongson1-apb-dma.c
@@ -0,0 +1,665 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
+/*
+ * Driver for Loongson-1 APB DMA Controller
+ *
+ * Copyright (C) 2015-2024 Keguang Zhang <keguang.zhang@gmail.com>
+ */
+
+#include <linux/dmapool.h>
+#include <linux/dma-mapping.h>
+#include <linux/init.h>
+#include <linux/interrupt.h>
+#include <linux/iopoll.h>
+#include <linux/module.h>
+#include <linux/of.h>
+#include <linux/of_dma.h>
+#include <linux/platform_device.h>
+#include <linux/slab.h>
+
+#include "dmaengine.h"
+#include "virt-dma.h"
+
+/* Loongson-1 DMA Control Register */
+#define DMA_CTRL			0x0
+
+/* DMA Control Register Bits */
+#define DMA_STOP			BIT(4)
+#define DMA_START			BIT(3)
+#define DMA_ASK_VALID			BIT(2)
+
+#define DMA_ADDR_MASK			GENMASK(31, 6)
+
+/* DMA Next Field Bits */
+#define DMA_NEXT_VALID			BIT(0)
+
+/* DMA Command Field Bits */
+#define DMA_RAM2DEV			BIT(12)
+#define DMA_INT				BIT(1)
+#define DMA_INT_MASK			BIT(0)
+
+#define LS1X_DMA_MAX_CHANNELS		3
+
+/* Size of allocations for hardware descriptors */
+#define LS1X_DMA_DESCS_SIZE		PAGE_SIZE
+#define LS1X_DMA_MAX_DESC		\
+	(LS1X_DMA_DESCS_SIZE / sizeof(struct ls1x_dma_hwdesc))
+
+struct ls1x_dma_hwdesc {
+	u32 next;		/* next descriptor address */
+	u32 saddr;		/* memory DMA address */
+	u32 daddr;		/* device DMA address */
+	u32 length;
+	u32 stride;
+	u32 cycles;
+	u32 cmd;
+	u32 stats;
+};
+
+struct ls1x_dma_desc {
+	struct virt_dma_desc vdesc;
+	enum dma_transfer_direction dir;
+	enum dma_transaction_type type;
+	unsigned int bus_width;
+
+	unsigned int nr_descs;	/* number of descriptors */
+
+	struct ls1x_dma_hwdesc *hwdesc;
+	dma_addr_t hwdesc_phys;
+};
+
+struct ls1x_dma_chan {
+	struct virt_dma_chan vchan;
+	struct dma_pool *desc_pool;
+	phys_addr_t src_addr;
+	phys_addr_t dst_addr;
+	enum dma_slave_buswidth src_addr_width;
+	enum dma_slave_buswidth dst_addr_width;
+
+	void __iomem *reg_base;
+	int irq;
+
+	struct ls1x_dma_desc *desc;
+
+	struct ls1x_dma_hwdesc *curr_hwdesc;
+	dma_addr_t curr_hwdesc_phys;
+};
+
+struct ls1x_dma {
+	struct dma_device ddev;
+	void __iomem *reg_base;
+
+	unsigned int nr_chans;
+	struct ls1x_dma_chan chan[];
+};
+
+#define to_ls1x_dma_chan(dchan)		\
+	container_of(dchan, struct ls1x_dma_chan, vchan.chan)
+
+#define to_ls1x_dma_desc(vd)		\
+	container_of(vd, struct ls1x_dma_desc, vdesc)
+
+/* macros for registers read/write */
+#define chan_readl(chan, off)		\
+	readl((chan)->reg_base + (off))
+
+#define chan_writel(chan, off, val)	\
+	writel((val), (chan)->reg_base + (off))
+
+static inline struct device *chan2dev(struct dma_chan *chan)
+{
+	return &chan->dev->device;
+}
+
+static inline int ls1x_dma_query(struct ls1x_dma_chan *chan,
+				 dma_addr_t *hwdesc_phys)
+{
+	struct dma_chan *dchan = &chan->vchan.chan;
+	int val, ret;
+
+	val = *hwdesc_phys & DMA_ADDR_MASK;
+	val |= DMA_ASK_VALID;
+	val |= dchan->chan_id;
+	chan_writel(chan, DMA_CTRL, val);
+	ret = readl_poll_timeout_atomic(chan->reg_base + DMA_CTRL, val,
+					!(val & DMA_ASK_VALID), 0, 3000);
+	if (ret)
+		dev_err(chan2dev(dchan), "failed to query DMA\n");
+
+	return ret;
+}
+
+static inline int ls1x_dma_start(struct ls1x_dma_chan *chan,
+				 dma_addr_t *hwdesc_phys)
+{
+	struct dma_chan *dchan = &chan->vchan.chan;
+	int val, ret;
+
+	dev_dbg(chan2dev(dchan), "cookie=%d, starting hwdesc=%x\n",
+		dchan->cookie, *hwdesc_phys);
+
+	val = *hwdesc_phys & DMA_ADDR_MASK;
+	val |= DMA_START;
+	val |= dchan->chan_id;
+	chan_writel(chan, DMA_CTRL, val);
+	ret = readl_poll_timeout(chan->reg_base + DMA_CTRL, val,
+				 !(val & DMA_START), 0, 3000);
+	if (ret)
+		dev_err(chan2dev(dchan), "failed to start DMA\n");
+
+	return ret;
+}
+
+static inline void ls1x_dma_stop(struct ls1x_dma_chan *chan)
+{
+	chan_writel(chan, DMA_CTRL, chan_readl(chan, DMA_CTRL) | DMA_STOP);
+}
+
+static void ls1x_dma_free_chan_resources(struct dma_chan *dchan)
+{
+	struct ls1x_dma_chan *chan = to_ls1x_dma_chan(dchan);
+
+	dma_free_coherent(chan2dev(dchan), sizeof(struct ls1x_dma_hwdesc),
+			  chan->curr_hwdesc, chan->curr_hwdesc_phys);
+	vchan_free_chan_resources(&chan->vchan);
+	dma_pool_destroy(chan->desc_pool);
+	chan->desc_pool = NULL;
+}
+
+static int ls1x_dma_alloc_chan_resources(struct dma_chan *dchan)
+{
+	struct ls1x_dma_chan *chan = to_ls1x_dma_chan(dchan);
+
+	chan->desc_pool = dma_pool_create(dma_chan_name(dchan),
+					  chan2dev(dchan),
+					  sizeof(struct ls1x_dma_hwdesc),
+					  __alignof__(struct ls1x_dma_hwdesc),
+					  0);
+	if (!chan->desc_pool)
+		return -ENOMEM;
+
+	/* allocate memory for querying current HW descriptor */
+	dma_set_coherent_mask(chan2dev(dchan), DMA_BIT_MASK(32));
+	chan->curr_hwdesc = dma_alloc_coherent(chan2dev(dchan),
+					       sizeof(struct ls1x_dma_hwdesc),
+					       &chan->curr_hwdesc_phys,
+					       GFP_KERNEL);
+	if (!chan->curr_hwdesc)
+		return -ENOMEM;
+
+	return 0;
+}
+
+static void ls1x_dma_free_desc(struct virt_dma_desc *vdesc)
+{
+	struct ls1x_dma_desc *desc = to_ls1x_dma_desc(vdesc);
+	struct ls1x_dma_chan *chan = to_ls1x_dma_chan(vdesc->tx.chan);
+
+	dma_pool_free(chan->desc_pool, desc->hwdesc, desc->hwdesc_phys);
+	chan->desc = NULL;
+	kfree(desc);
+}
+
+static struct ls1x_dma_desc *
+ls1x_dma_alloc_desc(struct dma_chan *dchan, int sg_len,
+		    enum dma_transfer_direction direction,
+		    enum dma_transaction_type type)
+{
+	struct ls1x_dma_chan *chan = to_ls1x_dma_chan(dchan);
+	struct ls1x_dma_desc *desc;
+
+	if (sg_len > LS1X_DMA_MAX_DESC) {
+		dev_err(chan2dev(dchan), "sg_len %u exceeds limit %lu",
+			sg_len, LS1X_DMA_MAX_DESC);
+		return NULL;
+	}
+
+	desc = kzalloc(sizeof(*desc), GFP_NOWAIT);
+	if (!desc)
+		return NULL;
+
+	/* allocate HW descriptors */
+	desc->hwdesc = dma_pool_zalloc(chan->desc_pool, GFP_NOWAIT,
+				       &desc->hwdesc_phys);
+	if (!desc->hwdesc) {
+		dev_err(chan2dev(dchan), "failed to alloc HW descriptors\n");
+		ls1x_dma_free_desc(&desc->vdesc);
+		return NULL;
+	}
+
+	desc->dir = direction;
+	desc->type = type;
+	desc->nr_descs = sg_len;
+
+	return desc;
+}
+
+static int ls1x_dma_setup_hwdescs(struct dma_chan *dchan,
+				  struct ls1x_dma_desc *desc,
+				  struct scatterlist *sgl, unsigned int sg_len)
+{
+	struct ls1x_dma_chan *chan = to_ls1x_dma_chan(dchan);
+	dma_addr_t next_hwdesc_phys = desc->hwdesc_phys;
+
+	struct scatterlist *sg;
+	unsigned int dev_addr, cmd, i;
+
+	switch (desc->dir) {
+	case DMA_MEM_TO_DEV:
+		dev_addr = chan->dst_addr;
+		desc->bus_width = chan->dst_addr_width;
+		cmd = DMA_RAM2DEV | DMA_INT;
+		break;
+	case DMA_DEV_TO_MEM:
+		dev_addr = chan->src_addr;
+		desc->bus_width = chan->src_addr_width;
+		cmd = DMA_INT;
+		break;
+	default:
+		dev_err(chan2dev(dchan), "unsupported DMA direction: %s\n",
+			dmaengine_get_direction_text(desc->dir));
+		return -EINVAL;
+	}
+
+	/* setup HW descriptors */
+	for_each_sg(sgl, sg, sg_len, i) {
+		dma_addr_t buf_addr = sg_dma_address(sg);
+		size_t buf_len = sg_dma_len(sg);
+		struct ls1x_dma_hwdesc *hwdesc = &desc->hwdesc[i];
+
+		if (!is_dma_copy_aligned(dchan->device, buf_addr, 0, buf_len)) {
+			dev_err(chan2dev(dchan), "buffer is not aligned!\n");
+			return -EINVAL;
+		}
+
+		hwdesc->saddr = buf_addr;
+		hwdesc->daddr = dev_addr;
+		hwdesc->length = buf_len / desc->bus_width;
+		hwdesc->stride = 0;
+		hwdesc->cycles = 1;
+		hwdesc->cmd = cmd;
+
+		if (i) {
+			next_hwdesc_phys += sizeof(*hwdesc);
+			desc->hwdesc[i - 1].next = next_hwdesc_phys
+			    | DMA_NEXT_VALID;
+		}
+	}
+
+	if (desc->type == DMA_CYCLIC)
+		desc->hwdesc[i - 1].next = desc->hwdesc_phys | DMA_NEXT_VALID;
+
+	for_each_sg(sgl, sg, sg_len, i) {
+		struct ls1x_dma_hwdesc *hwdesc = &desc->hwdesc[i];
+
+		print_hex_dump_debug("HW DESC: ", DUMP_PREFIX_OFFSET, 16, 4,
+				     hwdesc, sizeof(*hwdesc), false);
+	}
+
+	return 0;
+}
+
+static struct dma_async_tx_descriptor *
+ls1x_dma_prep_slave_sg(struct dma_chan *dchan,
+		       struct scatterlist *sgl, unsigned int sg_len,
+		       enum dma_transfer_direction direction,
+		       unsigned long flags, void *context)
+{
+	struct ls1x_dma_chan *chan = to_ls1x_dma_chan(dchan);
+	struct ls1x_dma_desc *desc;
+
+	dev_dbg(chan2dev(dchan), "sg_len=%u flags=0x%lx dir=%s\n",
+		sg_len, flags, dmaengine_get_direction_text(direction));
+
+	desc = ls1x_dma_alloc_desc(dchan, sg_len, direction, DMA_SLAVE);
+	if (!desc)
+		return NULL;
+
+	if (ls1x_dma_setup_hwdescs(dchan, desc, sgl, sg_len)) {
+		ls1x_dma_free_desc(&desc->vdesc);
+		return NULL;
+	}
+
+	return vchan_tx_prep(&chan->vchan, &desc->vdesc, flags);
+}
+
+static struct dma_async_tx_descriptor *
+ls1x_dma_prep_dma_cyclic(struct dma_chan *dchan,
+			 dma_addr_t buf_addr, size_t buf_len, size_t period_len,
+			 enum dma_transfer_direction direction,
+			 unsigned long flags)
+{
+	struct ls1x_dma_chan *chan = to_ls1x_dma_chan(dchan);
+	struct ls1x_dma_desc *desc;
+	struct scatterlist *sgl;
+	unsigned int sg_len;
+	unsigned int i;
+
+	dev_dbg(chan2dev(dchan),
+		"buf_len=%d period_len=%zu flags=0x%lx dir=%s\n", buf_len,
+		period_len, flags, dmaengine_get_direction_text(direction));
+
+	sg_len = buf_len / period_len;
+	desc = ls1x_dma_alloc_desc(dchan, sg_len, direction, DMA_CYCLIC);
+	if (!desc)
+		return NULL;
+
+	/* allocate the scatterlist */
+	sgl = kmalloc_array(sg_len, sizeof(*sgl), GFP_NOWAIT);
+	if (!sgl)
+		return NULL;
+
+	sg_init_table(sgl, sg_len);
+	for (i = 0; i < sg_len; ++i) {
+		sg_set_page(&sgl[i], pfn_to_page(PFN_DOWN(buf_addr)),
+			    period_len, offset_in_page(buf_addr));
+		sg_dma_address(&sgl[i]) = buf_addr;
+		sg_dma_len(&sgl[i]) = period_len;
+		buf_addr += period_len;
+	}
+
+	if (ls1x_dma_setup_hwdescs(dchan, desc, sgl, sg_len)) {
+		ls1x_dma_free_desc(&desc->vdesc);
+		return NULL;
+	}
+
+	kfree(sgl);
+
+	return vchan_tx_prep(&chan->vchan, &desc->vdesc, flags);
+}
+
+static int ls1x_dma_slave_config(struct dma_chan *dchan,
+				 struct dma_slave_config *config)
+{
+	struct ls1x_dma_chan *chan = to_ls1x_dma_chan(dchan);
+
+	chan->src_addr = config->src_addr;
+	chan->src_addr_width = config->src_addr_width;
+	chan->dst_addr = config->dst_addr;
+	chan->dst_addr_width = config->dst_addr_width;
+
+	return 0;
+}
+
+static int ls1x_dma_pause(struct dma_chan *dchan)
+{
+	struct ls1x_dma_chan *chan = to_ls1x_dma_chan(dchan);
+	unsigned long flags;
+	int ret;
+
+	spin_lock_irqsave(&chan->vchan.lock, flags);
+	ret = ls1x_dma_query(chan, &chan->curr_hwdesc_phys);
+	if (!ret)
+		ls1x_dma_stop(chan);
+	spin_unlock_irqrestore(&chan->vchan.lock, flags);
+
+	return ret;
+}
+
+static int ls1x_dma_resume(struct dma_chan *dchan)
+{
+	struct ls1x_dma_chan *chan = to_ls1x_dma_chan(dchan);
+	unsigned long flags;
+	int ret;
+
+	spin_lock_irqsave(&chan->vchan.lock, flags);
+	ret = ls1x_dma_start(chan, &chan->curr_hwdesc_phys);
+	spin_unlock_irqrestore(&chan->vchan.lock, flags);
+
+	return ret;
+}
+
+static int ls1x_dma_terminate_all(struct dma_chan *dchan)
+{
+	struct ls1x_dma_chan *chan = to_ls1x_dma_chan(dchan);
+	unsigned long flags;
+	LIST_HEAD(head);
+
+	spin_lock_irqsave(&chan->vchan.lock, flags);
+	ls1x_dma_stop(chan);
+	vchan_get_all_descriptors(&chan->vchan, &head);
+	spin_unlock_irqrestore(&chan->vchan.lock, flags);
+
+	vchan_dma_desc_free_list(&chan->vchan, &head);
+
+	return 0;
+}
+
+static enum dma_status ls1x_dma_tx_status(struct dma_chan *dchan,
+					  dma_cookie_t cookie,
+					  struct dma_tx_state *state)
+{
+	struct ls1x_dma_chan *chan = to_ls1x_dma_chan(dchan);
+	enum dma_status status;
+	size_t bytes = 0;
+	unsigned long flags;
+
+	status = dma_cookie_status(dchan, cookie, state);
+	if (status == DMA_COMPLETE)
+		return status;
+
+	spin_lock_irqsave(&chan->vchan.lock, flags);
+	if (chan->desc && cookie == chan->desc->vdesc.tx.cookie) {
+		struct ls1x_dma_desc *desc = chan->desc;
+		int i;
+
+		if (ls1x_dma_query(chan, &chan->curr_hwdesc_phys)) {
+			spin_unlock_irqrestore(&chan->vchan.lock, flags);
+			return status;
+		}
+
+		/* locate the current HW descriptor */
+		for (i = 0; i < desc->nr_descs; i++)
+			if (desc->hwdesc[i].next == chan->curr_hwdesc->next)
+				break;
+
+		/* count the residues */
+		for (; i < desc->nr_descs; i++)
+			bytes += desc->hwdesc[i].length * desc->bus_width;
+
+		dma_set_residue(state, bytes);
+	}
+	spin_unlock_irqrestore(&chan->vchan.lock, flags);
+
+	return status;
+}
+
+static void ls1x_dma_issue_pending(struct dma_chan *dchan)
+{
+	struct ls1x_dma_chan *chan = to_ls1x_dma_chan(dchan);
+	struct virt_dma_desc *vdesc;
+	unsigned long flags;
+
+	spin_lock_irqsave(&chan->vchan.lock, flags);
+	if (vchan_issue_pending(&chan->vchan) && !chan->desc) {
+		vdesc = vchan_next_desc(&chan->vchan);
+		if (vdesc) {
+			chan->desc = to_ls1x_dma_desc(vdesc);
+			ls1x_dma_start(chan, &chan->desc->hwdesc_phys);
+		} else {
+			chan->desc = NULL;
+		}
+	}
+	spin_unlock_irqrestore(&chan->vchan.lock, flags);
+}
+
+static irqreturn_t ls1x_dma_irq_handler(int irq, void *data)
+{
+	struct ls1x_dma_chan *chan = data;
+	struct ls1x_dma_desc *desc = chan->desc;
+	struct dma_chan *dchan = &chan->vchan.chan;
+
+	if (!desc) {
+		dev_warn(chan2dev(dchan),
+			 "IRQ %d with no active descriptor on channel %d\n",
+			 irq, dchan->chan_id);
+		return IRQ_NONE;
+	}
+
+	dev_dbg(chan2dev(dchan), "DMA IRQ %d on channel %d\n", irq,
+		dchan->chan_id);
+
+	spin_lock(&chan->vchan.lock);
+
+	if (desc->type == DMA_CYCLIC) {
+		vchan_cyclic_callback(&desc->vdesc);
+	} else {
+		list_del(&desc->vdesc.node);
+		vchan_cookie_complete(&desc->vdesc);
+		chan->desc = NULL;
+	}
+
+	spin_unlock(&chan->vchan.lock);
+	return IRQ_HANDLED;
+}
+
+static int ls1x_dma_chan_probe(struct platform_device *pdev,
+			       struct ls1x_dma *dma, int chan_id)
+{
+	struct device *dev = &pdev->dev;
+	struct ls1x_dma_chan *chan = &dma->chan[chan_id];
+	char pdev_irqname[4];
+	char *irqname;
+	int ret;
+
+	sprintf(pdev_irqname, "ch%u", chan_id);
+	chan->irq = platform_get_irq_byname(pdev, pdev_irqname);
+	if (chan->irq < 0)
+		return -ENODEV;
+
+	irqname = devm_kasprintf(dev, GFP_KERNEL, "%s:%s",
+				 dev_name(dev), pdev_irqname);
+	if (!irqname)
+		return -ENOMEM;
+
+	ret = devm_request_irq(dev, chan->irq, ls1x_dma_irq_handler,
+			       IRQF_SHARED, irqname, chan);
+	if (ret)
+		return dev_err_probe(dev, ret,
+				     "failed to request IRQ %u!\n", chan->irq);
+
+	chan->reg_base = dma->reg_base;
+	chan->vchan.desc_free = ls1x_dma_free_desc;
+	vchan_init(&chan->vchan, &dma->ddev);
+	dev_info(dev, "%s (irq %d) initialized\n", pdev_irqname, chan->irq);
+
+	return 0;
+}
+
+static void ls1x_dma_chan_remove(struct ls1x_dma *dma, int chan_id)
+{
+	struct device *dev = dma->ddev.dev;
+	struct ls1x_dma_chan *chan = &dma->chan[chan_id];
+
+	devm_free_irq(dev, chan->irq, chan);
+	list_del(&chan->vchan.chan.device_node);
+	tasklet_kill(&chan->vchan.task);
+}
+
+static int ls1x_dma_probe(struct platform_device *pdev)
+{
+	struct device *dev = &pdev->dev;
+	struct dma_device *ddev;
+	struct ls1x_dma *dma;
+	int nr_chans, ret, i;
+
+	nr_chans = platform_irq_count(pdev);
+	if (nr_chans <= 0)
+		return nr_chans;
+	if (nr_chans > LS1X_DMA_MAX_CHANNELS)
+		return dev_err_probe(dev, -EINVAL,
+				     "nr_chans=%d exceeds the maximum\n",
+				     nr_chans);
+
+	dma = devm_kzalloc(dev, struct_size(dma, chan, nr_chans), GFP_KERNEL);
+	if (!dma)
+		return -ENOMEM;
+
+	/* initialize DMA device */
+	dma->reg_base = devm_platform_ioremap_resource(pdev, 0);
+	if (IS_ERR(dma->reg_base))
+		return PTR_ERR(dma->reg_base);
+
+	ddev = &dma->ddev;
+	ddev->dev = dev;
+	ddev->copy_align = DMAENGINE_ALIGN_4_BYTES;
+	ddev->src_addr_widths = BIT(DMA_SLAVE_BUSWIDTH_1_BYTE) |
+	    BIT(DMA_SLAVE_BUSWIDTH_2_BYTES) | BIT(DMA_SLAVE_BUSWIDTH_4_BYTES);
+	ddev->dst_addr_widths = BIT(DMA_SLAVE_BUSWIDTH_1_BYTE) |
+	    BIT(DMA_SLAVE_BUSWIDTH_2_BYTES) | BIT(DMA_SLAVE_BUSWIDTH_4_BYTES);
+	ddev->directions = BIT(DMA_DEV_TO_MEM) | BIT(DMA_MEM_TO_DEV);
+	ddev->max_sg_burst = LS1X_DMA_MAX_DESC;
+	ddev->residue_granularity = DMA_RESIDUE_GRANULARITY_SEGMENT;
+	ddev->device_alloc_chan_resources = ls1x_dma_alloc_chan_resources;
+	ddev->device_free_chan_resources = ls1x_dma_free_chan_resources;
+	ddev->device_prep_slave_sg = ls1x_dma_prep_slave_sg;
+	ddev->device_prep_dma_cyclic = ls1x_dma_prep_dma_cyclic;
+	ddev->device_config = ls1x_dma_slave_config;
+	ddev->device_pause = ls1x_dma_pause;
+	ddev->device_resume = ls1x_dma_resume;
+	ddev->device_terminate_all = ls1x_dma_terminate_all;
+	ddev->device_tx_status = ls1x_dma_tx_status;
+	ddev->device_issue_pending = ls1x_dma_issue_pending;
+
+	dma_cap_set(DMA_SLAVE, ddev->cap_mask);
+	INIT_LIST_HEAD(&ddev->channels);
+
+	/* initialize DMA channels */
+	for (i = 0; i < nr_chans; i++) {
+		ret = ls1x_dma_chan_probe(pdev, dma, i);
+		if (ret)
+			return ret;
+	}
+	dma->nr_chans = nr_chans;
+
+	ret = dmaenginem_async_device_register(ddev);
+	if (ret) {
+		dev_err(dev, "failed to register DMA device! %d\n", ret);
+		return ret;
+	}
+
+	ret =
+	    of_dma_controller_register(dev->of_node, of_dma_xlate_by_chan_id,
+				       ddev);
+	if (ret) {
+		dev_err(dev, "failed to register DMA controller! %d\n", ret);
+		return ret;
+	}
+
+	platform_set_drvdata(pdev, dma);
+	dev_info(dev, "Loongson1 DMA driver registered\n");
+
+	return 0;
+}
+
+static void ls1x_dma_remove(struct platform_device *pdev)
+{
+	struct ls1x_dma *dma = platform_get_drvdata(pdev);
+	int i;
+
+	of_dma_controller_free(pdev->dev.of_node);
+
+	for (i = 0; i < dma->nr_chans; i++)
+		ls1x_dma_chan_remove(dma, i);
+}
+
+static const struct of_device_id ls1x_dma_match[] = {
+	{ .compatible = "loongson,ls1b-apbdma" },
+	{ .compatible = "loongson,ls1c-apbdma" },
+	{ /* sentinel */ }
+};
+MODULE_DEVICE_TABLE(of, ls1x_dma_match);
+
+static struct platform_driver ls1x_dma_driver = {
+	.probe = ls1x_dma_probe,
+	.remove_new = ls1x_dma_remove,
+	.driver	= {
+		.name = KBUILD_MODNAME,
+		.of_match_table = ls1x_dma_match,
+	},
+};
+
+module_platform_driver(ls1x_dma_driver);
+
+MODULE_AUTHOR("Keguang Zhang <keguang.zhang@gmail.com>");
+MODULE_DESCRIPTION("Loongson-1 APB DMA Controller driver");
+MODULE_LICENSE("GPL");

-- 
2.43.0

Re: [PATCH RESEND v9 0/2] Add support for Loongson1 APB DMA

[Huacai Chen]

Hi, Keguang,

I accept your suggestion about the cpufreq driver naming, and now it
is upstream:
https://git.kernel.org/pub/scm/linux/kernel/git/vireshk/pm.git/commit/?h=cpufreq/arm/linux-next&id=ccf51454145bffd98e31cdbe54a4262473c609e2

I still hope you can accept my suggestion about the dma driver naming.

I know you hope me rename LS2X_APB_DMA to LOONGSON2_APB_DMA, but as I
said before, renaming an existing Kconfig option will break config
files.

See an example:
Commit a50a3f4b6a313dc76912bd4ad3b8b4f4b4 introduce PREEMPT_RT and
rename PREEMPT to PREEMPT_LL, but then commit
b8d3349803ba34afda429e87a837fd95a9 rename it back because of config
files broken.


Huacai

On Thu, Jul 11, 2024 at 6:57 PM Keguang Zhang via B4 Relay
<devnull+keguang.zhang.gmail.com@kernel.org> wrote:
>
> Add the driver and dt-binding document for Loongson1 APB DMA.
>
> ---
> Changes in v9:
> - Fix all the errors and warnings when building with W=1 and C=1
> - Link to v8: https://lore.kernel.org/r/20240607-loongson1-dma-v8-0-f9992d257250@gmail.com
>
> Changes in v8:
> - Change 'interrupts' property to an items list
> - Link to v7: https://lore.kernel.org/r/20240329-loongson1-dma-v7-0-37db58608de5@gmail.com
>
> Changes in v7:
> - Change the comptible to 'loongson,ls1*-apbdma' (suggested by Huacai Chen)
> - Update the title and description part accordingly
> - Rename the file to loongson,ls1b-apbdma.yaml
> - Add a compatible string for LS1A
> - Delete minItems of 'interrupts'
> - Change patterns of 'interrupt-names' to const
> - Rename the file to loongson1-apb-dma.c to keep the consistency
> - Update Kconfig and Makefile accordingly
> - Link to v6: https://lore.kernel.org/r/20240316-loongson1-dma-v6-0-90de2c3cc928@gmail.com
>
> Changes in v6:
> - Change the compatible to the fallback
> - Implement .device_prep_dma_cyclic for Loongson1 sound driver,
> - as well as .device_pause and .device_resume.
> - Set the limitation LS1X_DMA_MAX_DESC and put all descriptors
> - into one page to save memory
> - Move dma_pool_zalloc() into ls1x_dma_alloc_desc()
> - Drop dma_slave_config structure
> - Use .remove_new instead of .remove
> - Use KBUILD_MODNAME for the driver name
> - Improve the debug information
> - Some minor fixes
>
> Changes in v5:
> - Add the dt-binding document
> - Add DT support
> - Use DT information instead of platform data
> - Use chan_id of struct dma_chan instead of own id
> - Use of_dma_xlate_by_chan_id() instead of ls1x_dma_filter()
> - Update the author information to my official name
>
> Changes in v4:
> - Use dma_slave_map to find the proper channel.
> - Explicitly call devm_request_irq() and tasklet_kill().
> - Fix namespace issue.
> - Some minor fixes and cleanups.
>
> Changes in v3:
> - Rename ls1x_dma_filter_fn to ls1x_dma_filter.
>
> Changes in v2:
> - Change the config from 'DMA_LOONGSON1' to 'LOONGSON1_DMA',
> - and rearrange it in alphabetical order in Kconfig and Makefile.
> - Fix comment style.
>
> ---
> Keguang Zhang (2):
>       dt-bindings: dma: Add Loongson-1 APB DMA
>       dmaengine: Loongson1: Add Loongson-1 APB DMA driver
>
>  .../bindings/dma/loongson,ls1b-apbdma.yaml         |  67 +++
>  drivers/dma/Kconfig                                |   9 +
>  drivers/dma/Makefile                               |   1 +
>  drivers/dma/loongson1-apb-dma.c                    | 665 +++++++++++++++++++++
>  4 files changed, 742 insertions(+)
> ---
> base-commit: d35b2284e966c0bef3e2182a5c5ea02177dd32e4
> change-id: 20231120-loongson1-dma-163afe5708b9
>
> Best regards,
> --
> Keguang Zhang <keguang.zhang@gmail.com>
>
>
>

Re: [PATCH RESEND v9 0/2] Add support for Loongson1 APB DMA

[Keguang Zhang]

On Fri, Jul 12, 2024 at 12:22 PM Huacai Chen <chenhuacai@kernel.org> wrote:
>
> Hi, Keguang,
>
> I accept your suggestion about the cpufreq driver naming, and now it
> is upstream:
> https://git.kernel.org/pub/scm/linux/kernel/git/vireshk/pm.git/commit/?h=cpufreq/arm/linux-next&id=ccf51454145bffd98e31cdbe54a4262473c609e2
>
> I still hope you can accept my suggestion about the dma driver naming.
>
> I know you hope me rename LS2X_APB_DMA to LOONGSON2_APB_DMA, but as I
> said before, renaming an existing Kconfig option will break config
> files.
>
> See an example:
> Commit a50a3f4b6a313dc76912bd4ad3b8b4f4b4 introduce PREEMPT_RT and
> rename PREEMPT to PREEMPT_LL, but then commit
> b8d3349803ba34afda429e87a837fd95a9 rename it back because of config
> files broken.
>
Hi Huacai,
I understand the breaking issue of the Kconfig option, so you can keep
LS2X_APB_DMA.
You said that you've accepted my suggestion, which means you recognize
'loongson' as the better name for the drivers.
Moreover, Loongson1 and Loongson2 belong to different SoC series.
To be honest, I can't see why Loongson1 APB DMA should give up this
intuitive and comprehensible naming.
Thanks for your review!
>
> Huacai
>
> On Thu, Jul 11, 2024 at 6:57 PM Keguang Zhang via B4 Relay
> <devnull+keguang.zhang.gmail.com@kernel.org> wrote:
> >
> > Add the driver and dt-binding document for Loongson1 APB DMA.
> >
> > ---
> > Changes in v9:
> > - Fix all the errors and warnings when building with W=1 and C=1
> > - Link to v8: https://lore.kernel.org/r/20240607-loongson1-dma-v8-0-f9992d257250@gmail.com
> >
> > Changes in v8:
> > - Change 'interrupts' property to an items list
> > - Link to v7: https://lore.kernel.org/r/20240329-loongson1-dma-v7-0-37db58608de5@gmail.com
> >
> > Changes in v7:
> > - Change the comptible to 'loongson,ls1*-apbdma' (suggested by Huacai Chen)
> > - Update the title and description part accordingly
> > - Rename the file to loongson,ls1b-apbdma.yaml
> > - Add a compatible string for LS1A
> > - Delete minItems of 'interrupts'
> > - Change patterns of 'interrupt-names' to const
> > - Rename the file to loongson1-apb-dma.c to keep the consistency
> > - Update Kconfig and Makefile accordingly
> > - Link to v6: https://lore.kernel.org/r/20240316-loongson1-dma-v6-0-90de2c3cc928@gmail.com
> >
> > Changes in v6:
> > - Change the compatible to the fallback
> > - Implement .device_prep_dma_cyclic for Loongson1 sound driver,
> > - as well as .device_pause and .device_resume.
> > - Set the limitation LS1X_DMA_MAX_DESC and put all descriptors
> > - into one page to save memory
> > - Move dma_pool_zalloc() into ls1x_dma_alloc_desc()
> > - Drop dma_slave_config structure
> > - Use .remove_new instead of .remove
> > - Use KBUILD_MODNAME for the driver name
> > - Improve the debug information
> > - Some minor fixes
> >
> > Changes in v5:
> > - Add the dt-binding document
> > - Add DT support
> > - Use DT information instead of platform data
> > - Use chan_id of struct dma_chan instead of own id
> > - Use of_dma_xlate_by_chan_id() instead of ls1x_dma_filter()
> > - Update the author information to my official name
> >
> > Changes in v4:
> > - Use dma_slave_map to find the proper channel.
> > - Explicitly call devm_request_irq() and tasklet_kill().
> > - Fix namespace issue.
> > - Some minor fixes and cleanups.
> >
> > Changes in v3:
> > - Rename ls1x_dma_filter_fn to ls1x_dma_filter.
> >
> > Changes in v2:
> > - Change the config from 'DMA_LOONGSON1' to 'LOONGSON1_DMA',
> > - and rearrange it in alphabetical order in Kconfig and Makefile.
> > - Fix comment style.
> >
> > ---
> > Keguang Zhang (2):
> >       dt-bindings: dma: Add Loongson-1 APB DMA
> >       dmaengine: Loongson1: Add Loongson-1 APB DMA driver
> >
> >  .../bindings/dma/loongson,ls1b-apbdma.yaml         |  67 +++
> >  drivers/dma/Kconfig                                |   9 +
> >  drivers/dma/Makefile                               |   1 +
> >  drivers/dma/loongson1-apb-dma.c                    | 665 +++++++++++++++++++++
> >  4 files changed, 742 insertions(+)
> > ---
> > base-commit: d35b2284e966c0bef3e2182a5c5ea02177dd32e4
> > change-id: 20231120-loongson1-dma-163afe5708b9
> >
> > Best regards,
> > --
> > Keguang Zhang <keguang.zhang@gmail.com>
> >
> >
> >



--
Best regards,

Keguang Zhang

Re: [PATCH RESEND v9 2/2] dmaengine: Loongson1: Add Loongson-1 APB DMA driver

[kernel test robot]

Hi Keguang,

kernel test robot noticed the following build warnings:

[auto build test WARNING on d35b2284e966c0bef3e2182a5c5ea02177dd32e4]

url:    https://github.com/intel-lab-lkp/linux/commits/Keguang-Zhang-via-B4-Relay/dt-bindings-dma-Add-Loongson-1-APB-DMA/20240711-191657
base:   d35b2284e966c0bef3e2182a5c5ea02177dd32e4
patch link:    https://lore.kernel.org/r/20240711-loongson1-dma-v9-2-5ce8b5e85a56%40gmail.com
patch subject: [PATCH RESEND v9 2/2] dmaengine: Loongson1: Add Loongson-1 APB DMA driver
config: i386-allmodconfig (https://download.01.org/0day-ci/archive/20240714/202407140536.iIizeGVy-lkp@intel.com/config)
compiler: gcc-13 (Ubuntu 13.2.0-4ubuntu3) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240714/202407140536.iIizeGVy-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202407140536.iIizeGVy-lkp@intel.com/

All warnings (new ones prefixed by >>):

   In file included from include/linux/printk.h:598,
                    from include/asm-generic/bug.h:22,
                    from arch/x86/include/asm/bug.h:87,
                    from include/linux/bug.h:5,
                    from include/linux/fortify-string.h:6,
                    from include/linux/string.h:374,
                    from include/linux/scatterlist.h:5,
                    from include/linux/dmapool.h:14,
                    from drivers/dma/loongson1-apb-dma.c:8:
   drivers/dma/loongson1-apb-dma.c: In function 'ls1x_dma_start':
>> drivers/dma/loongson1-apb-dma.c:137:34: warning: format '%x' expects argument of type 'unsigned int', but argument 5 has type 'dma_addr_t' {aka 'long long unsigned int'} [-Wformat=]
     137 |         dev_dbg(chan2dev(dchan), "cookie=%d, starting hwdesc=%x\n",
         |                                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/dynamic_debug.h:224:29: note: in definition of macro '__dynamic_func_call_cls'
     224 |                 func(&id, ##__VA_ARGS__);                       \
         |                             ^~~~~~~~~~~
   include/linux/dynamic_debug.h:250:9: note: in expansion of macro '_dynamic_func_call_cls'
     250 |         _dynamic_func_call_cls(_DPRINTK_CLASS_DFLT, fmt, func, ##__VA_ARGS__)
         |         ^~~~~~~~~~~~~~~~~~~~~~
   include/linux/dynamic_debug.h:273:9: note: in expansion of macro '_dynamic_func_call'
     273 |         _dynamic_func_call(fmt, __dynamic_dev_dbg,              \
         |         ^~~~~~~~~~~~~~~~~~
   include/linux/dev_printk.h:165:9: note: in expansion of macro 'dynamic_dev_dbg'
     165 |         dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
         |         ^~~~~~~~~~~~~~~
   include/linux/dev_printk.h:165:30: note: in expansion of macro 'dev_fmt'
     165 |         dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
         |                              ^~~~~~~
   drivers/dma/loongson1-apb-dma.c:137:9: note: in expansion of macro 'dev_dbg'
     137 |         dev_dbg(chan2dev(dchan), "cookie=%d, starting hwdesc=%x\n",
         |         ^~~~~~~
   drivers/dma/loongson1-apb-dma.c:137:63: note: format string is defined here
     137 |         dev_dbg(chan2dev(dchan), "cookie=%d, starting hwdesc=%x\n",
         |                                                              ~^
         |                                                               |
         |                                                               unsigned int
         |                                                              %llx


vim +137 drivers/dma/loongson1-apb-dma.c

   130	
   131	static inline int ls1x_dma_start(struct ls1x_dma_chan *chan,
   132					 dma_addr_t *hwdesc_phys)
   133	{
   134		struct dma_chan *dchan = &chan->vchan.chan;
   135		int val, ret;
   136	
 > 137		dev_dbg(chan2dev(dchan), "cookie=%d, starting hwdesc=%x\n",
   138			dchan->cookie, *hwdesc_phys);
   139	
   140		val = *hwdesc_phys & DMA_ADDR_MASK;
   141		val |= DMA_START;
   142		val |= dchan->chan_id;
   143		chan_writel(chan, DMA_CTRL, val);
   144		ret = readl_poll_timeout(chan->reg_base + DMA_CTRL, val,
   145					 !(val & DMA_START), 0, 3000);
   146		if (ret)
   147			dev_err(chan2dev(dchan), "failed to start DMA\n");
   148	
   149		return ret;
   150	}
   151	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

Re: [PATCH RESEND v9 2/2] dmaengine: Loongson1: Add Loongson-1 APB DMA driver

[kernel test robot]

Hi Keguang,

kernel test robot noticed the following build warnings:

[auto build test WARNING on d35b2284e966c0bef3e2182a5c5ea02177dd32e4]

url:    https://github.com/intel-lab-lkp/linux/commits/Keguang-Zhang-via-B4-Relay/dt-bindings-dma-Add-Loongson-1-APB-DMA/20240711-191657
base:   d35b2284e966c0bef3e2182a5c5ea02177dd32e4
patch link:    https://lore.kernel.org/r/20240711-loongson1-dma-v9-2-5ce8b5e85a56%40gmail.com
patch subject: [PATCH RESEND v9 2/2] dmaengine: Loongson1: Add Loongson-1 APB DMA driver
config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20240714/202407140701.jQbPNAYb-lkp@intel.com/config)
compiler: clang version 18.1.5 (https://github.com/llvm/llvm-project 617a15a9eac96088ae5e9134248d8236e34b91b1)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240714/202407140701.jQbPNAYb-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202407140701.jQbPNAYb-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/dma/loongson1-apb-dma.c:138:18: warning: format specifies type 'unsigned int' but the argument has type 'dma_addr_t' (aka 'unsigned long long') [-Wformat]
     137 |         dev_dbg(chan2dev(dchan), "cookie=%d, starting hwdesc=%x\n",
         |                                                              ~~
         |                                                              %llx
     138 |                 dchan->cookie, *hwdesc_phys);
         |                                ^~~~~~~~~~~~
   include/linux/dev_printk.h:165:39: note: expanded from macro 'dev_dbg'
     165 |         dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
         |                                      ~~~     ^~~~~~~~~~~
   include/linux/dynamic_debug.h:274:19: note: expanded from macro 'dynamic_dev_dbg'
     274 |                            dev, fmt, ##__VA_ARGS__)
         |                                 ~~~    ^~~~~~~~~~~
   include/linux/dynamic_debug.h:250:59: note: expanded from macro '_dynamic_func_call'
     250 |         _dynamic_func_call_cls(_DPRINTK_CLASS_DFLT, fmt, func, ##__VA_ARGS__)
         |                                                                  ^~~~~~~~~~~
   include/linux/dynamic_debug.h:248:65: note: expanded from macro '_dynamic_func_call_cls'
     248 |         __dynamic_func_call_cls(__UNIQUE_ID(ddebug), cls, fmt, func, ##__VA_ARGS__)
         |                                                                        ^~~~~~~~~~~
   include/linux/dynamic_debug.h:224:15: note: expanded from macro '__dynamic_func_call_cls'
     224 |                 func(&id, ##__VA_ARGS__);                       \
         |                             ^~~~~~~~~~~
>> drivers/dma/loongson1-apb-dma.c:338:53: warning: format specifies type 'int' but the argument has type 'size_t' (aka 'unsigned long') [-Wformat]
     338 |                 "buf_len=%d period_len=%zu flags=0x%lx dir=%s\n", buf_len,
         |                          ~~                                       ^~~~~~~
         |                          %zu
   include/linux/dev_printk.h:165:39: note: expanded from macro 'dev_dbg'
     165 |         dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
         |                                      ~~~     ^~~~~~~~~~~
   include/linux/dynamic_debug.h:274:19: note: expanded from macro 'dynamic_dev_dbg'
     274 |                            dev, fmt, ##__VA_ARGS__)
         |                                 ~~~    ^~~~~~~~~~~
   include/linux/dynamic_debug.h:250:59: note: expanded from macro '_dynamic_func_call'
     250 |         _dynamic_func_call_cls(_DPRINTK_CLASS_DFLT, fmt, func, ##__VA_ARGS__)
         |                                                                  ^~~~~~~~~~~
   include/linux/dynamic_debug.h:248:65: note: expanded from macro '_dynamic_func_call_cls'
     248 |         __dynamic_func_call_cls(__UNIQUE_ID(ddebug), cls, fmt, func, ##__VA_ARGS__)
         |                                                                        ^~~~~~~~~~~
   include/linux/dynamic_debug.h:224:15: note: expanded from macro '__dynamic_func_call_cls'
     224 |                 func(&id, ##__VA_ARGS__);                       \
         |                             ^~~~~~~~~~~
   2 warnings generated.


vim +138 drivers/dma/loongson1-apb-dma.c

   130	
   131	static inline int ls1x_dma_start(struct ls1x_dma_chan *chan,
   132					 dma_addr_t *hwdesc_phys)
   133	{
   134		struct dma_chan *dchan = &chan->vchan.chan;
   135		int val, ret;
   136	
   137		dev_dbg(chan2dev(dchan), "cookie=%d, starting hwdesc=%x\n",
 > 138			dchan->cookie, *hwdesc_phys);
   139	
   140		val = *hwdesc_phys & DMA_ADDR_MASK;
   141		val |= DMA_START;
   142		val |= dchan->chan_id;
   143		chan_writel(chan, DMA_CTRL, val);
   144		ret = readl_poll_timeout(chan->reg_base + DMA_CTRL, val,
   145					 !(val & DMA_START), 0, 3000);
   146		if (ret)
   147			dev_err(chan2dev(dchan), "failed to start DMA\n");
   148	
   149		return ret;
   150	}
   151	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

Re: [PATCH RESEND v9 0/2] Add support for Loongson1 APB DMA

[Huacai Chen]

On Fri, Jul 12, 2024 at 2:23 PM Keguang Zhang <keguang.zhang@gmail.com> wrote:
>
> On Fri, Jul 12, 2024 at 12:22 PM Huacai Chen <chenhuacai@kernel.org> wrote:
> >
> > Hi, Keguang,
> >
> > I accept your suggestion about the cpufreq driver naming, and now it
> > is upstream:
> > https://git.kernel.org/pub/scm/linux/kernel/git/vireshk/pm.git/commit/?h=cpufreq/arm/linux-next&id=ccf51454145bffd98e31cdbe54a4262473c609e2
> >
> > I still hope you can accept my suggestion about the dma driver naming.
> >
> > I know you hope me rename LS2X_APB_DMA to LOONGSON2_APB_DMA, but as I
> > said before, renaming an existing Kconfig option will break config
> > files.
> >
> > See an example:
> > Commit a50a3f4b6a313dc76912bd4ad3b8b4f4b4 introduce PREEMPT_RT and
> > rename PREEMPT to PREEMPT_LL, but then commit
> > b8d3349803ba34afda429e87a837fd95a9 rename it back because of config
> > files broken.
> >
> Hi Huacai,
> I understand the breaking issue of the Kconfig option, so you can keep
> LS2X_APB_DMA.
LS2X_APB_DMA with loongson2-apb-dma.c? Even if I accept this, can you
accept LS1X_APB_DMA with loongson1-apb-dma.c?

> You said that you've accepted my suggestion, which means you recognize
> 'loongson' as the better name for the drivers.
No, I don't think so, this is just a compromise to keep consistency.



Huacai

> Moreover, Loongson1 and Loongson2 belong to different SoC series.
> To be honest, I can't see why Loongson1 APB DMA should give up this
> intuitive and comprehensible naming.
> Thanks for your review!
> >
> > Huacai
> >
> > On Thu, Jul 11, 2024 at 6:57 PM Keguang Zhang via B4 Relay
> > <devnull+keguang.zhang.gmail.com@kernel.org> wrote:
> > >
> > > Add the driver and dt-binding document for Loongson1 APB DMA.
> > >
> > > ---
> > > Changes in v9:
> > > - Fix all the errors and warnings when building with W=1 and C=1
> > > - Link to v8: https://lore.kernel.org/r/20240607-loongson1-dma-v8-0-f9992d257250@gmail.com
> > >
> > > Changes in v8:
> > > - Change 'interrupts' property to an items list
> > > - Link to v7: https://lore.kernel.org/r/20240329-loongson1-dma-v7-0-37db58608de5@gmail.com
> > >
> > > Changes in v7:
> > > - Change the comptible to 'loongson,ls1*-apbdma' (suggested by Huacai Chen)
> > > - Update the title and description part accordingly
> > > - Rename the file to loongson,ls1b-apbdma.yaml
> > > - Add a compatible string for LS1A
> > > - Delete minItems of 'interrupts'
> > > - Change patterns of 'interrupt-names' to const
> > > - Rename the file to loongson1-apb-dma.c to keep the consistency
> > > - Update Kconfig and Makefile accordingly
> > > - Link to v6: https://lore.kernel.org/r/20240316-loongson1-dma-v6-0-90de2c3cc928@gmail.com
> > >
> > > Changes in v6:
> > > - Change the compatible to the fallback
> > > - Implement .device_prep_dma_cyclic for Loongson1 sound driver,
> > > - as well as .device_pause and .device_resume.
> > > - Set the limitation LS1X_DMA_MAX_DESC and put all descriptors
> > > - into one page to save memory
> > > - Move dma_pool_zalloc() into ls1x_dma_alloc_desc()
> > > - Drop dma_slave_config structure
> > > - Use .remove_new instead of .remove
> > > - Use KBUILD_MODNAME for the driver name
> > > - Improve the debug information
> > > - Some minor fixes
> > >
> > > Changes in v5:
> > > - Add the dt-binding document
> > > - Add DT support
> > > - Use DT information instead of platform data
> > > - Use chan_id of struct dma_chan instead of own id
> > > - Use of_dma_xlate_by_chan_id() instead of ls1x_dma_filter()
> > > - Update the author information to my official name
> > >
> > > Changes in v4:
> > > - Use dma_slave_map to find the proper channel.
> > > - Explicitly call devm_request_irq() and tasklet_kill().
> > > - Fix namespace issue.
> > > - Some minor fixes and cleanups.
> > >
> > > Changes in v3:
> > > - Rename ls1x_dma_filter_fn to ls1x_dma_filter.
> > >
> > > Changes in v2:
> > > - Change the config from 'DMA_LOONGSON1' to 'LOONGSON1_DMA',
> > > - and rearrange it in alphabetical order in Kconfig and Makefile.
> > > - Fix comment style.
> > >
> > > ---
> > > Keguang Zhang (2):
> > >       dt-bindings: dma: Add Loongson-1 APB DMA
> > >       dmaengine: Loongson1: Add Loongson-1 APB DMA driver
> > >
> > >  .../bindings/dma/loongson,ls1b-apbdma.yaml         |  67 +++
> > >  drivers/dma/Kconfig                                |   9 +
> > >  drivers/dma/Makefile                               |   1 +
> > >  drivers/dma/loongson1-apb-dma.c                    | 665 +++++++++++++++++++++
> > >  4 files changed, 742 insertions(+)
> > > ---
> > > base-commit: d35b2284e966c0bef3e2182a5c5ea02177dd32e4
> > > change-id: 20231120-loongson1-dma-163afe5708b9
> > >
> > > Best regards,
> > > --
> > > Keguang Zhang <keguang.zhang@gmail.com>
> > >
> > >
> > >
>
>
>
> --
> Best regards,
>
> Keguang Zhang

Re: [PATCH RESEND v9 0/2] Add support for Loongson1 APB DMA

[Keguang Zhang]

On Mon, Jul 15, 2024 at 2:39 PM Huacai Chen <chenhuacai@kernel.org> wrote:
>
> On Fri, Jul 12, 2024 at 2:23 PM Keguang Zhang <keguang.zhang@gmail.com> wrote:
> >
> > On Fri, Jul 12, 2024 at 12:22 PM Huacai Chen <chenhuacai@kernel.org> wrote:
> > >
> > > Hi, Keguang,
> > >
> > > I accept your suggestion about the cpufreq driver naming, and now it
> > > is upstream:
> > > https://git.kernel.org/pub/scm/linux/kernel/git/vireshk/pm.git/commit/?h=cpufreq/arm/linux-next&id=ccf51454145bffd98e31cdbe54a4262473c609e2
> > >
> > > I still hope you can accept my suggestion about the dma driver naming.
> > >
> > > I know you hope me rename LS2X_APB_DMA to LOONGSON2_APB_DMA, but as I
> > > said before, renaming an existing Kconfig option will break config
> > > files.
> > >
> > > See an example:
> > > Commit a50a3f4b6a313dc76912bd4ad3b8b4f4b4 introduce PREEMPT_RT and
> > > rename PREEMPT to PREEMPT_LL, but then commit
> > > b8d3349803ba34afda429e87a837fd95a9 rename it back because of config
> > > files broken.
> > >
> > Hi Huacai,
> > I understand the breaking issue of the Kconfig option, so you can keep
> > LS2X_APB_DMA.
> LS2X_APB_DMA with loongson2-apb-dma.c? Even if I accept this, can you
> accept LS1X_APB_DMA with loongson1-apb-dma.c?
>
> > You said that you've accepted my suggestion, which means you recognize
> > 'loongson' as the better name for the drivers.
> No, I don't think so, this is just a compromise to keep consistency.
>
Sorry. The naming 'Loongson1' is the real consistency that I need to maintain.
Thanks!
>
>
> Huacai
>
> > Moreover, Loongson1 and Loongson2 belong to different SoC series.
> > To be honest, I can't see why Loongson1 APB DMA should give up this
> > intuitive and comprehensible naming.
> > Thanks for your review!
> > >
> > > Huacai
> > >
> > > On Thu, Jul 11, 2024 at 6:57 PM Keguang Zhang via B4 Relay
> > > <devnull+keguang.zhang.gmail.com@kernel.org> wrote:
> > > >
> > > > Add the driver and dt-binding document for Loongson1 APB DMA.
> > > >
> > > > ---
> > > > Changes in v9:
> > > > - Fix all the errors and warnings when building with W=1 and C=1
> > > > - Link to v8: https://lore.kernel.org/r/20240607-loongson1-dma-v8-0-f9992d257250@gmail.com
> > > >
> > > > Changes in v8:
> > > > - Change 'interrupts' property to an items list
> > > > - Link to v7: https://lore.kernel.org/r/20240329-loongson1-dma-v7-0-37db58608de5@gmail.com
> > > >
> > > > Changes in v7:
> > > > - Change the comptible to 'loongson,ls1*-apbdma' (suggested by Huacai Chen)
> > > > - Update the title and description part accordingly
> > > > - Rename the file to loongson,ls1b-apbdma.yaml
> > > > - Add a compatible string for LS1A
> > > > - Delete minItems of 'interrupts'
> > > > - Change patterns of 'interrupt-names' to const
> > > > - Rename the file to loongson1-apb-dma.c to keep the consistency
> > > > - Update Kconfig and Makefile accordingly
> > > > - Link to v6: https://lore.kernel.org/r/20240316-loongson1-dma-v6-0-90de2c3cc928@gmail.com
> > > >
> > > > Changes in v6:
> > > > - Change the compatible to the fallback
> > > > - Implement .device_prep_dma_cyclic for Loongson1 sound driver,
> > > > - as well as .device_pause and .device_resume.
> > > > - Set the limitation LS1X_DMA_MAX_DESC and put all descriptors
> > > > - into one page to save memory
> > > > - Move dma_pool_zalloc() into ls1x_dma_alloc_desc()
> > > > - Drop dma_slave_config structure
> > > > - Use .remove_new instead of .remove
> > > > - Use KBUILD_MODNAME for the driver name
> > > > - Improve the debug information
> > > > - Some minor fixes
> > > >
> > > > Changes in v5:
> > > > - Add the dt-binding document
> > > > - Add DT support
> > > > - Use DT information instead of platform data
> > > > - Use chan_id of struct dma_chan instead of own id
> > > > - Use of_dma_xlate_by_chan_id() instead of ls1x_dma_filter()
> > > > - Update the author information to my official name
> > > >
> > > > Changes in v4:
> > > > - Use dma_slave_map to find the proper channel.
> > > > - Explicitly call devm_request_irq() and tasklet_kill().
> > > > - Fix namespace issue.
> > > > - Some minor fixes and cleanups.
> > > >
> > > > Changes in v3:
> > > > - Rename ls1x_dma_filter_fn to ls1x_dma_filter.
> > > >
> > > > Changes in v2:
> > > > - Change the config from 'DMA_LOONGSON1' to 'LOONGSON1_DMA',
> > > > - and rearrange it in alphabetical order in Kconfig and Makefile.
> > > > - Fix comment style.
> > > >
> > > > ---
> > > > Keguang Zhang (2):
> > > >       dt-bindings: dma: Add Loongson-1 APB DMA
> > > >       dmaengine: Loongson1: Add Loongson-1 APB DMA driver
> > > >
> > > >  .../bindings/dma/loongson,ls1b-apbdma.yaml         |  67 +++
> > > >  drivers/dma/Kconfig                                |   9 +
> > > >  drivers/dma/Makefile                               |   1 +
> > > >  drivers/dma/loongson1-apb-dma.c                    | 665 +++++++++++++++++++++
> > > >  4 files changed, 742 insertions(+)
> > > > ---
> > > > base-commit: d35b2284e966c0bef3e2182a5c5ea02177dd32e4
> > > > change-id: 20231120-loongson1-dma-163afe5708b9
> > > >
> > > > Best regards,
> > > > --
> > > > Keguang Zhang <keguang.zhang@gmail.com>
> > > >
> > > >
> > > >
> >
> >
> >
> > --
> > Best regards,
> >
> > Keguang Zhang



-- 
Best regards,

Keguang Zhang

Re: [PATCH RESEND v9 0/2] Add support for Loongson1 APB DMA

[Jiaxun Yang]

在2024年7月15日七月 下午2:39，Huacai Chen写道：
[...]
>
>> You said that you've accepted my suggestion, which means you recognize
>> 'loongson' as the better name for the drivers.
> No, I don't think so, this is just a compromise to keep consistency.

Folks, can we settle on this topic?

Is this naming really important? As long as people can read actual chip name from
kernel code & documents, I think both are acceptable.

I suggest let this patch go as is. And if anyone want to unify the naming, they can
propose a treewide patch.

Otherwise, we are going nowhere.

Thanks
-  Jiaxun

>
>
>
> Huacai
>
>> Moreover, Loongson1 and Loongson2 belong to different SoC series.
>> To be honest, I can't see why Loongson1 APB DMA should give up this
>> intuitive and comprehensible naming.
>> Thanks for your review!
>> >
>> > Huacai
>> >
>> > On Thu, Jul 11, 2024 at 6:57 PM Keguang Zhang via B4 Relay
>> > <devnull+keguang.zhang.gmail.com@kernel.org> wrote:
>> > >
>> > > Add the driver and dt-binding document for Loongson1 APB DMA.
>> > >
>> > > ---
>> > > Changes in v9:
>> > > - Fix all the errors and warnings when building with W=1 and C=1
>> > > - Link to v8: https://lore.kernel.org/r/20240607-loongson1-dma-v8-0-f9992d257250@gmail.com
>> > >
>> > > Changes in v8:
>> > > - Change 'interrupts' property to an items list
>> > > - Link to v7: https://lore.kernel.org/r/20240329-loongson1-dma-v7-0-37db58608de5@gmail.com
>> > >
>> > > Changes in v7:
>> > > - Change the comptible to 'loongson,ls1*-apbdma' (suggested by Huacai Chen)
>> > > - Update the title and description part accordingly
>> > > - Rename the file to loongson,ls1b-apbdma.yaml
>> > > - Add a compatible string for LS1A
>> > > - Delete minItems of 'interrupts'
>> > > - Change patterns of 'interrupt-names' to const
>> > > - Rename the file to loongson1-apb-dma.c to keep the consistency
>> > > - Update Kconfig and Makefile accordingly
>> > > - Link to v6: https://lore.kernel.org/r/20240316-loongson1-dma-v6-0-90de2c3cc928@gmail.com
>> > >
>> > > Changes in v6:
>> > > - Change the compatible to the fallback
>> > > - Implement .device_prep_dma_cyclic for Loongson1 sound driver,
>> > > - as well as .device_pause and .device_resume.
>> > > - Set the limitation LS1X_DMA_MAX_DESC and put all descriptors
>> > > - into one page to save memory
>> > > - Move dma_pool_zalloc() into ls1x_dma_alloc_desc()
>> > > - Drop dma_slave_config structure
>> > > - Use .remove_new instead of .remove
>> > > - Use KBUILD_MODNAME for the driver name
>> > > - Improve the debug information
>> > > - Some minor fixes
>> > >
>> > > Changes in v5:
>> > > - Add the dt-binding document
>> > > - Add DT support
>> > > - Use DT information instead of platform data
>> > > - Use chan_id of struct dma_chan instead of own id
>> > > - Use of_dma_xlate_by_chan_id() instead of ls1x_dma_filter()
>> > > - Update the author information to my official name
>> > >
>> > > Changes in v4:
>> > > - Use dma_slave_map to find the proper channel.
>> > > - Explicitly call devm_request_irq() and tasklet_kill().
>> > > - Fix namespace issue.
>> > > - Some minor fixes and cleanups.
>> > >
>> > > Changes in v3:
>> > > - Rename ls1x_dma_filter_fn to ls1x_dma_filter.
>> > >
>> > > Changes in v2:
>> > > - Change the config from 'DMA_LOONGSON1' to 'LOONGSON1_DMA',
>> > > - and rearrange it in alphabetical order in Kconfig and Makefile.
>> > > - Fix comment style.
>> > >
>> > > ---
>> > > Keguang Zhang (2):
>> > >       dt-bindings: dma: Add Loongson-1 APB DMA
>> > >       dmaengine: Loongson1: Add Loongson-1 APB DMA driver
>> > >
>> > >  .../bindings/dma/loongson,ls1b-apbdma.yaml         |  67 +++
>> > >  drivers/dma/Kconfig                                |   9 +
>> > >  drivers/dma/Makefile                               |   1 +
>> > >  drivers/dma/loongson1-apb-dma.c                    | 665 +++++++++++++++++++++
>> > >  4 files changed, 742 insertions(+)
>> > > ---
>> > > base-commit: d35b2284e966c0bef3e2182a5c5ea02177dd32e4
>> > > change-id: 20231120-loongson1-dma-163afe5708b9
>> > >
>> > > Best regards,
>> > > --
>> > > Keguang Zhang <keguang.zhang@gmail.com>
>> > >
>> > >
>> > >
>>
>>
>>
>> --
>> Best regards,
>>
>> Keguang Zhang

-- 
- Jiaxun

Re: [PATCH RESEND v9 0/2] Add support for Loongson1 APB DMA

[Huacai Chen]

On Mon, Jul 15, 2024 at 3:00 PM Jiaxun Yang <jiaxun.yang@flygoat.com> wrote:
>
>
>
> 在2024年7月15日七月 下午2:39，Huacai Chen写道：
> [...]
> >
> >> You said that you've accepted my suggestion, which means you recognize
> >> 'loongson' as the better name for the drivers.
> > No, I don't think so, this is just a compromise to keep consistency.
>
> Folks, can we settle on this topic?
>
> Is this naming really important? As long as people can read actual chip name from
> kernel code & documents, I think both are acceptable.
>
> I suggest let this patch go as is. And if anyone want to unify the naming, they can
> propose a treewide patch.
Renaming still breaks config files.

Huacai

>
> Otherwise, we are going nowhere.
>
> Thanks
> -  Jiaxun
>
> >
> >
> >
> > Huacai
> >
> >> Moreover, Loongson1 and Loongson2 belong to different SoC series.
> >> To be honest, I can't see why Loongson1 APB DMA should give up this
> >> intuitive and comprehensible naming.
> >> Thanks for your review!
> >> >
> >> > Huacai
> >> >
> >> > On Thu, Jul 11, 2024 at 6:57 PM Keguang Zhang via B4 Relay
> >> > <devnull+keguang.zhang.gmail.com@kernel.org> wrote:
> >> > >
> >> > > Add the driver and dt-binding document for Loongson1 APB DMA.
> >> > >
> >> > > ---
> >> > > Changes in v9:
> >> > > - Fix all the errors and warnings when building with W=1 and C=1
> >> > > - Link to v8: https://lore.kernel.org/r/20240607-loongson1-dma-v8-0-f9992d257250@gmail.com
> >> > >
> >> > > Changes in v8:
> >> > > - Change 'interrupts' property to an items list
> >> > > - Link to v7: https://lore.kernel.org/r/20240329-loongson1-dma-v7-0-37db58608de5@gmail.com
> >> > >
> >> > > Changes in v7:
> >> > > - Change the comptible to 'loongson,ls1*-apbdma' (suggested by Huacai Chen)
> >> > > - Update the title and description part accordingly
> >> > > - Rename the file to loongson,ls1b-apbdma.yaml
> >> > > - Add a compatible string for LS1A
> >> > > - Delete minItems of 'interrupts'
> >> > > - Change patterns of 'interrupt-names' to const
> >> > > - Rename the file to loongson1-apb-dma.c to keep the consistency
> >> > > - Update Kconfig and Makefile accordingly
> >> > > - Link to v6: https://lore.kernel.org/r/20240316-loongson1-dma-v6-0-90de2c3cc928@gmail.com
> >> > >
> >> > > Changes in v6:
> >> > > - Change the compatible to the fallback
> >> > > - Implement .device_prep_dma_cyclic for Loongson1 sound driver,
> >> > > - as well as .device_pause and .device_resume.
> >> > > - Set the limitation LS1X_DMA_MAX_DESC and put all descriptors
> >> > > - into one page to save memory
> >> > > - Move dma_pool_zalloc() into ls1x_dma_alloc_desc()
> >> > > - Drop dma_slave_config structure
> >> > > - Use .remove_new instead of .remove
> >> > > - Use KBUILD_MODNAME for the driver name
> >> > > - Improve the debug information
> >> > > - Some minor fixes
> >> > >
> >> > > Changes in v5:
> >> > > - Add the dt-binding document
> >> > > - Add DT support
> >> > > - Use DT information instead of platform data
> >> > > - Use chan_id of struct dma_chan instead of own id
> >> > > - Use of_dma_xlate_by_chan_id() instead of ls1x_dma_filter()
> >> > > - Update the author information to my official name
> >> > >
> >> > > Changes in v4:
> >> > > - Use dma_slave_map to find the proper channel.
> >> > > - Explicitly call devm_request_irq() and tasklet_kill().
> >> > > - Fix namespace issue.
> >> > > - Some minor fixes and cleanups.
> >> > >
> >> > > Changes in v3:
> >> > > - Rename ls1x_dma_filter_fn to ls1x_dma_filter.
> >> > >
> >> > > Changes in v2:
> >> > > - Change the config from 'DMA_LOONGSON1' to 'LOONGSON1_DMA',
> >> > > - and rearrange it in alphabetical order in Kconfig and Makefile.
> >> > > - Fix comment style.
> >> > >
> >> > > ---
> >> > > Keguang Zhang (2):
> >> > >       dt-bindings: dma: Add Loongson-1 APB DMA
> >> > >       dmaengine: Loongson1: Add Loongson-1 APB DMA driver
> >> > >
> >> > >  .../bindings/dma/loongson,ls1b-apbdma.yaml         |  67 +++
> >> > >  drivers/dma/Kconfig                                |   9 +
> >> > >  drivers/dma/Makefile                               |   1 +
> >> > >  drivers/dma/loongson1-apb-dma.c                    | 665 +++++++++++++++++++++
> >> > >  4 files changed, 742 insertions(+)
> >> > > ---
> >> > > base-commit: d35b2284e966c0bef3e2182a5c5ea02177dd32e4
> >> > > change-id: 20231120-loongson1-dma-163afe5708b9
> >> > >
> >> > > Best regards,
> >> > > --
> >> > > Keguang Zhang <keguang.zhang@gmail.com>
> >> > >
> >> > >
> >> > >
> >>
> >>
> >>
> >> --
> >> Best regards,
> >>
> >> Keguang Zhang
>
> --
> - Jiaxun

Re: [PATCH RESEND v9 0/2] Add support for Loongson1 APB DMA

[Jiaxun Yang]

在2024年7月16日七月 下午5:40，Huacai Chen写道：
> On Mon, Jul 15, 2024 at 3:00 PM Jiaxun Yang <jiaxun.yang@flygoat.com> wrote:
>>
>>
>>
>> 在2024年7月15日七月 下午2:39，Huacai Chen写道：
>> [...]
>> >
>> >> You said that you've accepted my suggestion, which means you recognize
>> >> 'loongson' as the better name for the drivers.
>> > No, I don't think so, this is just a compromise to keep consistency.
>>
>> Folks, can we settle on this topic?
>>
>> Is this naming really important? As long as people can read actual chip name from
>> kernel code & documents, I think both are acceptable.
>>
>> I suggest let this patch go as is. And if anyone want to unify the naming, they can
>> propose a treewide patch.
> Renaming still breaks config files.

This is trival with treewide sed :-)

Thanks
- Jiaxun

-- 
- Jiaxun

Re: [PATCH RESEND v9 0/2] Add support for Loongson1 APB DMA

[Huacai Chen]

On Tue, Jul 16, 2024 at 9:12 PM Jiaxun Yang <jiaxun.yang@flygoat.com> wrote:
>
>
>
> 在2024年7月16日七月 下午5:40，Huacai Chen写道：
> > On Mon, Jul 15, 2024 at 3:00 PM Jiaxun Yang <jiaxun.yang@flygoat.com> wrote:
> >>
> >>
> >>
> >> 在2024年7月15日七月 下午2:39，Huacai Chen写道：
> >> [...]
> >> >
> >> >> You said that you've accepted my suggestion, which means you recognize
> >> >> 'loongson' as the better name for the drivers.
> >> > No, I don't think so, this is just a compromise to keep consistency.
> >>
> >> Folks, can we settle on this topic?
> >>
> >> Is this naming really important? As long as people can read actual chip name from
> >> kernel code & documents, I think both are acceptable.
> >>
> >> I suggest let this patch go as is. And if anyone want to unify the naming, they can
> >> propose a treewide patch.
> > Renaming still breaks config files.
>
> This is trival with treewide sed :-)
Please read the commit message of b8d3349803ba34afda429e87a837fd95a carefully.

Huacai

>
> Thanks
> - Jiaxun
>
> --
> - Jiaxun

Re: [PATCH RESEND v9 0/2] Add support for Loongson1 APB DMA

[Jiaxun Yang]

在2024年7月17日七月 下午9:06，Huacai Chen写道：
> On Tue, Jul 16, 2024 at 9:12 PM Jiaxun Yang <jiaxun.yang@flygoat.com> wrote:
>>
>>
>>
>> 在2024年7月16日七月 下午5:40，Huacai Chen写道：
>> > On Mon, Jul 15, 2024 at 3:00 PM Jiaxun Yang <jiaxun.yang@flygoat.com> wrote:
>> >>
>> >>
>> >>
>> >> 在2024年7月15日七月 下午2:39，Huacai Chen写道：
>> >> [...]
>> >> >
>> >> >> You said that you've accepted my suggestion, which means you recognize
>> >> >> 'loongson' as the better name for the drivers.
>> >> > No, I don't think so, this is just a compromise to keep consistency.
>> >>
>> >> Folks, can we settle on this topic?
>> >>
>> >> Is this naming really important? As long as people can read actual chip name from
>> >> kernel code & documents, I think both are acceptable.
>> >>
>> >> I suggest let this patch go as is. And if anyone want to unify the naming, they can
>> >> propose a treewide patch.
>> > Renaming still breaks config files.
>>
>> This is trival with treewide sed :-)
> Please read the commit message of b8d3349803ba34afda429e87a837fd95a carefully.

We don't have 114 defconfigs don't we?

Those symbols are not frequently specified by down stream users either.

I think Keguang had tried his best on resolving all reasonable comments.

Naming is a matter of preference after all, I think we should give Keguang some respect
here.

Thanks
- Jiaxun

>
> Huacai
>
>>
>> Thanks
>> - Jiaxun
>>
>> --
>> - Jiaxun

-- 
- Jiaxun

Re: [PATCH RESEND v9 2/2] dmaengine: Loongson1: Add Loongson-1 APB DMA driver

[Vinod Koul]

On 14-07-24, 05:11, kernel test robot wrote:
> Hi Keguang,
> 
> kernel test robot noticed the following build warnings:
> 
> [auto build test WARNING on d35b2284e966c0bef3e2182a5c5ea02177dd32e4]
> 
> url:    https://github.com/intel-lab-lkp/linux/commits/Keguang-Zhang-via-B4-Relay/dt-bindings-dma-Add-Loongson-1-APB-DMA/20240711-191657
> base:   d35b2284e966c0bef3e2182a5c5ea02177dd32e4
> patch link:    https://lore.kernel.org/r/20240711-loongson1-dma-v9-2-5ce8b5e85a56%40gmail.com
> patch subject: [PATCH RESEND v9 2/2] dmaengine: Loongson1: Add Loongson-1 APB DMA driver
> config: i386-allmodconfig (https://download.01.org/0day-ci/archive/20240714/202407140536.iIizeGVy-lkp@intel.com/config)
> compiler: gcc-13 (Ubuntu 13.2.0-4ubuntu3) 13.2.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240714/202407140536.iIizeGVy-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202407140536.iIizeGVy-lkp@intel.com/
> 
> All warnings (new ones prefixed by >>):
> 
>    In file included from include/linux/printk.h:598,
>                     from include/asm-generic/bug.h:22,
>                     from arch/x86/include/asm/bug.h:87,
>                     from include/linux/bug.h:5,
>                     from include/linux/fortify-string.h:6,
>                     from include/linux/string.h:374,
>                     from include/linux/scatterlist.h:5,
>                     from include/linux/dmapool.h:14,
>                     from drivers/dma/loongson1-apb-dma.c:8:
>    drivers/dma/loongson1-apb-dma.c: In function 'ls1x_dma_start':
> >> drivers/dma/loongson1-apb-dma.c:137:34: warning: format '%x' expects argument of type 'unsigned int', but argument 5 has type 'dma_addr_t' {aka 'long long unsigned int'} [-Wformat=]
>      137 |         dev_dbg(chan2dev(dchan), "cookie=%d, starting hwdesc=%x\n",

You should not use %x for dma_addr_t, please see documentation

-- 
~Vinod

Re: [PATCH RESEND v9 2/2] dmaengine: Loongson1: Add Loongson-1 APB DMA driver

[Keguang Zhang]

On Thu, Jul 25, 2024 at 1:57 PM Vinod Koul <vkoul@kernel.org> wrote:
>
> On 14-07-24, 05:11, kernel test robot wrote:
> > Hi Keguang,
> >
> > kernel test robot noticed the following build warnings:
> >
> > [auto build test WARNING on d35b2284e966c0bef3e2182a5c5ea02177dd32e4]
> >
> > url:    https://github.com/intel-lab-lkp/linux/commits/Keguang-Zhang-via-B4-Relay/dt-bindings-dma-Add-Loongson-1-APB-DMA/20240711-191657
> > base:   d35b2284e966c0bef3e2182a5c5ea02177dd32e4
> > patch link:    https://lore.kernel.org/r/20240711-loongson1-dma-v9-2-5ce8b5e85a56%40gmail.com
> > patch subject: [PATCH RESEND v9 2/2] dmaengine: Loongson1: Add Loongson-1 APB DMA driver
> > config: i386-allmodconfig (https://download.01.org/0day-ci/archive/20240714/202407140536.iIizeGVy-lkp@intel.com/config)
> > compiler: gcc-13 (Ubuntu 13.2.0-4ubuntu3) 13.2.0
> > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240714/202407140536.iIizeGVy-lkp@intel.com/reproduce)
> >
> > If you fix the issue in a separate patch/commit (i.e. not just a new version of
> > the same patch/commit), kindly add following tags
> > | Reported-by: kernel test robot <lkp@intel.com>
> > | Closes: https://lore.kernel.org/oe-kbuild-all/202407140536.iIizeGVy-lkp@intel.com/
> >
> > All warnings (new ones prefixed by >>):
> >
> >    In file included from include/linux/printk.h:598,
> >                     from include/asm-generic/bug.h:22,
> >                     from arch/x86/include/asm/bug.h:87,
> >                     from include/linux/bug.h:5,
> >                     from include/linux/fortify-string.h:6,
> >                     from include/linux/string.h:374,
> >                     from include/linux/scatterlist.h:5,
> >                     from include/linux/dmapool.h:14,
> >                     from drivers/dma/loongson1-apb-dma.c:8:
> >    drivers/dma/loongson1-apb-dma.c: In function 'ls1x_dma_start':
> > >> drivers/dma/loongson1-apb-dma.c:137:34: warning: format '%x' expects argument of type 'unsigned int', but argument 5 has type 'dma_addr_t' {aka 'long long unsigned int'} [-Wformat=]
> >      137 |         dev_dbg(chan2dev(dchan), "cookie=%d, starting hwdesc=%x\n",
>
> You should not use %x for dma_addr_t, please see documentation
>
Will fix this in next version.
Thanks!

> --
> ~Vinod



-- 
Best regards,

Keguang Zhang