linux-mips.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Siarhei Volkau <lis8215@gmail.com>
To: Paul Cercueil <paul@crapouillou.net>
Cc: Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>,
	linux-mips@vger.kernel.org, linux-clk@vger.kernel.org
Subject: Re: [PATCH v2 0/1] clk: jz4725b: fix mmc0 clock gating
Date: Fri, 4 Feb 2022 21:22:04 +0300	[thread overview]
Message-ID: <CAKNVLfbeKhcRR1Sc780GU9XvW4ACJRHiy4EHJfsPeqB5Sj9i9A@mail.gmail.com> (raw)
In-Reply-To: <QH1S6R.BMH4KZNDZAOO3@crapouillou.net>

пт, 4 февр. 2022 г. в 14:06, Paul Cercueil <paul@crapouillou.net>:
>
> Hi,
>
> Le ven., févr. 4 2022 at 10:21:40 +0300, Siarhei Volkau
> <lis8215@gmail.com> a écrit :
> Can you confirm that the MMC0 controller will work even with the bit 6
> off?
>
> Do you know if the MMC0 bit has been moved elsewhere, or the MMC0
> controller is permanently enabled?
>
Do you mean when the clock is off (bit == 1) or bit == 0 (the clock is on)?

Anyway what I tried:
I tried not enabling this clock in the UBIBoot - it just works. I guess
boot ROM enables it earlier.
But when I explicitly disable the clock it doesn't boot.
So I assume bit 6 definitely gates the MMC0
clock, as stated in the jz4725b programmer's manual.

Then I disabled MMC0 in Ubiboot to run Linux from MMC1 and tested
the audio with disabled MMC0, in dts mmc0 node was disabled as well.
With this patch applied sound works well. So I guess the bit 6 isn't
related to the I2S clocking at all.

Hope I answered your questions.

BR, Siarhei

  reply	other threads:[~2022-02-04 18:22 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-04  5:26 [PATCH 0/1] clk: jz4725b: fix mmc0 clock gating Siarhei Volkau
2022-02-04  5:26 ` [PATCH 1/1] " Siarhei Volkau
2022-02-04  6:23 ` [PATCH 0/1] " Paul Cercueil
2022-02-04  6:53   ` Siarhei Volkau
2022-02-04  7:21   ` [PATCH v2 " Siarhei Volkau
2022-02-04  7:21     ` [PATCH v2 1/1] " Siarhei Volkau
2022-02-04 11:05     ` [PATCH v2 0/1] " Paul Cercueil
2022-02-04 18:22       ` Siarhei Volkau [this message]
2022-02-04 20:47         ` Paul Cercueil
2022-02-05  9:45           ` [PATCH v3 " Siarhei Volkau
2022-02-05  9:45             ` [PATCH v3 1/1] " Siarhei Volkau
2022-02-05  9:59               ` Greg KH
2022-02-05 12:15                 ` Paul Cercueil
2022-02-05 12:48                   ` Greg KH
2022-02-05 17:18                     ` [PATCH v4 0/1] " Siarhei Volkau
2022-02-05 17:18                       ` [PATCH v4 1/1] " Siarhei Volkau
2022-02-18  1:04                         ` Stephen Boyd

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAKNVLfbeKhcRR1Sc780GU9XvW4ACJRHiy4EHJfsPeqB5Sj9i9A@mail.gmail.com \
    --to=lis8215@gmail.com \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=paul@crapouillou.net \
    --cc=sboyd@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).