From: Nick Desaulniers <ndesaulniers@google.com>
To: David Laight <David.Laight@aculab.com>,
Kees Cook <keescook@chromium.org>
Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Nathan Chancellor <nathan@kernel.org>,
Marc Zyngier <maz@kernel.org>, Guenter Roeck <linux@roeck-us.net>,
Yanteng Si <siyanteng01@gmail.com>,
"linux-mips@vger.kernel.org" <linux-mips@vger.kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"llvm@lists.linux.dev" <llvm@lists.linux.dev>,
"linux-hardening@vger.kernel.org"
<linux-hardening@vger.kernel.org>
Subject: Re: [PATCH v2] MIPS: Only use current_stack_pointer on GCC
Date: Thu, 10 Mar 2022 10:20:51 -0800 [thread overview]
Message-ID: <CAKwvOdkjsNhR8DNRCjEVLibHf0j1WS54m-CSEQpm070h3J7_4g@mail.gmail.com> (raw)
In-Reply-To: <3bb36a2d506a4b73aefec200d1edd40a@AcuMS.aculab.com>
On Wed, Mar 9, 2022 at 2:44 PM David Laight <David.Laight@aculab.com> wrote:
>
> From: Kees Cook
> > Sent: 09 March 2022 22:10
> >
> > Unfortunately, Clang did not have support for "sp" as a global register
> > definition, and was crashing after the addition of current_stack_pointer.
> > This has been fixed in Clang 15, but earlier Clang versions need to
> ^^ 14
Yeah, with that fixed:
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Once clang-14 is the minimally supported version, we can go back to
removing the inline asm for everyone.
> > avoid this code, so add a versioned test and revert back to the
> > open-coded asm instances. Fixes Clang build error:
> >
> > fatal error: error in backend: Invalid register name global variable
>
> David
>
> -
> Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
> Registration No: 1397386 (Wales)
>
--
Thanks,
~Nick Desaulniers
next prev parent reply other threads:[~2022-03-10 18:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-09 22:09 [PATCH v2] MIPS: Only use current_stack_pointer on GCC Kees Cook
2022-03-09 22:44 ` David Laight
2022-03-10 18:20 ` Nick Desaulniers [this message]
2022-03-14 14:52 ` Thomas Bogendoerfer
2022-03-15 18:09 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKwvOdkjsNhR8DNRCjEVLibHf0j1WS54m-CSEQpm070h3J7_4g@mail.gmail.com \
--to=ndesaulniers@google.com \
--cc=David.Laight@aculab.com \
--cc=keescook@chromium.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=llvm@lists.linux.dev \
--cc=mark.rutland@arm.com \
--cc=maz@kernel.org \
--cc=nathan@kernel.org \
--cc=siyanteng01@gmail.com \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).