From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C94EC433EF for ; Fri, 11 Mar 2022 15:03:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347307AbiCKPEE (ORCPT ); Fri, 11 Mar 2022 10:04:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40050 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231562AbiCKPED (ORCPT ); Fri, 11 Mar 2022 10:04:03 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EEE623B549; Fri, 11 Mar 2022 07:02:58 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 3B74EB829A4; Fri, 11 Mar 2022 15:02:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DB2CEC36AE2; Fri, 11 Mar 2022 15:02:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1647010975; bh=+7wVC05d5SSUcDUrc40AC3oA+s+3hd6pHYOwxaDor9A=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=ZUTRP4Cm8LBfn6/KXI+G2bBgllAlpz6Eq78RD0OMglXVTQ4yuwDfAfRMnWzW8M5Vd 3KrDlpIhXq6B76Km1NJUDvXGR8k9vVrnwPrln06V5nYJHXwXAkBj9mnpMfuTkAFZGi xJ1/FN4zB7AWkKStZPMFi4sypEdKiU3bOddHQ3xmJMrhEro9fYPU0UGChwckRItHx4 cQi2UnBtEoBOgE4Kc8+8VMoR4bT9J5cyqZse1G8BLs+8fGDYEF0z9MHE2O0xxdSFa7 cFAHLdFBJwxHih4h+q5sXZaatJL75Z3EHP1AK6xf0RxaCTPFCoBcN7/lkkQtSijQ/e fZiQhWjFduJFQ== Received: by mail-ed1-f46.google.com with SMTP id g3so11288929edu.1; Fri, 11 Mar 2022 07:02:55 -0800 (PST) X-Gm-Message-State: AOAM53396vSBfEiRiUVYSVWGINOmcv4FEcXnuagcLWdvwwLWFiU/I7GK QtMzHDb1g7LQDcA6AVddyDfdFMuzITfAC8SRDQ== X-Google-Smtp-Source: ABdhPJwYq/vJdt94i6eQ/56CKRLPMYZBOz5FJe4G+2giKB68DPNLMZ0O0dRforZvg6kBjeNFI/F6lo5Tb/V20Gngl/A= X-Received: by 2002:aa7:d355:0:b0:415:f703:569 with SMTP id m21-20020aa7d355000000b00415f7030569mr9325992edr.215.1647010974075; Fri, 11 Mar 2022 07:02:54 -0800 (PST) MIME-Version: 1.0 References: <20220308130643.260683-1-cbranchereau@gmail.com> <20220308130643.260683-5-cbranchereau@gmail.com> In-Reply-To: From: Rob Herring Date: Fri, 11 Mar 2022 09:02:42 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 4/4] dt-bindings: display/panel: Add Leadtek ltk035c5444t To: Paul Cercueil Cc: Christophe Branchereau , David Airlie , Daniel Vetter , Thierry Reding , Sam Ravnborg , "linux-kernel@vger.kernel.org" , "open list:MIPS" , dri-devel , devicetree@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org On Fri, Mar 11, 2022 at 7:05 AM Paul Cercueil wrote: > > Hi Rob, > > Le jeu., mars 10 2022 at 16:30:26 -0600, Rob Herring > a =C3=A9crit : > > On Tue, Mar 08, 2022 at 02:06:43PM +0100, Christophe Branchereau > > wrote: > >> Add binding for the leadtek ltk035c5444t, which is a 640x480 > >> mipi-dbi over spi / 24-bit RGB panel based on the newvision > >> NV03052C chipset. > >> > >> It is found in the Anbernic RG350M mips handheld. > >> > >> Signed-off-by: Christophe Branchereau > >> --- > >> .../panel/leadtek,ltk035c5444t-spi.yaml | 59 > >> +++++++++++++++++++ > >> 1 file changed, 59 insertions(+) > >> create mode 100644 > >> Documentation/devicetree/bindings/display/panel/leadtek,ltk035c5444t-s= pi.yaml > > > > We have 18 SPI based panels already: > > > > $ git grep -i 'spi.* {' > > Documentation/devicetree/bindings/display/panel/ > > Documentation/devicetree/bindings/display/panel/abt,y030xx067a.yaml: > > spi { > > Documentation/devicetree/bindings/display/panel/ilitek,ili9163.yaml: > > spi { > > Documentation/devicetree/bindings/display/panel/ilitek,ili9322.yaml: > > spi { > > Documentation/devicetree/bindings/display/panel/ilitek,ili9341.yaml: > > spi { > > Documentation/devicetree/bindings/display/panel/innolux,ej030na.yaml: > > spi { > > Documentation/devicetree/bindings/display/panel/kingdisplay,kd035g6-54n= t.yaml: > > spi { > > Documentation/devicetree/bindings/display/panel/lg,lg4573.yaml: > > spi { > > Documentation/devicetree/bindings/display/panel/lgphilips,lb035q02.yaml= : > > spi { > > Documentation/devicetree/bindings/display/panel/nec,nl8048hl11.yaml: > > spi0 { > > Documentation/devicetree/bindings/display/panel/samsung,ld9040.yaml: > > spi { > > Documentation/devicetree/bindings/display/panel/samsung,lms380kf01.yaml= : > > spi { > > Documentation/devicetree/bindings/display/panel/samsung,lms397kf04.yaml= : > > spi { > > Documentation/devicetree/bindings/display/panel/samsung,s6d27a1.yaml: > > spi { > > Documentation/devicetree/bindings/display/panel/samsung,s6e63m0.yaml: > > spi { > > Documentation/devicetree/bindings/display/panel/sitronix,st7789v.yaml: > > spi { > > Documentation/devicetree/bindings/display/panel/sony,acx565akm.yaml: > > spi { > > Documentation/devicetree/bindings/display/panel/tpo,td.yaml: spi { > > Documentation/devicetree/bindings/display/panel/tpo,tpg110.yaml: > > spi { > > > > Most except for the Samsung ones look like they'd fit in our > > definition > > of 'simple panels' which primarily means 1 supply. > > > > So I think it is time for a panel-simple-spi.yaml binding to combine > > all > > these. But I'm not going to make the person adding the 19th case to do > > that, and this otherwise looks fine: > > > > Reviewed-by: Rob Herring > > I actually thought you sent a patch for this already (I remember you > talking about it last a binding for a new SPI panel has been added). It was just adding spi-peripheral-props.yaml reference that I sent. > I will work on it next week - provided Cristophe's patch has been > merged before. Thanks! Rob