From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2906C433F5 for ; Thu, 28 Oct 2021 09:59:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7E46E610D2 for ; Thu, 28 Oct 2021 09:59:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229906AbhJ1KB7 (ORCPT ); Thu, 28 Oct 2021 06:01:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53692 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229626AbhJ1KB4 (ORCPT ); Thu, 28 Oct 2021 06:01:56 -0400 Received: from mail-ua1-x929.google.com (mail-ua1-x929.google.com [IPv6:2607:f8b0:4864:20::929]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 768FDC061570; Thu, 28 Oct 2021 02:59:29 -0700 (PDT) Received: by mail-ua1-x929.google.com with SMTP id q13so10466161uaq.2; Thu, 28 Oct 2021 02:59:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=HGGQ7RqFpKeC9CxBW+k8kpLsGeNQocDgaLhurL7DcEI=; b=WizV7VgtkLy3fe2e0o1pfzbFecHihzXI0Id4xUaMYbtMTOAMqXIFLdyS9M2duUuMz3 r4sFwt/CYjnK4bgu+1DyEQBwyR7Q70aPYhsqJjPF996z3shUdkBl967YF0ymWY+a448g RTpxrT300XgMMtmHX6u+JD3WXsmClh4yO8nD24YFkfG5hM9kBja7+RxxEAHj7KT+s3in OYXDsbbCrU723hxPx87IcrPx+np95xU3p5LQWXav9tDIgrBgEPuXZ2+tr8maaJwA2H51 q9DJ/uCnkinwqQzQ+hi9u5xE13GOCSClyqmv5hLl+X8gb6qnnZB59b1sNvh6/EGc+1+C oNiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HGGQ7RqFpKeC9CxBW+k8kpLsGeNQocDgaLhurL7DcEI=; b=OFuMP/0IEBFBNKjsTxECz80gpPGkucrPlVbjxnQXvITrVGboH5ZlZYLeu9y1lAj4Gl x3MEaveCScFzIu9QZNlf7v3SwgZ2Wtz9untYK/rkD/jwOG7geiZNPMFSREgL46hWK9tQ N4mGRuNMIJoHdaia8Wno3Cd53rJ058K7YqqsL7ZzsWOyp0DqqzDt7bjIbVL006dOWaXj u4wEn2u7EWfMHcbPlj/NPtO0YI0m96mjXyjUUeLbWtQuV5uvUqkWnFQWYNEnu2fG6bus Yx7TVonPiSmPCIfnG0qOABaJzP+9qMibkRCwBmoVXNbfcImd37EPwHfrO7VWhKjuQWNA BY1Q== X-Gm-Message-State: AOAM531FhFcN0GS1Tgm/ASUMlI4vTuGaEW356E28Tj+mU2+QaZn0SJm+ nnmpoC0zpkxa51kRx31oxJaUF4C9e8GE+k94KLCNqIazttg= X-Google-Smtp-Source: ABdhPJzrE18emHRymB8uKvYxaQU2LsVWX8ihdn4v4ExoK4X3tzhQ0bdB6x4Z47vqjrm3sGQ67yZI4DOVVN9myD89gWE= X-Received: by 2002:ab0:3cab:: with SMTP id a43mr3208667uax.98.1635415168662; Thu, 28 Oct 2021 02:59:28 -0700 (PDT) MIME-Version: 1.0 References: <112fea0c8c1b65a762ac98412216239160721263.1635390750.git.siyanteng@loongson.cn> <20211028092318.GA6574@alpha.franken.de> In-Reply-To: From: Sergio Paracuellos Date: Thu, 28 Oct 2021 11:59:17 +0200 Message-ID: Subject: Re: [PATCH v2 2/3] MIPS: cm/cpc: export some missing symbols to be able to use them from driver code To: Thomas Bogendoerfer Cc: Yanteng Si , Florian Fainelli , bcm-kernel-feedback-list@broadcom.com, Yanteng Si , Stephen Rothwell , Lorenzo Pieralisi , Rob Herring , kw@linux.com, Bjorn Helgaas , Matthias Brugger , Philipp Zabel , linux-pci , linux-arm-kernel@lists.infradead.org, "moderated list:ARM/Mediatek SoC support" , "open list:MIPS" , chenhuacai@kernel.org, sterlingteng@gmail.com, Linux Next Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org On Thu, Oct 28, 2021 at 11:34 AM Sergio Paracuellos wrote: > > Hi Thomas, > > On Thu, Oct 28, 2021 at 11:24 AM Thomas Bogendoerfer > wrote: > > > > On Thu, Oct 28, 2021 at 06:11:18AM +0200, Sergio Paracuellos wrote: > > > On Thu, Oct 28, 2021 at 6:05 AM Yanteng Si wrote: > > > > > > > > Since commit 2bdd5238e756 ("PCI: mt7621: Add MediaTek MT7621 PCIe host controller driver") > > > > the MT7621 PCIe host controller driver is built as a module but modpost complains once these > > > > drivers become modules. > > > > > > > > ERROR: modpost: "mips_cm_unlock_other" [drivers/pci/controller/pcie-mt7621.ko] undefined! > > > > ERROR: modpost: "mips_cpc_base" [drivers/pci/controller/pcie-mt7621.ko] undefined! > > > > ERROR: modpost: "mips_cm_lock_other" [drivers/pci/controller/pcie-mt7621.ko] undefined! > > > > ERROR: modpost: "mips_cm_is64" [drivers/pci/controller/pcie-mt7621.ko] undefined! > > > > ERROR: modpost: "mips_gcr_base" [drivers/pci/controller/pcie-mt7621.ko] undefined! > > > > > > > > Let's just export them. > > > > > > > > Signed-off-by: Yanteng Si > > > > --- > > > > arch/mips/kernel/mips-cm.c | 5 +++++ > > > > arch/mips/kernel/mips-cpc.c | 1 + > > > > 2 files changed, 6 insertions(+) > > > > > > > > > > Reviewed-by: Sergio Paracuellos > > > > could we instead make the pcie-mt761 driver non modular ? Exporting > > all MIPS specific stuff for just making an essential driver modular > > doesn't IMHO make much sense. > > The driver is modular because I have been advised other times that new > drivers should be able to be compiled as modules and we should avoid > using 'bool' in Kconfig for new drivers. That's the only reason. I am > also always including as 'y' the driver since for me not having pci in > my boards has no sense... I am ok in changing Kconfig to be 'bool' > instead of 'tristate', but I don't know what should be the correct > thing to do in this case. Thoughts? I guess we also want the driver to at least be compile tested in 'allmodconfig' and other similars... > > Best regards, > Sergio Paracuellos > > > > > Thomas. > > > > -- > > Crap can work. Given enough thrust pigs will fly, but it's not necessarily a > > good idea. [ RFC1925, 2.3 ]