From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44983C3DA40 for ; Thu, 13 Jul 2023 09:30:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232718AbjGMJaT convert rfc822-to-8bit (ORCPT ); Thu, 13 Jul 2023 05:30:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53196 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232934AbjGMJaR (ORCPT ); Thu, 13 Jul 2023 05:30:17 -0400 Received: from mail-yb1-f175.google.com (mail-yb1-f175.google.com [209.85.219.175]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4332A1BF8; Thu, 13 Jul 2023 02:30:14 -0700 (PDT) Received: by mail-yb1-f175.google.com with SMTP id 3f1490d57ef6-c5ffb6cda23so467685276.0; Thu, 13 Jul 2023 02:30:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689240613; x=1691832613; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LHmbzhpkJKMYjCs3rLqCEOJxasGkKa4brFmr33oqUxc=; b=iC7dU+lR6dMoxz8o95dlF+ZsCUFKiOO2u8jbnyJPd19roy5UZdY3Hvr54NaUYW41Vf HFv4lzGwb1SMWu1dL9u9jl6cFDvX8R9RgltvCK+BMP8mEJm4v7Rm7AmvFXvcbjdV5LFs iQBJjtVIjsNjhKcuLyGaOSJjk5MVmH3vY+1SUVT3idEMOO268fVPMM9AtE1TgaLrHToY F/mTO//J3xbvl321OBH9E4k9Jg4nerR44NM+p/YngQ2OZwqNGKaqha3Ag5HCJ7qzRmnm 4aj+Q7x80NFu2C85tUo671oEmZLl0AAFNnBWFxAl6UbKU9VMeilxT5VT1qs9szZpfQF+ E1+Q== X-Gm-Message-State: ABy/qLa/G3BxW9Bk3s07XDlLwFD5dN9bXpZbtDpZEKAEi+6SYk9dMg9Y 9Bc3NNFlDNb0waogKKhNldia01HwyTfLxV4g X-Google-Smtp-Source: APBJJlGUxcTy72NxctPtsqcjjWbULq+EYO2MbgEA9HOFxvuiUs+Da+uNt4+GB4k9llRbMRynsSOP5g== X-Received: by 2002:a81:6985:0:b0:577:6312:ea5c with SMTP id e127-20020a816985000000b005776312ea5cmr1300566ywc.11.1689240613280; Thu, 13 Jul 2023 02:30:13 -0700 (PDT) Received: from mail-yb1-f176.google.com (mail-yb1-f176.google.com. [209.85.219.176]) by smtp.gmail.com with ESMTPSA id c16-20020a81df10000000b00559fb950d9fsm1648234ywn.45.2023.07.13.02.30.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 13 Jul 2023 02:30:11 -0700 (PDT) Received: by mail-yb1-f176.google.com with SMTP id 3f1490d57ef6-c5e76dfcc36so453178276.2; Thu, 13 Jul 2023 02:30:11 -0700 (PDT) X-Received: by 2002:a0d:ef46:0:b0:56e:1df1:dc58 with SMTP id y67-20020a0def46000000b0056e1df1dc58mr1228415ywe.45.1689240610993; Thu, 13 Jul 2023 02:30:10 -0700 (PDT) MIME-Version: 1.0 References: <20230712094702.1770121-1-u.kleine-koenig@pengutronix.de> <87fs5tgpvv.fsf@intel.com> <20230712161025.22op3gtzgujrhytb@pengutronix.de> <878rbkgp4m.fsf@intel.com> In-Reply-To: <878rbkgp4m.fsf@intel.com> From: Geert Uytterhoeven Date: Thu, 13 Jul 2023 11:29:54 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH RFC v1 00/52] drm/crtc: Rename struct drm_crtc::dev to drm_dev To: Jani Nikula Cc: =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= , Xinliang Liu , Tomi Valkeinen , Alexey Kodanev , dri-devel@lists.freedesktop.org, Vandita Kulkarni , Alim Akhtar , Anitha Chrisanthus , Marijn Suijten , Jonathan Hunter , Arun R Murthy , Jerome Brunet , Liu Shixin , linux-samsung-soc@vger.kernel.org, Samuel Holland , Matt Roper , Wenjing Liu , Javier Martinez Canillas , Stanislav Lisovskiy , Danilo Krummrich , NXP Linux Team , spice-devel@lists.freedesktop.org, Niranjana Vishwanathapura , linux-sunxi@lists.linux.dev, Stylon Wang , Tim Huang , Suraj Kandpal , =?UTF-8?Q?Andr=C3=A9_Almeida?= , Andi Shyti , Yifan Zhang , Leo Li , Sascha Hauer , Lucas De Marchi , Hersen Wu , Jessica Zhang , Kamlesh Gurudasani , Bhawanpreet Lakha , =?UTF-8?Q?=C5=81ukasz_Bartosik?= , Radhakrishna Sripada , Andrew Jeffery , Seung-Woo Kim , =?UTF-8?Q?Noralf_Tr=C3=B8nnes?= , kernel@pengutronix.de, Alex Deucher , freedreno@lists.freedesktop.org, Claudiu Beznea , Gerd Hoffmann , Alexandre Belloni , linux-aspeed@lists.ozlabs.org, nouveau@lists.freedesktop.org, Mitul Golani , =?UTF-8?Q?Jos=C3=A9_Roberto_de_Souza?= , virtualization@lists.linux-foundation.org, Thierry Reding , Yongqin Liu , Mario Limonciello , Fei Yang , David Lechner , Juha-Pekka Heikkila , "Jiri Slaby (SUSE)" , David Francis , Aaron Liu , Vinod Polimera , linux-rockchip@lists.infradead.org, Fangzhi Zuo , Aurabindo Pillai , VMware Graphics Reviewers , Ben Skeggs , =?UTF-8?Q?Jouni_H=C3=B6gander?= , Dave Airlie , linux-mips@vger.kernel.org, Maxime Coquelin , Gurchetan Singh , Martin Blumenstingl , linux-arm-msm@vger.kernel.org, Animesh Manna , linux-renesas-soc@vger.kernel.org, Maxime Ripard , Chaitanya Kumar Borah , Biju Das , linux-amlogic@lists.infradead.org, Evan Quan , Michal Simek , linux-arm-kernel@lists.infradead.org, Sean Paul , Neil Armstrong , Kai Vehmanen , Boris Brezillon , Chunyan Zhang , Qingqing Zhuo , Sandy Huang , Swati Sharma , John Stultz , Paul Kocialkowski , Kyungmin Park , Drew Davenport , Kevin Hilman , Hawking Zhang , Haneen Mohammed , Anusha Srivatsa , Dan Carpenter , Karol Herbst , linux-hyperv@vger.kernel.org, Melissa Wen , =?UTF-8?B?TWHDrXJhIENhbmFs?= , Luca Coelho , Laurent Pinchart , Andrzej Hajda , Likun Gao , Sam Ravnborg , Alain Volmat , Xinwei Kong , Jernej Skrabec , Deepak Rawat , Chen-Yu Tsai , Joel Stanley , Ankit Nautiyal , Sumit Semwal , Alan Liu , Philip Yang , intel-gfx@lists.freedesktop.org, Alison Wang , Wolfram Sang , Abhinav Kumar , Gustavo Sousa , Baolin Wang , Rodrigo Vivi , Mikko Perttunen , Tvrtko Ursulin , Rodrigo Siqueira , Tomi Valkeinen , Deepak R Varma , "Pan, Xinhui" , Konrad Dybcio , Kieran Bingham , Tian Tao , Shawn Guo , =?UTF-8?Q?Christian_K=C3=B6nig?= , Khaled Almahallawy , linux-stm32@st-md-mailman.stormreply.com, Emma Anholt , Chun-Kuang Hu , Liviu Dudau , Alexandre Torgue , Roman Li , Paul Cercueil , Hamza Mahfooz , Marek Vasut , Jiapeng Chong , xen-devel@lists.xenproject.org, Guchun Chen , Oleksandr Andrushchenko , Raphael Gallais-Pou , Rodrigo Siqueira , Russell King , Uma Shankar , Mika Kahola , Jiasheng Jiang , Srinivasan Shanmugam , Thomas Zimmermann , Vinod Govindapillai , linux-tegra@vger.kernel.org, =?UTF-8?B?TWFyZWsgT2zFocOhaw==?= , =?UTF-8?Q?Joaqu=C3=ADn_Ignacio_Aramend=C3=ADa?= , Melissa Wen , Hans de Goede , linux-mediatek@lists.infradead.org, Laurentiu Palcu , Matthias Brugger , David Tadokoro , AngeloGioacchino Del Regno , Orson Zhai , amd-gfx@lists.freedesktop.org, Jyri Sarha , Yannick Fertre , Nicolas Ferre , Krzysztof Kozlowski , Philippe Cornu , Wayne Lin , Dmitry Baryshkov , Nirmoy Das , Lang Yu Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org Hi Jani, On Thu, Jul 13, 2023 at 11:03 AM Jani Nikula wrote: > On Wed, 12 Jul 2023, Uwe Kleine-König wrote: > > On Wed, Jul 12, 2023 at 05:34:28PM +0300, Jani Nikula wrote: > >> On Wed, 12 Jul 2023, Uwe Kleine-König wrote: > >> > while I debugged an issue in the imx-lcdc driver I was constantly > >> > irritated about struct drm_device pointer variables being named "dev" > >> > because with that name I usually expect a struct device pointer. > >> > > >> > I think there is a big benefit when these are all renamed to "drm_dev". > >> > I have no strong preference here though, so "drmdev" or "drm" are fine > >> > for me, too. Let the bikesheding begin! > >> > > >> > Some statistics: > >> > > >> > $ git grep -ohE 'struct drm_device *\* *[^ (),;]*' v6.5-rc1 | sort | uniq -c | sort -n > >> > 1 struct drm_device *adev_to_drm > >> > 1 struct drm_device *drm_ > >> > 1 struct drm_device *drm_dev > >> > 1 struct drm_device *drm_dev > >> > 1 struct drm_device *pdev > >> > 1 struct drm_device *rdev > >> > 1 struct drm_device *vdev > >> > 2 struct drm_device *dcss_drv_dev_to_drm > >> > 2 struct drm_device **ddev > >> > 2 struct drm_device *drm_dev_alloc > >> > 2 struct drm_device *mock > >> > 2 struct drm_device *p_ddev > >> > 5 struct drm_device *device > >> > 9 struct drm_device * dev > >> > 25 struct drm_device *d > >> > 95 struct drm_device * > >> > 216 struct drm_device *ddev > >> > 234 struct drm_device *drm_dev > >> > 611 struct drm_device *drm > >> > 4190 struct drm_device *dev > >> > > >> > This series starts with renaming struct drm_crtc::dev to drm_dev. If > >> > it's not only me and others like the result of this effort it should be > >> > followed up by adapting the other structs and the individual usages in > >> > the different drivers. > >> > >> I think this is an unnecessary change. In drm, a dev is usually a drm > >> device, i.e. struct drm_device *. > > > > Well, unless it's not. Prominently there is > > > > struct drm_device { > > ... > > struct device *dev; > > ... > > }; > > > > which yields quite a few code locations using dev->dev which is > > IMHO unnecessary irritating: > > > > $ git grep '\dev' v6.5-rc1 drivers/gpu/drm | wc -l > > 1633 > > > > Also the functions that deal with both a struct device and a struct > > drm_device often use "dev" for the struct device and then "ddev" for > > the drm_device (see for example amdgpu_device_get_pcie_replay_count()). > > Why is specifically struct drm_device *dev so irritating to you? > > You lead us to believe it's an outlier in kernel, something that goes > against common kernel style, but it's really not: > > $ git grep -how "struct [A-Za-z0-9_]\+ \*dev" | sort | uniq -c | sort -rn | head -20 > 38494 struct device *dev > 16388 struct net_device *dev > 4184 struct drm_device *dev > 2780 struct pci_dev *dev > 1916 struct comedi_device *dev > 1510 struct mlx5_core_dev *dev > 1057 struct mlx4_dev *dev > 894 struct b43_wldev *dev > 762 struct input_dev *dev > 623 struct usbnet *dev > 561 struct mlx5_ib_dev *dev > 525 struct mt76_dev *dev > 465 struct mt76x02_dev *dev > 435 struct platform_device *dev > 431 struct usb_device *dev > 411 struct mt7915_dev *dev > 398 struct cx231xx *dev > 378 struct mei_device *dev > 363 struct ksz_device *dev > 359 struct mthca_dev *dev > > A good portion of the above also have a dev member. Not all of them access both the foo_device and the device pointers. Let's put the number of 435 platform_device pointers named "dev" into perspective: 10095 struct platform_device *pdev Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds