From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [217.70.183.200]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DA9E052F95; Fri, 8 Mar 2024 09:16:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.200 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709889408; cv=none; b=fcxzD3FwMZa4rPev3GTwB8VXPAh4q4vCzwJE86h8VQ9pxg+N8YnaZA5GHyov7KQ9vdCrYofk+U+6yVu6wTKFckKrdtD6grYXcx9+CMfSKvGrrVAZEsiQkqYefLSi2sOf3IwTa95s0HxDQQGl8jG7Nu2C/KdjhLm4lhnvk5kn0sY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709889408; c=relaxed/simple; bh=xbVhZnJdLgAXSnZlSiHw/Fm8YwHdcJLQZLzGDlbumec=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:To:From:Subject: References:In-Reply-To; b=sOkrgOzjKa6ghXeExyM3q/cgWCQrpV+f8jup95Frl7pKjawieMt1vv5Alx0RBy8lBNkICUJyRQ/v1hJ6X313xMBqTJ0TqpLda18O4LYG1FLUBWb8w8sI1QsTAwAUMZvcEmdv27PY5+7jeHw+tSwOPJB9QybTnvU/gLRnQxReCGE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=dIMn+Hks; arc=none smtp.client-ip=217.70.183.200 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="dIMn+Hks" Received: by mail.gandi.net (Postfix) with ESMTPSA id EF36F2000B; Fri, 8 Mar 2024 09:16:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1709889403; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=x/eUvvh3JLX5kacQMX2jRA//mYfxfj755OY+r82KgEE=; b=dIMn+Hks7A6pLjEQgAaTNQSMOrYLL1yAQ7Cq7N9THIxDan38wv2QLOt7iLPwLriXl/bhMA f1obrhB1UvqQwpGDnbA52fSBK56DtwxpVreXh0EGatGiDV/mymaWca1s3Njckz4FY583h4 WpAJRR9/Rsm/Irt/BVEHCl1WcUy7hVMKz3I40Q0OcOQVecXKKvdMrqOwzQuYWAa4g1UTX3 p4r5CLXElTeG2KGd5+fnScBog5l1LkUmnUFhuAsn4QTif+3dubjg8NxxRB5p9cKzS5tGNy O4oCFsor/bG5brACEA35oTPDjxAAOvuGSfk/g5fYkU7Dz3oUiFYihe0/46bn5Q== Precedence: bulk X-Mailing-List: linux-mips@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Fri, 08 Mar 2024 10:16:42 +0100 Message-Id: Cc: "Linus Walleij" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Thomas Bogendoerfer" , , , , , , "Gregory Clement" , "Vladimir Kondratiev" , "Thomas Petazzoni" , "Tawfik Bayouk" To: "Andi Shyti" From: =?utf-8?q?Th=C3=A9o_Lebrun?= Subject: Re: [PATCH v3 08/11] i2c: nomadik: support Mobileye EyeQ5 I2C controller X-Mailer: aerc 0.15.2 References: <20240306-mbly-i2c-v3-0-605f866aa4ec@bootlin.com> <20240306-mbly-i2c-v3-8-605f866aa4ec@bootlin.com> In-Reply-To: X-GND-Sasl: theo.lebrun@bootlin.com Hello Andi, On Fri Mar 8, 2024 at 12:11 AM CET, Andi Shyti wrote: > Hi Theo, > > ... > > > +static inline u8 nmk_i2c_readb(const struct nmk_i2c_dev *priv, > > + unsigned long reg) > > +{ > > + if (priv->has_32b_bus) > > + return readl(priv->virtbase + reg); > > + else > > + return readb(priv->virtbase + reg); > > +} > > you forgot to remove the else... not a problem, it's coherent > with its writeb counterpart. Yes I enjoy symmetry. :-) [...] > Looks good! > > Reviewed-by: Andi Shyti Thanks Andi! Any chance of seeing this series queued for v6.9? Regards, -- Th=C3=A9o Lebrun, Bootlin Embedded Linux and Kernel engineering https://bootlin.com