From: Shane McDonald <mcdonald.shane@gmail.com>
To: Andrew_Hughes@pmc-sierra.com, florian@openwrt.org,
linux-mips@linux-mips.org, Marc_St-Jean@pmc-sierra.com,
ralf@linux-mips.org
Subject: [PATCH] Simplify and correct interrupt handling for MSP4200
Date: Sun, 12 Jul 2009 10:42:06 -0600 [thread overview]
Message-ID: <E1MQ27q-00068L-IA@localhost> (raw)
The current interrupt handling code for the MSP4200 always
masks an interrupt before acknowledging it. This is not required,
as that will be handled by the level interrupt handler. This
change simplifies the MSP4200 code to remove the masking in the
ack routine, and makes sure that the minimum required operation
is performed for masking and acking, rather than always both
masking and acking the interrupt.
Signed-off-by: Shane McDonald <mcdonald.shane@gmail.com>
---
arch/mips/pmc-sierra/msp71xx/msp_irq_slp.c | 10 +---------
1 files changed, 1 insertions(+), 9 deletions(-)
diff --git a/arch/mips/pmc-sierra/msp71xx/msp_irq_slp.c b/arch/mips/pmc-sierra/msp71xx/msp_irq_slp.c
index 66f6f85..61f3902 100644
--- a/arch/mips/pmc-sierra/msp71xx/msp_irq_slp.c
+++ b/arch/mips/pmc-sierra/msp71xx/msp_irq_slp.c
@@ -45,13 +45,6 @@ static inline void mask_msp_slp_irq(unsigned int irq)
*/
static inline void ack_msp_slp_irq(unsigned int irq)
{
- mask_msp_slp_irq(irq);
-
- /*
- * only really necessary for 18, 16-14 and sometimes 3:0 (since
- * these can be edge sensitive) but it doesn't hurt for the others.
- */
-
/* check for PER interrupt range */
if (irq < MSP_PER_INTBASE)
*SLP_INT_STS_REG = (1 << (irq - MSP_SLP_INTBASE));
@@ -62,8 +55,7 @@ static inline void ack_msp_slp_irq(unsigned int irq)
static struct irq_chip msp_slp_irq_controller = {
.name = "MSP_SLP",
.ack = ack_msp_slp_irq,
- .mask = ack_msp_slp_irq,
- .mask_ack = ack_msp_slp_irq,
+ .mask = mask_msp_slp_irq,
.unmask = unmask_msp_slp_irq,
};
--
1.6.2.4
next reply other threads:[~2009-07-12 16:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-12 16:42 Shane McDonald [this message]
2009-07-13 12:10 ` [PATCH] Simplify and correct interrupt handling for MSP4200 Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1MQ27q-00068L-IA@localhost \
--to=mcdonald.shane@gmail.com \
--cc=Andrew_Hughes@pmc-sierra.com \
--cc=Marc_St-Jean@pmc-sierra.com \
--cc=florian@openwrt.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).