From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 870C2C433DF for ; Fri, 15 May 2020 03:18:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 39C5F2054F for ; Fri, 15 May 2020 03:18:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=flygoat.com header.i=jiaxun.yang@flygoat.com header.b="MaEKK/Mb" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727924AbgEODS0 (ORCPT ); Thu, 14 May 2020 23:18:26 -0400 Received: from sender3-op-o12.zoho.com.cn ([124.251.121.243]:17768 "EHLO sender3-op-o12.zoho.com.cn" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727869AbgEODSZ (ORCPT ); Thu, 14 May 2020 23:18:25 -0400 ARC-Seal: i=1; a=rsa-sha256; t=1589512684; cv=none; d=zoho.com.cn; s=zohoarc; b=Kr82VYcwh3WX1pT2Oz1uE0TVVH+6tE7BKeDMG6WSj8nhIGEic/tb5AT080jfYk4Pqb71v13HBBK9pKrx5xre3BWuTUqkTISB0vsylpgZ4e1SlIuyWQY+gBjt2KrYh+EQ9tDdTnrr/BMSp6CFHUzx8Gan7YsdyCr03EKe2nXco5M= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com.cn; s=zohoarc; t=1589512684; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:Reply-To:References:Subject:To; bh=a9MfE+IX939f7XSiZya+c23GX+UUfpJI7N9HjGVXA54=; b=eJ5JcL/ZlMz4eaMd3GqcgEp6r20GUk1IVL9+wQunCYW9BKmaxCI3NSaKl8RCzN5FrsB0HBO2aW5eP4cHyHHQa7cMotSfw4Na/pw7DZ0U1UCt4CIVD8dl5DEZes4R8RlGT16MU+yPH9n7Chwq4PqPOxbSvomYrxZswQjkF9G9Nzc= ARC-Authentication-Results: i=1; mx.zoho.com.cn; dkim=pass header.i=flygoat.com; spf=pass smtp.mailfrom=jiaxun.yang@flygoat.com; dmarc=pass header.from= header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1589512684; s=mail; d=flygoat.com; i=jiaxun.yang@flygoat.com; h=Date:From:To:CC:Subject:Reply-to:In-Reply-To:References:Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding; bh=a9MfE+IX939f7XSiZya+c23GX+UUfpJI7N9HjGVXA54=; b=MaEKK/Mb8RQAk6lxjVcnvoEMdPLX2BhCBsjt91L3kre/rspxvztpC+xf1443+Xvq PJSPLMmdCZC/y5xktWkiGPG//Sip7wcFNMDIUb5whHJEi4/oXAxeuJC8QOQ8fEK775h kZoLMsY2Vt6J4dg35RuIgIdZywx6xovyv1Bw8oHY= Received: from [127.0.0.1] (101.84.172.108 [101.84.172.108]) by mx.zoho.com.cn with SMTPS id 15895126814021012.4116349819437; Fri, 15 May 2020 11:18:01 +0800 (CST) Date: Fri, 15 May 2020 11:17:58 +0800 From: Jiaxun Yang To: Tiezhu Yang , Thomas Bogendoerfer , Huacai Chen CC: linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, Xuefeng Li Subject: Re: [PATCH 1/2] MIPS: Loongson: Fix fatal error during GPU init User-Agent: K-9 Mail for Android Reply-to: jiaxun.yang@flygoat.com In-Reply-To: <636ba812-3849-2667-d625-ab7e35d5ac36@loongson.cn> References: <1589508901-18077-1-git-send-email-yangtiezhu@loongson.cn> <636ba812-3849-2667-d625-ab7e35d5ac36@loongson.cn> Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-ZohoCNMailClient: External Sender: linux-mips-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org =E4=BA=8E 2020=E5=B9=B45=E6=9C=8815=E6=97=A5 GMT+08:00 =E4=B8=8A=E5=8D=881= 1:09:56, Tiezhu Yang =E5=86=99=E5=88=B0: >On 05/15/2020 10:33 AM, Jiaxun Yang wrote: >> >> =E4=BA=8E 2020=E5=B9=B45=E6=9C=8815=E6=97=A5 GMT+08:00 =E4=B8=8A=E5=8D= =8810:15:00, Tiezhu Yang =E5=86=99=E5=88=B0: >>> When ATI Radeon graphics card has been compiled directly into the kern= el >>> instead of as a module, we should make sure the firmware for the model >>> (check available ones in /lib/firmware/radeon) is built-in to the kern= el >>> as well, otherwise there exists the following fatal error during GPU i= nit, >>> change CONFIG_DRM_RADEON=3Dy to CONFIG_DRM_RADEON=3Dm to fix it=2E >>> >> The commit message looks shocking=2E >> >> You'd better reword it as "MIPS: Loongson64: Mark GPU driver as module = in Kconfig" > >OK, I will modify the patch subject and send v2=2E Sorry I meant defconfig not Kconfig=2E > >> >> Thanks=2E > --=20 Jiaxun Yang