From: Aidan MacDonald <aidanmacdonald.0x0@gmail.com>
To: Mark Brown <broonie@kernel.org>
Cc: paul@crapouillou.net, lgirdwood@gmail.com, perex@perex.cz,
tiwai@suse.com, linux-mips@vger.kernel.org,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 04/11] ASoC: jz4740-i2s: Handle independent FIFO flush bits
Date: Fri, 08 Jul 2022 16:30:55 +0100 [thread overview]
Message-ID: <NuOKvbkZUvbLCcCv2cXfJsp97ioQdiVG@localhost> (raw)
In-Reply-To: <YsgmkBpk4JBTkjPz@sirena.org.uk>
Mark Brown <broonie@kernel.org> writes:
> On Fri, Jul 08, 2022 at 11:42:57AM +0100, Aidan MacDonald wrote:
>> On the JZ4740, there is a single bit that flushes (empties) both
>> the transmit and receive FIFO. Later SoCs have independent flush
>> bits for each FIFO, which allows us to flush the right FIFO when
>> starting up a stream.
>>
>> This also fixes a bug: since we were only setting the JZ4740's
>> flush bit, which corresponds to the TX FIFO flush bit on other
>> SoCs, other SoCs were not having their RX FIFO flushed at all.
>>
>> Fixes: 967beb2e8777 ("ASoC: jz4740: Add jz4780 support")
>
> Fixes should generally be at the start of a patch series so they don't
> end up depending on other patches needlessly.
Okay then, I'll refactor it to allow for easier backporting.
next prev parent reply other threads:[~2022-07-08 15:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-08 10:42 [PATCH v3 00/11] ASoC: cleanups and improvements for jz4740-i2s Aidan MacDonald
2022-07-08 10:42 ` [PATCH v3 01/11] ASoC: jz4740-i2s: Remove unused 'mem' resource Aidan MacDonald
2022-07-08 10:42 ` [PATCH v3 02/11] ASoC: jz4740-i2s: Convert to regmap API Aidan MacDonald
2022-07-08 10:42 ` [PATCH v3 03/11] ASoC: jz4740-i2s: Simplify using regmap fields Aidan MacDonald
2022-07-08 10:42 ` [PATCH v3 04/11] ASoC: jz4740-i2s: Handle independent FIFO flush bits Aidan MacDonald
2022-07-08 12:44 ` Mark Brown
2022-07-08 15:30 ` Aidan MacDonald [this message]
2022-07-08 10:42 ` [PATCH v3 05/11] ASoC: jz4740-i2s: Use FIELD_PREP() macros in hw_params callback Aidan MacDonald
2022-07-08 10:42 ` [PATCH v3 06/11] ASoC: jz4740-i2s: Align macro values and sort includes Aidan MacDonald
2022-07-08 10:43 ` [PATCH v3 07/11] ASoC: jz4740-i2s: Make the PLL clock name SoC-specific Aidan MacDonald
2022-07-08 10:43 ` [PATCH v3 08/11] ASoC: jz4740-i2s: Support S20_LE and S24_LE sample formats Aidan MacDonald
2022-07-08 10:43 ` [PATCH v3 09/11] ASoC: jz4740-i2s: Support continuous sample rate Aidan MacDonald
2022-07-08 10:43 ` [PATCH v3 10/11] ASoC: jz4740-i2s: Move component functions near the component driver Aidan MacDonald
2022-07-08 10:43 ` [PATCH v3 11/11] ASoC: jz4740-i2s: Refactor DAI probe/remove ops as component ops Aidan MacDonald
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=NuOKvbkZUvbLCcCv2cXfJsp97ioQdiVG@localhost \
--to=aidanmacdonald.0x0@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=paul@crapouillou.net \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).