From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E023EC433F5 for ; Fri, 11 Mar 2022 13:05:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238742AbiCKNGb (ORCPT ); Fri, 11 Mar 2022 08:06:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33390 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236208AbiCKNGa (ORCPT ); Fri, 11 Mar 2022 08:06:30 -0500 Received: from aposti.net (aposti.net [89.234.176.197]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E9F411C1AFB; Fri, 11 Mar 2022 05:05:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=crapouillou.net; s=mail; t=1647003923; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=O7m9TXBNiZRYoA89hrhRuwOoSnJmPIkD1Cv1P/g9Zqs=; b=MERMw+6FOV88njYAS6yz22ak8ZLlwjn5VZpMTKAo+HLXBEOKm9tjFjqVYBr5HezTJTCVX2 WRBxmoVcV7NWi80UA4LMICfxKThgDrkogBja1UfNQ8SdhiUBOoV1RlZzuNHmolr0Pekhvd oLLv5z7WMetYIiLObDiEy2M8urjYEIk= Date: Fri, 11 Mar 2022 13:05:13 +0000 From: Paul Cercueil Subject: Re: [PATCH v2 4/4] dt-bindings: display/panel: Add Leadtek ltk035c5444t To: Rob Herring Cc: Christophe Branchereau , David Airlie , Daniel Vetter , Thierry Reding , Sam Ravnborg , linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org Message-Id: In-Reply-To: References: <20220308130643.260683-1-cbranchereau@gmail.com> <20220308130643.260683-5-cbranchereau@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org Hi Rob, Le jeu., mars 10 2022 at 16:30:26 -0600, Rob Herring =20 a =E9crit : > On Tue, Mar 08, 2022 at 02:06:43PM +0100, Christophe Branchereau=20 > wrote: >> Add binding for the leadtek ltk035c5444t, which is a 640x480 >> mipi-dbi over spi / 24-bit RGB panel based on the newvision >> NV03052C chipset. >>=20 >> It is found in the Anbernic RG350M mips handheld. >>=20 >> Signed-off-by: Christophe Branchereau >> --- >> .../panel/leadtek,ltk035c5444t-spi.yaml | 59=20 >> +++++++++++++++++++ >> 1 file changed, 59 insertions(+) >> create mode 100644=20 >> Documentation/devicetree/bindings/display/panel/leadtek,ltk035c5444t-spi= .yaml >=20 > We have 18 SPI based panels already: >=20 > $ git grep -i 'spi.* {'=20 > Documentation/devicetree/bindings/display/panel/ > Documentation/devicetree/bindings/display/panel/abt,y030xx067a.yaml: =20 > spi { > Documentation/devicetree/bindings/display/panel/ilitek,ili9163.yaml: =20 > spi { > Documentation/devicetree/bindings/display/panel/ilitek,ili9322.yaml: =20 > spi { > Documentation/devicetree/bindings/display/panel/ilitek,ili9341.yaml: =20 > spi { > Documentation/devicetree/bindings/display/panel/innolux,ej030na.yaml:=20 > spi { > Documentation/devicetree/bindings/display/panel/kingdisplay,kd035g6-54nt.= yaml:=20 > spi { > Documentation/devicetree/bindings/display/panel/lg,lg4573.yaml: =20 > spi { > Documentation/devicetree/bindings/display/panel/lgphilips,lb035q02.yaml:=20 > spi { > Documentation/devicetree/bindings/display/panel/nec,nl8048hl11.yaml: =20 > spi0 { > Documentation/devicetree/bindings/display/panel/samsung,ld9040.yaml: =20 > spi { > Documentation/devicetree/bindings/display/panel/samsung,lms380kf01.yaml:=20 > spi { > Documentation/devicetree/bindings/display/panel/samsung,lms397kf04.yaml:=20 > spi { > Documentation/devicetree/bindings/display/panel/samsung,s6d27a1.yaml:=20 > spi { > Documentation/devicetree/bindings/display/panel/samsung,s6e63m0.yaml:=20 > spi { > Documentation/devicetree/bindings/display/panel/sitronix,st7789v.yaml:=20 > spi { > Documentation/devicetree/bindings/display/panel/sony,acx565akm.yaml: =20 > spi { > Documentation/devicetree/bindings/display/panel/tpo,td.yaml: spi { > Documentation/devicetree/bindings/display/panel/tpo,tpg110.yaml: =20 > spi { >=20 > Most except for the Samsung ones look like they'd fit in our=20 > definition > of 'simple panels' which primarily means 1 supply. >=20 > So I think it is time for a panel-simple-spi.yaml binding to combine=20 > all > these. But I'm not going to make the person adding the 19th case to do > that, and this otherwise looks fine: >=20 > Reviewed-by: Rob Herring I actually thought you sent a patch for this already (I remember you=20 talking about it last a binding for a new SPI panel has been added). I will work on it next week - provided Cristophe's patch has been=20 merged before. Cheers, -Paul >=20 > With one nit fixed below: >=20 >>=20 >> diff --git=20 >> a/Documentation/devicetree/bindings/display/panel/leadtek,ltk035c5444t-s= pi.yaml=20 >> b/Documentation/devicetree/bindings/display/panel/leadtek,ltk035c5444t-s= pi.yaml >> new file mode 100644 >> index 000000000000..9b6f1810adab >> --- /dev/null >> +++=20 >> b/Documentation/devicetree/bindings/display/panel/leadtek,ltk035c5444t-s= pi.yaml >> @@ -0,0 +1,59 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id:=20 >> http://devicetree.org/schemas/display/panel/leadtek,ltk035c5444t-spi.yam= l# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Leadtek ltk035c5444t 3.5" (640x480 pixels) 24-bit IPS LCD=20 >> panel >> + >> +maintainers: >> + - Paul Cercueil >> + - Christophe Branchereau >> + >> +allOf: >> + - $ref: panel-common.yaml# >> + - $ref: /schemas/spi/spi-peripheral-props.yaml# >> + >> +properties: >> + compatible: >> + const: leadtek,ltk035c5444t-spi >=20 > '-spi' is redundant, so drop. >=20 >> + >> + backlight: true >> + port: true >> + power-supply: true >> + reg: true >> + reset-gpios: true >> + >> +required: >> + - compatible >> + - power-supply >> + - reset-gpios >> + >> +unevaluatedProperties: false >> + >> +examples: >> + - | >> + #include >> + >> + spi { >> + #address-cells =3D <1>; >> + #size-cells =3D <0>; >> + panel@0 { >> + compatible =3D "leadtek,ltk035c5444t-spi"; >=20 > And update the example... >=20 >> + reg =3D <0>; >> + >> + spi-3wire; >> + spi-max-frequency =3D <3125000>; >> + >> + reset-gpios =3D <&gpe 2 GPIO_ACTIVE_LOW>; >> + >> + backlight =3D <&backlight>; >> + power-supply =3D <&vcc>; >> + >> + port { >> + panel_input: endpoint { >> + remote-endpoint =3D <&panel_output>; >> + }; >> + }; >> + }; >> + }; >> -- >> 2.34.1 >>=20 >>=20