From: Paul Cercueil <paul@crapouillou.net>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: Aidan MacDonald <aidanmacdonald.0x0@gmail.com>,
robh+dt@kernel.org, linux-mips@vger.kernel.org,
linux-pwm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] pwm: jz4740: Add support for X1000 SoC
Date: Thu, 24 Feb 2022 15:25:01 +0000 [thread overview]
Message-ID: <PTET7R.D6X3F4XL0K3E1@crapouillou.net> (raw)
In-Reply-To: <YheK4+t9w5IeHiDT@orome>
Hi,
Le jeu., févr. 24 2022 at 14:40:51 +0100, Thierry Reding
<thierry.reding@gmail.com> a écrit :
> On Mon, Feb 14, 2022 at 12:02:26PM +0000, Paul Cercueil wrote:
>> Hi Aidan,
>>
>> Le mer., févr. 9 2022 at 23:11:42 +0000, Aidan MacDonald
>> <aidanmacdonald.0x0@gmail.com> a écrit :
>> > The X1000 has the same TCU / PWM hardware as other Ingenic SoCs,
>> > but it has only 5 channels.
>> >
>> > Signed-off-by: Aidan MacDonald <aidanmacdonald.0x0@gmail.com>
>> > ---
>> > arch/mips/boot/dts/ingenic/x1000.dtsi | 13 +++++++++++++
>> > drivers/pwm/pwm-jz4740.c | 5 +++++
>>
>> Please put the driver and device tree changes into separate patches.
>
> Seemed a shame not to take this, so I've manually removed the DTS
> changes and applied this to the PWM tree.
>
> Aidan, probably best to resend the DTS snippet as a separate patch,
> unless Paul also wants to apply this manually.
I am not the arch/mips/ maintainer, so a separate patch would be needed
anyway, yes.
Cheers,
-Paul
next prev parent reply other threads:[~2022-02-24 15:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-09 23:11 [PATCH 1/2] dt-bindings: timer: Add PWM compatible for X1000 SoC Aidan MacDonald
2022-02-09 23:11 ` [PATCH 2/2] pwm: jz4740: Add support " Aidan MacDonald
2022-02-14 12:02 ` Paul Cercueil
2022-02-24 13:40 ` Thierry Reding
2022-02-24 15:25 ` Paul Cercueil [this message]
2022-02-11 17:08 ` [PATCH 1/2] dt-bindings: timer: Add PWM compatible " Rob Herring
2022-02-14 12:00 ` Paul Cercueil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PTET7R.D6X3F4XL0K3E1@crapouillou.net \
--to=paul@crapouillou.net \
--cc=aidanmacdonald.0x0@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox