From: Paul Cercueil <paul@crapouillou.net>
To: "H. Nikolaus Schaller" <hns@goldelico.com>
Cc: Neil Armstrong <narmstrong@baylibre.com>,
Paul Boddie <paul@boddie.org.uk>, Daniel Vetter <daniel@ffwll.ch>,
Maxime Ripard <maxime@cerno.tech>,
Jonas Karlman <jonas@kwiboo.se>, David Airlie <airlied@linux.ie>,
dri-devel <dri-devel@lists.freedesktop.org>,
linux-mips <linux-mips@vger.kernel.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>,
Robert Foss <robert.foss@linaro.org>,
Andrzej Hajda <andrzej.hajda@intel.com>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Discussions about the Letux Kernel
<letux-kernel@openphoenux.org>
Subject: Re: [Letux-kernel] [PATCH v16 1/4] drm/bridge: dw-hdmi: introduce dw_hdmi_enable_poll()
Date: Thu, 03 Mar 2022 17:20:51 +0000 [thread overview]
Message-ID: <RUI68R.Z009SPJAAD8N1@crapouillou.net> (raw)
In-Reply-To: <ABC1BD09-383B-4499-B034-340CE88725B3@goldelico.com>
Hi Nikolaus,
[snip]
>> Well he said "the Ingenic DRM core" aka ingenic-drm-drv.c. You do
>> have access to the main drm_device in the ingenic_drm_bind()
>> function, so you can add it there (with a cleanup function calling
>> drm_kms_helper_poll_fini() registered with
>> drmm_add_action_or_reset()).
>
> Well, do you really want to mix HPD detection between connector,
> Synopsys bridge and Ingenic DRM core? These are independent...
> Or should be accessed only through the bridge chain pointers.
>
> IMHO we should keep separate functions separate.
The drm_kms_helper_poll_init() just says "this DRM device may have
connectors that need to be polled" so it very well fits inside the main
driver, IMHO.
-Paul
>
> And maybe this should also be conditional? Maybe not depend on
> compatible = jz4780 but compatible = ci20?
>
> Looks to me to be a quick fix in the wrong place.
>
> Let's fix the CSC issue first.
>
> BR,
> Nikolaus
>
next prev parent reply other threads:[~2022-03-03 17:21 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-26 17:12 [PATCH v16 0/4] MIPS: JZ4780 and CI20 HDMI H. Nikolaus Schaller
2022-02-26 17:12 ` [PATCH v16 1/4] drm/bridge: dw-hdmi: introduce dw_hdmi_enable_poll() H. Nikolaus Schaller
2022-03-03 16:23 ` Neil Armstrong
2022-03-03 16:30 ` H. Nikolaus Schaller
2022-03-03 16:43 ` [Letux-kernel] " H. Nikolaus Schaller
2022-03-03 16:51 ` Paul Cercueil
2022-03-03 17:09 ` H. Nikolaus Schaller
2022-03-03 17:20 ` Paul Cercueil [this message]
2022-03-03 17:59 ` H. Nikolaus Schaller
2022-03-04 13:30 ` Neil Armstrong
2022-03-04 16:47 ` Paul Cercueil
2022-03-04 17:51 ` H. Nikolaus Schaller
2022-03-04 18:04 ` Paul Cercueil
2022-03-04 18:15 ` H. Nikolaus Schaller
2022-03-04 18:33 ` Paul Cercueil
2022-03-04 18:41 ` H. Nikolaus Schaller
2022-03-05 7:49 ` H. Nikolaus Schaller
2022-03-03 16:46 ` Paul Cercueil
2022-03-03 17:05 ` H. Nikolaus Schaller
2022-02-26 17:13 ` [PATCH v16 2/4] drm/ingenic: Add dw-hdmi driver specialization for jz4780 H. Nikolaus Schaller
2022-02-26 17:13 ` [PATCH v16 3/4] drm/bridge: display-connector: add ddc-en gpio support H. Nikolaus Schaller
2022-02-26 17:13 ` [PATCH v16 4/4] drm/bridge: dw-hdmi: fix bus formats negotiation for 8 bit modes H. Nikolaus Schaller
2022-03-01 9:18 ` Neil Armstrong
2022-03-01 20:37 ` H. Nikolaus Schaller
2022-03-02 10:25 ` Neil Armstrong
2022-03-02 11:15 ` H. Nikolaus Schaller
2022-03-02 14:34 ` Neil Armstrong
2022-03-02 22:24 ` H. Nikolaus Schaller
2022-03-03 8:35 ` Neil Armstrong
2022-03-03 10:40 ` H. Nikolaus Schaller
2022-03-03 11:42 ` Neil Armstrong
2022-03-03 11:45 ` H. Nikolaus Schaller
2022-03-03 15:37 ` H. Nikolaus Schaller
2022-03-03 16:14 ` Neil Armstrong
2022-03-03 15:15 ` Paul Cercueil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=RUI68R.Z009SPJAAD8N1@crapouillou.net \
--to=paul@crapouillou.net \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=airlied@linux.ie \
--cc=andrzej.hajda@intel.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=hns@goldelico.com \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=kieran.bingham+renesas@ideasonboard.com \
--cc=letux-kernel@openphoenux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=maxime@cerno.tech \
--cc=narmstrong@baylibre.com \
--cc=paul@boddie.org.uk \
--cc=robert.foss@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).