From: Conor Dooley <conor@kernel.org>
To: Jiaxun Yang <jiaxun.yang@flygoat.com>
Cc: linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, tsbogend@alpha.franken.de,
mpe@ellerman.id.au, paul.walmsley@sifive.com, palmer@dabbelt.com,
robh+dt@kernel.org, hch@lst.de, m.szyprowski@samsung.com,
robin.murphy@arm.com
Subject: Re: [PATCH 6/7] riscv: Select ARCH_DMA_DEFAULT_COHERENT
Date: Tue, 21 Feb 2023 18:14:12 +0000 [thread overview]
Message-ID: <Y/UJ9HowQdsNN+Cz@spud> (raw)
In-Reply-To: <20230221124613.2859-7-jiaxun.yang@flygoat.com>
[-- Attachment #1: Type: text/plain, Size: 713 bytes --]
On Tue, Feb 21, 2023 at 12:46:12PM +0000, Jiaxun Yang wrote:
> For RISCV we always assume devices are DMA coherent.
"Always assume", I'm not keen on that wording as it is unclear as to
whether you are suggesting that a) we always take devices to be DMA
coherent, or b) unless a device states it is non-coherent, we take it to
be DMA coherent.
I think you mean b, but being exact would be appreciated, thanks.
> Select ARCH_DMA_DEFAULT_COHERENT to ensure dev->dma_conherent
> is always initialized to true.
>
> Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
Why was this not sent to the riscv list?
When (or if) you send v2, can you please make sure that you do cc it?
Thanks,
Conor.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2023-02-21 18:15 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-21 12:46 [PATCH 0/7] MIPS DMA coherence fixes Jiaxun Yang
2023-02-21 12:46 ` [PATCH 1/7] MIPS: Remove DMA_PERDEV_COHERENT Jiaxun Yang
2023-02-21 17:56 ` Christoph Hellwig
2023-02-21 12:46 ` [PATCH 2/7] MIPS: Always select ARCH_HAS_SYNC_DMA_FOR_CPU for noncoherent platforms Jiaxun Yang
2023-02-21 12:46 ` [PATCH 3/7] MIPS: c-r4k: Always install dma flush functions Jiaxun Yang
2023-02-21 12:46 ` [PATCH 4/7] dma-mapping: Always provide dma_default_coherent Jiaxun Yang
2023-02-21 17:58 ` Christoph Hellwig
2023-02-21 19:35 ` Robin Murphy
2023-02-21 19:56 ` Jiaxun Yang
2023-02-21 12:46 ` [PATCH 5/7] dma-mapping: Provide CONFIG_ARCH_DMA_DEFAULT_COHERENT Jiaxun Yang
2023-02-21 17:58 ` Christoph Hellwig
2023-02-21 18:18 ` Jiaxun Yang
2023-02-21 12:46 ` [PATCH 6/7] riscv: Select ARCH_DMA_DEFAULT_COHERENT Jiaxun Yang
2023-02-21 18:14 ` Conor Dooley [this message]
2023-02-21 18:20 ` Jiaxun Yang
2023-02-21 12:46 ` [PATCH 7/7] of: address: Use dma_default_coherent to determine default coherency Jiaxun Yang
2023-02-21 17:54 ` [PATCH 0/7] MIPS DMA coherence fixes Christoph Hellwig
2023-02-21 18:15 ` Jiaxun Yang
2023-02-21 19:46 ` Robin Murphy
2023-02-21 19:55 ` Jiaxun Yang
2023-02-22 12:55 ` Robin Murphy
2023-02-22 13:04 ` Jiaxun Yang
2023-02-22 14:22 ` Robin Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y/UJ9HowQdsNN+Cz@spud \
--to=conor@kernel.org \
--cc=hch@lst.de \
--cc=jiaxun.yang@flygoat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=m.szyprowski@samsung.com \
--cc=mpe@ellerman.id.au \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh+dt@kernel.org \
--cc=robin.murphy@arm.com \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).