From: Heiko Carstens <hca@linux.ibm.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Alexandre Ghiti <alexghiti@rivosinc.com>,
Jonathan Corbet <corbet@lwn.net>,
Richard Henderson <richard.henderson@linaro.org>,
Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
Matt Turner <mattst88@gmail.com>,
Vineet Gupta <vgupta@kernel.org>,
Russell King <linux@armlinux.org.uk>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Huacai Chen <chenhuacai@kernel.org>,
WANG Xuerui <kernel@xen0n.name>, Michal Simek <monstr@monstr.eu>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
"James E . J . Bottomley" <James.Bottomley@hansenpartnership.com>,
Helge Deller <deller@gmx.de>,
Michael Ellerman <mpe@ellerman.id.au>,
Nicholas Piggin <npiggin@gmail.com>,
Christophe Leroy <christophe.leroy@csgroup.eu>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Vasily Gorbik <gor@linux.ibm.com>,
Alexander Gordeev <agordeev@linux.ibm.com>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Sven Schnelle <svens@linux.ibm.com>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Rich Felker <dalias@libc.org>,
"David S . Miller" <davem@davemloft.net>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, "H . Peter Anvin" <hpa@zytor.com>,
Chris Zankel <chris@zankel.net>,
Max Filippov <jcmvbkbc@gmail.com>, Arnd Bergmann <arnd@arndb.de>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-alpha@vger.kernel.org, linux-snps-arc@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org,
loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org,
linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org,
linux-s390@vger.kernel.org, linux-sh@vger.kernel.org,
sparclinux@vger.kernel.org, linux-xtensa@linux-xtensa.org,
linux-arch@vger.kernel.org
Subject: Re: [PATCH v3 00/24] Remove COMMAND_LINE_SIZE from uapi
Date: Tue, 14 Feb 2023 10:19:02 +0100 [thread overview]
Message-ID: <Y+tSBlSsQBQF/Ro2@osiris> (raw)
In-Reply-To: <CAMuHMdVG4=UmKDa17dys9e3iGM75u4+13nQVyjMHK--aD6WKfw@mail.gmail.com>
On Tue, Feb 14, 2023 at 09:58:17AM +0100, Geert Uytterhoeven wrote:
> Hi Heiko,
>
> On Tue, Feb 14, 2023 at 9:39 AM Heiko Carstens <hca@linux.ibm.com> wrote:
> > On Tue, Feb 14, 2023 at 08:49:01AM +0100, Alexandre Ghiti wrote:
> > > This all came up in the context of increasing COMMAND_LINE_SIZE in the
> > > RISC-V port. In theory that's a UABI break, as COMMAND_LINE_SIZE is the
> > > maximum length of /proc/cmdline and userspace could staticly rely on
> > > that to be correct.
> > >
> > > Usually I wouldn't mess around with changing this sort of thing, but
> > > PowerPC increased it with a5980d064fe2 ("powerpc: Bump COMMAND_LINE_SIZE
> > > to 2048"). There are also a handful of examples of COMMAND_LINE_SIZE
> > > increasing, but they're from before the UAPI split so I'm not quite sure
> > > what that means: e5a6a1c90948 ("powerpc: derive COMMAND_LINE_SIZE from
> > > asm-generic"), 684d2fd48e71 ("[S390] kernel: Append scpdata to kernel
> > > boot command line"), 22242681cff5 ("MIPS: Extend COMMAND_LINE_SIZE"),
> > > and 2b74b85693c7 ("sh: Derive COMMAND_LINE_SIZE from
> > > asm-generic/setup.h.").
> > >
> > > It seems to me like COMMAND_LINE_SIZE really just shouldn't have been
> > > part of the uapi to begin with, and userspace should be able to handle
> > > /proc/cmdline of whatever length it turns out to be. I don't see any
> > > references to COMMAND_LINE_SIZE anywhere but Linux via a quick Google
> > > search, but that's not really enough to consider it unused on my end.
> > >
> > > The feedback on the v1 seemed to indicate that COMMAND_LINE_SIZE really
> > > shouldn't be part of uapi, so this now touches all the ports. I've
> > > tried to split this all out and leave it bisectable, but I haven't
> > > tested it all that aggressively.
> >
> > Just to confirm this assumption a bit more: that's actually the same
> > conclusion that we ended up with when commit 3da0243f906a ("s390: make
> > command line configurable") went upstream.
>
> Commit 622021cd6c560ce7 ("s390: make command line configurable"),
> I assume?
Yes, sorry for that. I got distracted while writing and used the wrong
branch to look this up.
next prev parent reply other threads:[~2023-02-14 9:20 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-14 7:49 [PATCH v3 00/24] Remove COMMAND_LINE_SIZE from uapi Alexandre Ghiti
2023-02-14 7:49 ` [PATCH v3 01/24] alpha: " Alexandre Ghiti
2023-02-14 9:07 ` Philippe Mathieu-Daudé
2023-02-14 7:49 ` [PATCH v3 02/24] arm64: " Alexandre Ghiti
2023-02-14 14:14 ` Catalin Marinas
2023-02-14 7:49 ` [PATCH v3 03/24] arm: " Alexandre Ghiti
2023-02-15 12:59 ` Russell King (Oracle)
2023-02-15 13:04 ` Arnd Bergmann
2023-02-23 9:54 ` Alexandre Ghiti
2023-02-23 13:09 ` Arnd Bergmann
2023-02-23 13:11 ` Alexandre Ghiti
2023-03-02 3:17 ` Palmer Dabbelt
2023-02-14 7:49 ` [PATCH v3 04/24] ia64: " Alexandre Ghiti
2023-02-14 7:49 ` [PATCH v3 05/24] m68k: " Alexandre Ghiti
2023-02-14 9:00 ` Geert Uytterhoeven
2023-02-14 7:49 ` [PATCH v3 06/24] microblaze: " Alexandre Ghiti
2023-02-14 7:49 ` [PATCH v3 07/24] mips: " Alexandre Ghiti
2023-02-14 9:06 ` Philippe Mathieu-Daudé
2023-02-14 7:49 ` [PATCH v3 08/24] parisc: " Alexandre Ghiti
2023-02-14 9:08 ` Philippe Mathieu-Daudé
2023-02-14 9:43 ` Helge Deller
2023-02-14 7:49 ` [PATCH v3 09/24] powerpc: " Alexandre Ghiti
2023-02-15 7:04 ` Michael Ellerman
2023-02-14 7:49 ` [PATCH v3 10/24] sparc: " Alexandre Ghiti
2023-02-14 8:50 ` Sergey Shtylyov
2023-02-14 8:59 ` WANG Xuerui
2023-02-14 9:11 ` Sergey Shtylyov
2023-02-14 10:38 ` John Paul Adrian Glaubitz
2023-02-14 7:49 ` [PATCH v3 11/24] xtensa: " Alexandre Ghiti
2023-02-14 12:56 ` Max Filippov
2023-02-14 7:49 ` [PATCH v3 12/24] asm-generic: " Alexandre Ghiti
2023-02-14 7:49 ` [PATCH v3 13/24] alpha: Remove empty <uapi/asm/setup.h> Alexandre Ghiti
2023-02-14 7:49 ` [PATCH v3 14/24] arc: " Alexandre Ghiti
2023-02-14 9:05 ` Philippe Mathieu-Daudé
2023-02-14 7:49 ` [PATCH v3 15/24] m68k: " Alexandre Ghiti
2023-02-14 9:01 ` Geert Uytterhoeven
2023-02-14 7:49 ` [PATCH v3 16/24] arm64: " Alexandre Ghiti
2023-02-14 7:49 ` [PATCH v3 17/24] microblaze: " Alexandre Ghiti
2023-02-14 7:49 ` [PATCH v3 18/24] sparc: " Alexandre Ghiti
2023-02-14 7:49 ` [PATCH v3 19/24] parisc: " Alexandre Ghiti
2023-02-14 9:08 ` Philippe Mathieu-Daudé
2023-02-14 9:44 ` Helge Deller
2023-02-14 7:49 ` [PATCH v3 20/24] x86: " Alexandre Ghiti
2023-02-14 9:04 ` Philippe Mathieu-Daudé
2023-02-14 7:49 ` [PATCH v3 21/24] xtensa: " Alexandre Ghiti
2023-02-14 13:10 ` Max Filippov
2023-02-14 7:49 ` [PATCH v3 22/24] powerpc: " Alexandre Ghiti
2023-02-14 7:49 ` [PATCH v3 23/24] mips: " Alexandre Ghiti
2023-02-14 7:49 ` [PATCH v3 24/24] s390: " Alexandre Ghiti
2023-02-14 8:39 ` Heiko Carstens
2023-02-14 9:05 ` Philippe Mathieu-Daudé
2023-02-14 8:38 ` [PATCH v3 00/24] Remove COMMAND_LINE_SIZE from uapi Heiko Carstens
2023-02-14 8:58 ` Geert Uytterhoeven
2023-02-14 9:19 ` Heiko Carstens [this message]
2023-03-02 3:17 ` Palmer Dabbelt
2023-03-02 7:57 ` Alexandre Ghiti
2023-03-02 19:50 ` H. Peter Anvin
2023-03-03 11:59 ` Alexandre Ghiti
2023-03-03 16:40 ` Arnd Bergmann
2023-03-06 9:35 ` Alexandre Ghiti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+tSBlSsQBQF/Ro2@osiris \
--to=hca@linux.ibm.com \
--cc=James.Bottomley@hansenpartnership.com \
--cc=agordeev@linux.ibm.com \
--cc=alexghiti@rivosinc.com \
--cc=aou@eecs.berkeley.edu \
--cc=arnd@arndb.de \
--cc=borntraeger@linux.ibm.com \
--cc=bp@alien8.de \
--cc=catalin.marinas@arm.com \
--cc=chenhuacai@kernel.org \
--cc=chris@zankel.net \
--cc=christophe.leroy@csgroup.eu \
--cc=corbet@lwn.net \
--cc=dalias@libc.org \
--cc=dave.hansen@linux.intel.com \
--cc=davem@davemloft.net \
--cc=deller@gmx.de \
--cc=geert@linux-m68k.org \
--cc=gor@linux.ibm.com \
--cc=hpa@zytor.com \
--cc=ink@jurassic.park.msu.ru \
--cc=jcmvbkbc@gmail.com \
--cc=kernel@xen0n.name \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=linux-xtensa@linux-xtensa.org \
--cc=linux@armlinux.org.uk \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=loongarch@lists.linux.dev \
--cc=mattst88@gmail.com \
--cc=mingo@redhat.com \
--cc=monstr@monstr.eu \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=richard.henderson@linaro.org \
--cc=sparclinux@vger.kernel.org \
--cc=svens@linux.ibm.com \
--cc=tglx@linutronix.de \
--cc=tsbogend@alpha.franken.de \
--cc=vgupta@kernel.org \
--cc=will@kernel.org \
--cc=x86@kernel.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).