From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Paul Cercueil <paul@crapouillou.net>
Cc: Alessandro Zummo <a.zummo@towertech.it>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-rtc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org,
od@opendingux.net
Subject: Re: [PATCH v2 0/4] rtc: ingenic: various updates
Date: Wed, 2 Nov 2022 18:40:08 +0100 [thread overview]
Message-ID: <Y2KreBRUnSVxHfZF@mail.local> (raw)
In-Reply-To: <20221028225519.89210-1-paul@crapouillou.net>
On 28/10/2022 23:55:15+0100, Paul Cercueil wrote:
> Hi Alessandro / Alexandre,
>
> Here's the V2 of a previous patchset I sent back in April.
>
> Patch [1/4] was updated with Krzysztof's feedback.
>
> Patches 2-4 are unmodified from V1 as they didn't receive any feedback.
> Patch 4 is RFC; I *think* it works, but I don't know how to test it.
>
You should simply adjust the RTC and see whether the drift changes. The
best is to simply use chrony as this will actually tell you how much the
RTC drifts. This actually gives you the exact value to put in offset to
remove the drift.
> V1 had a 5th patch which would reset the scratchpad register on power
> loss, but was dropped following upstream feedback.
>
> Cheers,
> - Paul
>
> Paul Cercueil (4):
> dt-bindings: rtc: ingenic: Rework compatible strings and add #clock-cells
> rtc: jz4740: Use readl_poll_timeout
> rtc: jz4740: Register clock provider for the CLK32K pin
> rtc: jz4740: Support for fine-tuning the RTC clock
>
> .../devicetree/bindings/rtc/ingenic,rtc.yaml | 32 ++++-
> drivers/rtc/rtc-jz4740.c | 113 +++++++++++++++---
> 2 files changed, 129 insertions(+), 16 deletions(-)
>
> --
> 2.35.1
>
--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2022-11-02 17:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-28 22:55 [PATCH v2 0/4] rtc: ingenic: various updates Paul Cercueil
2022-10-28 22:55 ` [PATCH v2 1/4] dt-bindings: rtc: ingenic: Rework compatible strings and add #clock-cells Paul Cercueil
2022-10-31 19:23 ` Rob Herring
2022-10-31 19:40 ` Paul Cercueil
2022-11-01 17:32 ` Rob Herring
2022-10-28 22:55 ` [PATCH v2 2/4] rtc: jz4740: Use readl_poll_timeout Paul Cercueil
2022-10-28 22:55 ` [PATCH v2 3/4] rtc: jz4740: Register clock provider for the CLK32K pin Paul Cercueil
2022-10-28 22:55 ` [PATCH v2 4/4] rtc: jz4740: Support for fine-tuning the RTC clock Paul Cercueil
[not found] ` <202210291633.edaeueJF-lkp@intel.com>
2022-10-29 11:52 ` Paul Cercueil
2022-11-02 17:40 ` Alexandre Belloni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2KreBRUnSVxHfZF@mail.local \
--to=alexandre.belloni@bootlin.com \
--cc=a.zummo@towertech.it \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=od@opendingux.net \
--cc=paul@crapouillou.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).