From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98173C47088 for ; Sat, 3 Dec 2022 15:27:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229650AbiLCP1m (ORCPT ); Sat, 3 Dec 2022 10:27:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52210 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229575AbiLCP1l (ORCPT ); Sat, 3 Dec 2022 10:27:41 -0500 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EFB1A2BC0; Sat, 3 Dec 2022 07:27:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1670081258; x=1701617258; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=uSf2YHH5QrA+iUzZpxeHz51OuUatV/0N2ramzCq2LzY=; b=WH2VZl4V96I5i/spmTiYeOBAbFimUT1yxXYxbnTqjvJ3cCCTjtEUXGCY ye2XvjX8lBtQw16Ulu7lKJ41zlfq2ksfuy6yUCZPvw+/tlXfRkuqWhloo 32GOlBCUeOvLDIDUpiHDecwV9RI3bqBXT8GYTsWd8FMhbLdULeCYjhTUI PRHLq1grj7buNjwl7paBPQjCN92PVK0zlhHig0MhoRjPXujUOSKeY85K/ qHu2DrJCVVzXmz62NHx+grZgCbNfkmK+wqnmYG5w6vvqOK5sLlkc7exwC 2Bk3zZFnhMvAVaCTl0QRLtnaq/hJfS1RbcZU4ESIEsVVKBWVjWnY8cEnW A==; X-IronPort-AV: E=McAfee;i="6500,9779,10549"; a="314834590" X-IronPort-AV: E=Sophos;i="5.96,214,1665471600"; d="scan'208";a="314834590" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Dec 2022 07:27:38 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10549"; a="787604048" X-IronPort-AV: E=Sophos;i="5.96,214,1665471600"; d="scan'208";a="787604048" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga001.fm.intel.com with ESMTP; 03 Dec 2022 07:27:33 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1p1UQN-0042l6-0l; Sat, 03 Dec 2022 17:27:31 +0200 Date: Sat, 3 Dec 2022 17:27:30 +0200 From: Andy Shevchenko To: Yinbo Zhu Cc: Linus Walleij , Bartosz Golaszewski , Rob Herring , Krzysztof Kozlowski , WANG Xuerui , Jiaxun Yang , Thomas Bogendoerfer , Juxin Gao , Bibo Mao , Yanteng Si , linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, loongarch@lists.linux.dev, linux-mips@vger.kernel.org, Arnaud Patard , Huacai Chen , Jianmin Lv , Hongchen Zhang , Liu Peibao Subject: Re: [PATCH v10 1/2] gpio: loongson: add gpio driver support Message-ID: References: <20221201123220.7893-1-zhuyinbo@loongson.cn> <35ff475a-e925-81eb-ffeb-448be43f59ff@loongson.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <35ff475a-e925-81eb-ffeb-448be43f59ff@loongson.cn> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org On Sat, Dec 03, 2022 at 06:53:20PM +0800, Yinbo Zhu wrote: > 在 2022/12/3 18:03, Linus Walleij 写道: > > On Thu, Dec 1, 2022 at 1:33 PM Yinbo Zhu wrote: > > > +config GPIO_LOONGSON_64BIT > > > + tristate "Loongson 64 bit GPIO support" > > > + depends on LOONGARCH || COMPILE_TEST > > > + select GPIO_GENERIC > > > + select GPIOLIB_IRQCHIP > > If the kernelbots start complaining you might need to add a: > > > > select IRQ_DOMAIN_HIERARCHY > > > > here. > > Bartosz had merged my patch and I will add a change on top of the existing > series. I don;'t know why he had done that, the driver requires a lot of cleanups, e.g. why it uses acpi.h, what that "nice" container of the platform device for. -- With Best Regards, Andy Shevchenko