From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96A57C352A1 for ; Sat, 3 Dec 2022 15:41:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229755AbiLCPl4 (ORCPT ); Sat, 3 Dec 2022 10:41:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60820 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229631AbiLCPlz (ORCPT ); Sat, 3 Dec 2022 10:41:55 -0500 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D7F51218A7; Sat, 3 Dec 2022 07:41:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1670082114; x=1701618114; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=9CAAZYx5QtB8bGk6Bu4vfzSdNz5rmp6CUGug+ibS7H4=; b=dyhGoyWLRr6w2+5ymfsf2vik2Zcc0fYOg1te/YQc1dLbBd1bkTC1cxwY 3Qz9IB1QSM+f4x1++/81qPqrGF0+Fbc6XDGGdGMTELiet7Rvje+BW8S2s 9K44NIoLmI/jEwJ3aUt4lqYFr7qJ4NGC29gmgDcf8Jgv8wNYGX04fA4tB e4oHrf9bSGCTibbXWiKIETq3o9U7HmCNk5Tr2cor19c+T7qrJ2pO+JAxs Ykl5H82M6H/EPGe57MoytgWN7X4BHjjzYCO4DR7/Gga8FHmmgPWChB95L Sz/Q6xRHgeeBXqJq/0UQHcbdZFaGz9GgR8Gz8R/Z94927j7fU/+vJfDtU Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10549"; a="314835236" X-IronPort-AV: E=Sophos;i="5.96,214,1665471600"; d="scan'208";a="314835236" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Dec 2022 07:41:54 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10549"; a="787605439" X-IronPort-AV: E=Sophos;i="5.96,214,1665471600"; d="scan'208";a="787605439" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga001.fm.intel.com with ESMTP; 03 Dec 2022 07:41:49 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1p1UeB-00432n-1I; Sat, 03 Dec 2022 17:41:47 +0200 Date: Sat, 3 Dec 2022 17:41:47 +0200 From: Andy Shevchenko To: Yinbo Zhu Cc: Linus Walleij , Bartosz Golaszewski , Rob Herring , Krzysztof Kozlowski , WANG Xuerui , Jiaxun Yang , Thomas Bogendoerfer , Juxin Gao , Bibo Mao , Yanteng Si , linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, loongarch@lists.linux.dev, linux-mips@vger.kernel.org, Arnaud Patard , Huacai Chen , Jianmin Lv , Hongchen Zhang , Liu Peibao Subject: Re: [PATCH v10 1/2] gpio: loongson: add gpio driver support Message-ID: References: <20221201123220.7893-1-zhuyinbo@loongson.cn> <35ff475a-e925-81eb-ffeb-448be43f59ff@loongson.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org On Sat, Dec 03, 2022 at 05:27:31PM +0200, Andy Shevchenko wrote: > On Sat, Dec 03, 2022 at 06:53:20PM +0800, Yinbo Zhu wrote: > > 在 2022/12/3 18:03, Linus Walleij 写道: > > > On Thu, Dec 1, 2022 at 1:33 PM Yinbo Zhu wrote: > > > > +config GPIO_LOONGSON_64BIT > > > > + tristate "Loongson 64 bit GPIO support" > > > > + depends on LOONGARCH || COMPILE_TEST > > > > + select GPIO_GENERIC > > > > + select GPIOLIB_IRQCHIP > > > If the kernelbots start complaining you might need to add a: > > > > > > select IRQ_DOMAIN_HIERARCHY > > > > > > here. > > > > Bartosz had merged my patch and I will add a change on top of the existing > > series. > > I don;'t know why he had done that, the driver requires a lot of cleanups, > e.g. why it uses acpi.h, what that "nice" container of the platform device for. + we have macros for get_direction() returned values and so on. -- With Best Regards, Andy Shevchenko