From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A78BC4332F for ; Tue, 13 Dec 2022 17:28:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235923AbiLMR2t (ORCPT ); Tue, 13 Dec 2022 12:28:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48450 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235490AbiLMR2s (ORCPT ); Tue, 13 Dec 2022 12:28:48 -0500 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 47FA321273; Tue, 13 Dec 2022 09:28:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=+gHcL0GavN66hEyQQto3Gxp/s7JccGCmVE4ksMartuc=; b=svtedpfrmgRz4xaWewVFJm/yqD yqeYYjNiqllJeWMYVvO+hGpYRaoRLiwtrOCkBuiaN5D4ma8GagYKR/y3usItIh61p4SRs5FuOTCmv K8B84LSgkFMmRSUZ2fPjpdcZv3X6Hn/skU4RME/va+fXJ1nHlrdxCbWA302/9209llsZdYYnH2hCG 31l2qENg7yJ/X4MPoWpN3r7S8mCGzzA4pIL9d9i9N0BUqOKUya3gsoEpFW3ZgFJea5M4wIMJas0Ck 18jb1tkQO3d2LE8fn0MTcre9vD/rvQuVYxGY4my9+yKPCVkbhkqLLIRKFkFGGBf7cX9HKwGkyp5Ug Xc51TFIA==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:35694) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1p5956-0007O7-04; Tue, 13 Dec 2022 17:28:40 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1p5951-0006c0-Lf; Tue, 13 Dec 2022 17:28:35 +0000 Date: Tue, 13 Dec 2022 17:28:35 +0000 From: "Russell King (Oracle)" To: "Seija K." Cc: Stefano Stabellini , Thomas Bogendoerfer , Chris Zankel , Max Filippov , linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org Subject: Re: [PATCH] arch: change variable types to match those of what is assigned to them Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: Russell King (Oracle) Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org On Tue, Dec 13, 2022 at 12:03:51PM -0500, Seija K. wrote: > There are many places where "int len = strlen(foo);" is written, just > for len to be passed as a parameter of size_t. This causes truncation > and then expansion back from int to size_t. Not to mention this is > poor logic and needless truncations can add extra unneeded > instructions. > This patch aims to fix the worst offenders. I didn't bother looking too closely as the patch has been severely mangled. I think you need to reconsider how you send patches and find a way to test before you send emails to mailing lists. Thanks. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!