From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F643C43460 for ; Fri, 2 Apr 2021 14:59:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0B0016112E for ; Fri, 2 Apr 2021 14:59:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234479AbhDBO7u (ORCPT ); Fri, 2 Apr 2021 10:59:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52480 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235200AbhDBO7t (ORCPT ); Fri, 2 Apr 2021 10:59:49 -0400 Received: from mail-pj1-x102d.google.com (mail-pj1-x102d.google.com [IPv6:2607:f8b0:4864:20::102d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7B3F2C06178A for ; Fri, 2 Apr 2021 07:59:47 -0700 (PDT) Received: by mail-pj1-x102d.google.com with SMTP id il9-20020a17090b1649b0290114bcb0d6c2so4735422pjb.0 for ; Fri, 02 Apr 2021 07:59:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=XauO+Tpx/QqvLfsNf0EieVcjgezYHlrLlZApCjoCcwc=; b=Tzgme0UQBGKuB+zSlD0xeHc77Hy6oWyrRyYiRZQFSKSope2ZlQuprlNPAFIGno9HCF 19mRDkj5ZlfoNjs328k6GhD8eNbfCsQBcei3BTgXY+lndiulxllK9urmRZpNbnawPSHF 1VntLWcNLRE/v2TUKfmWJP3RUU9JLl2aM0LmT3koOB9K6//ZWjl40DmwLdcbMuXOftRy vY7bpTZFLIxlRDiIvxlrah94VXX6FYPLZOMp+MPalyOIzbjG3+pDcx1vJhHFGSEmzlRs VifckWbHZsxI2muXBZVeIADxXGgNHUOjgsjNw0sHYg1S4nsynZoWCREOXUk86kfL7DYo Pc7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=XauO+Tpx/QqvLfsNf0EieVcjgezYHlrLlZApCjoCcwc=; b=p1qAmCagj+5frx79n4QTBkH/gl4WdXC+4pd0aQslsFHEZ9NNgdMy2tfEHMp8IacXkh TlYPe3iOVZhfvQ7CuEXEjtB6KAhTe8ORAHzjmqnho1CWjggt3st8bGK58g1yD4er2VO9 1N8uHqeS9J6kcoUGeeoCdfcck8DFI0EBvtEbpezUTmPLJ5M8LdAmOLQBNEckmkKrxt45 pY0iHs/RFQLh2XMndc7Vb6mmmK/kh+OAYxtrJFo4UevtePuULvwXYGEyivJQLgVuQv+d M4GeEd589sLL34nJ3iIuI9l7lJ+qzIewutgVjcF5tDb2sRLUJz2kqF3S487VUtYY8OYF musw== X-Gm-Message-State: AOAM530PWCs9kKpfK6w+24YQNOTGpWthseiL36x979YFqUA0Lisro94y IpQkR8NUrOo8UnrtCfR6BOZRkA== X-Google-Smtp-Source: ABdhPJxioQlQNRTARxdEppiGDcKbsI4noyv87TJnoDznkG+oVESSh/n5TV8EGFMcsMJo2RSOZZ0Vdg== X-Received: by 2002:a17:90a:b889:: with SMTP id o9mr14181347pjr.97.1617375586898; Fri, 02 Apr 2021 07:59:46 -0700 (PDT) Received: from google.com (240.111.247.35.bc.googleusercontent.com. [35.247.111.240]) by smtp.gmail.com with ESMTPSA id n24sm8673883pgl.27.2021.04.02.07.59.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Apr 2021 07:59:46 -0700 (PDT) Date: Fri, 2 Apr 2021 14:59:42 +0000 From: Sean Christopherson To: Paolo Bonzini Cc: Marc Zyngier , Huacai Chen , Aleksandar Markovic , Paul Mackerras , James Morse , Julien Thierry , Suzuki K Poulose , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-mips@vger.kernel.org, kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, linux-kernel@vger.kernel.org, Ben Gardon Subject: Re: [PATCH v2 07/10] KVM: Move MMU notifier's mmu_lock acquisition into common helper Message-ID: References: <20210402005658.3024832-1-seanjc@google.com> <20210402005658.3024832-8-seanjc@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org On Fri, Apr 02, 2021, Paolo Bonzini wrote: > On 02/04/21 02:56, Sean Christopherson wrote: > > + .handler = (void *)kvm_null_fn, > > + .on_lock = kvm_dec_notifier_count, > > + .flush_on_ret = true, > > Doesn't really matter since the handler is null, but I think it's cleaner to > have false here. Agreed.