From: Vinod Koul <vkoul@kernel.org>
To: Kelvin Cheung <keguang.zhang@gmail.com>
Cc: dmaengine@vger.kernel.org, linux-mips@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V4 RESEND] dmaengine: Loongson1: Add Loongson1 dmaengine driver
Date: Mon, 5 Jul 2021 09:19:12 +0530 [thread overview]
Message-ID: <YOKBOFpNH0+3GN6e@matsya> (raw)
In-Reply-To: <CAJhJPsXv42e23tyQjA52_my1Au6nP_VdLX3c_yzk5MxadQ95iw@mail.gmail.com>
On 04-07-21, 22:45, Kelvin Cheung wrote:
> Vinod Koul <vkoul@kernel.org> 于2021年6月7日周一 下午7:07写道：
> >
> > On 21-05-21, 07:02, Keguang Zhang wrote:
> >
> > > +config LOONGSON1_DMA
> > > + tristate "Loongson1 DMA support"
> > > + depends on MACH_LOONGSON32
> >
> > Why does it have to do that? The dma driver is generic..
>
> This driver is only available for LOONGSON32 CPUs.
the underlaying firmware would ensure this driver is probed if you have
such a device, so why have this restriction?
> > > +static struct platform_driver ls1x_dma_driver = {
> > > + .probe = ls1x_dma_probe,
> > > + .remove = ls1x_dma_remove,
> > > + .driver = {
> > > + .name = "ls1x-dma",
> > > + },
> >
> > No device tree?
>
> Because the LOONGSON32 platform doesn't support DT yet.
Okay so how is the platform device created?
--
~Vinod
prev parent reply other threads:[~2021-07-05 3:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-20 23:02 [PATCH V4 RESEND] dmaengine: Loongson1: Add Loongson1 dmaengine driver Keguang Zhang
2021-06-07 11:07 ` Vinod Koul
2021-07-04 14:45 ` Kelvin Cheung
2021-07-05 3:49 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YOKBOFpNH0+3GN6e@matsya \
--to=vkoul@kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=keguang.zhang@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).