From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D317C433FE for ; Mon, 13 Sep 2021 18:21:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E48ED60F9F for ; Mon, 13 Sep 2021 18:21:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232400AbhIMSWr (ORCPT ); Mon, 13 Sep 2021 14:22:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43638 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239678AbhIMSWq (ORCPT ); Mon, 13 Sep 2021 14:22:46 -0400 Received: from mail-pg1-x52c.google.com (mail-pg1-x52c.google.com [IPv6:2607:f8b0:4864:20::52c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8801CC061574 for ; Mon, 13 Sep 2021 11:21:30 -0700 (PDT) Received: by mail-pg1-x52c.google.com with SMTP id r2so10214189pgl.10 for ; Mon, 13 Sep 2021 11:21:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=6++MUHqyHKCB5FgpZ/mPI8mWFFcZJMAIOAPJiYxj2J8=; b=I8oAss5KvNOxSzhenZXmIesL1MTLaeyUnk6Q8EYJv5KLYqd1LxYtn/ptQxgv3SD+T9 PsQ3lmeYGUOmkmNBEchDt3vbOWf9cDZ90nOdyyxe+PJxS6IItldgrzQgOojUBQJ9bxR0 MyBt75NYyvzrKbm2331lHF5jPUnLM/Z4/K+PyuyXMBjivWPXQ5CUE0HDc1dRbLaZYOKY BxXw50eAQgSRSTQ7ePnQPyXCKvYAlFcNZ3SQ6pgwqdpfVP7+nhLYaOvgheq0lrdxWlWB 3bBhDAN6CcQfyLsrTyRTzGqroPXLKVttcyRR7ITwmfGoVYHHNY4Xpa/Dj/oY2lcBFm/W hDMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=6++MUHqyHKCB5FgpZ/mPI8mWFFcZJMAIOAPJiYxj2J8=; b=ERJX/75kKs3OXFuMoBQArozyp00ttGTFw0BMfJ0kfqJejgZoYA6iNEj/wfFwEy094J 7tiMQmD2etmmTqKza3+G1zMs4SCnA2iK9TWeJEOo/Ha0TT0KZ6NN5l4BjUw5Y1A2LXGb piy7cj1Aub+/Rk5hHdH317fyTa99EZSa6lIJcrV0YiosYwaUPfGZHbDykQD0sW81oIb6 1mYAyU27CPzJHXwjKspcACO1Oavh9UsVwcZgjy3HfohiBGwQ3xYh8PxqaHjVkRi6i2VI E5kuEgFRftZKXchJ3GNjLlNnU/HEX9tphuQ0+qqNKl0aNSUJ3uquqIvRJF+JrWweuARU xLhg== X-Gm-Message-State: AOAM533vtN+BQ8PiOssBFdw35chAjs1X7zDGN3nvokkL1D0C3GhBlHSZ XtCpnz0sPl+MRZm5MmdFb0bh+Q== X-Google-Smtp-Source: ABdhPJzgg07OWjq2bQtnbrD/FW+0dCRqz+/2tJpzVzU6KzTpUZG3HRY1sfxYtkNoWAuSpFfjZ/hUlw== X-Received: by 2002:a05:6a00:1a10:b0:412:448c:89ca with SMTP id g16-20020a056a001a1000b00412448c89camr811832pfv.86.1631557289837; Mon, 13 Sep 2021 11:21:29 -0700 (PDT) Received: from google.com (157.214.185.35.bc.googleusercontent.com. [35.185.214.157]) by smtp.gmail.com with ESMTPSA id x13sm4547221pfp.133.2021.09.13.11.21.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Sep 2021 11:21:29 -0700 (PDT) Date: Mon, 13 Sep 2021 18:21:25 +0000 From: Sean Christopherson To: Eduardo Habkost Cc: Juergen Gross , kvm@vger.kernel.org, x86@kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, kvm-ppc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kselftest@vger.kernel.org, Paolo Bonzini , Jonathan Corbet , Huacai Chen , Aleksandar Markovic , Thomas Bogendoerfer , Paul Mackerras , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Shuah Khan , Shuah Khan Subject: Re: [PATCH 2/2] kvm: rename KVM_MAX_VCPU_ID to KVM_MAX_VCPU_IDS Message-ID: References: <20210913135745.13944-1-jgross@suse.com> <20210913135745.13944-3-jgross@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org On Mon, Sep 13, 2021, Eduardo Habkost wrote: > On Mon, Sep 13, 2021 at 12:24 PM Sean Christopherson wrote: > > > > On Mon, Sep 13, 2021, Juergen Gross wrote: > > > KVM_MAX_VCPU_ID is not specifying the highest allowed vcpu-id, but the > > > number of allowed vcpu-ids. This has already led to confusion, so > > > rename KVM_MAX_VCPU_ID to KVM_MAX_VCPU_IDS to make its semantics more > > > clear > > > > My hesitation with this rename is that the max _number_ of IDs is not the same > > thing as the max allowed ID. E.g. on x86, given a capability that enumerates the > > max number of IDs, I would expect to be able to create vCPUs with arbitrary 32-bit > > x2APIC IDs so long as the total number of IDs is below the max. > > > > What name would you suggest instead? KVM_VCPU_ID_LIMIT, maybe? > > I'm assuming we are not going to redefine KVM_MAX_VCPU_ID to be an > inclusive limit. Heh, I haven't been able to come up with one, which is why I suggested the route of making it an inclusive value internally within KVM.