linux-mips.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: WANG Xuerui <git@xen0n.name>
Cc: linux-rtc@vger.kernel.org, Huacai Chen <chenhuacai@kernel.org>,
	Jiaxun Yang <jiaxun.yang@flygoat.com>,
	devicetree@vger.kernel.org, linux-mips@vger.kernel.org
Subject: Re: [PATCH RESEND v5 1/6] rtc: ls2x: Add support for the Loongson-2K/LS7A RTC
Date: Mon, 27 Sep 2021 13:16:36 +0200	[thread overview]
Message-ID: <YVGoFMLehLhsaoBK@piout.net> (raw)
In-Reply-To: <20210823163142.586529-2-git@xen0n.name>

On 24/08/2021 00:31:37+0800, WANG Xuerui wrote:
> +
> +static struct rtc_class_ops ls2x_rtc_ops = {

I forgot to add that this should be const

> +	.read_time = ls2x_rtc_read_time,
> +	.set_time = ls2x_rtc_set_time,
> +};
> +

-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  parent reply	other threads:[~2021-09-27 11:16 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-23 16:31 [PATCH RESEND v5 0/6] rtc: ls2x: Add support for the Loongson-2K/LS7A RTC WANG Xuerui
2021-08-23 16:31 ` [PATCH RESEND v5 1/6] " WANG Xuerui
2021-08-31  0:33   ` Nobuhiro Iwamatsu
2021-09-25 22:14   ` Alexandre Belloni
2021-09-27 11:16   ` Alexandre Belloni [this message]
2021-08-23 16:31 ` [PATCH RESEND v5 2/6] dt-bindings: rtc: Add bindings for LS2X RTC WANG Xuerui
2021-08-23 16:31 ` [PATCH RESEND v5 3/6] MIPS: Loongson64: DTS: Add RTC support to LS7A WANG Xuerui
2021-08-23 16:31 ` [PATCH RESEND v5 4/6] MIPS: Loongson: Enable LS2X RTC in loongson3_defconfig WANG Xuerui
2021-08-23 16:31 ` [PATCH RESEND v5 5/6] MIPS: Loongson64: DTS: Add RTC support to Loongson-2K WANG Xuerui
2021-08-23 16:31 ` [PATCH RESEND v5 6/6] MIPS: Loongson: Enable LS2X RTC in loongson2k_defconfig WANG Xuerui

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YVGoFMLehLhsaoBK@piout.net \
    --to=alexandre.belloni@bootlin.com \
    --cc=chenhuacai@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=git@xen0n.name \
    --cc=jiaxun.yang@flygoat.com \
    --cc=linux-mips@vger.kernel.org \
    --cc=linux-rtc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).