From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4414C433EF for ; Wed, 27 Oct 2021 15:28:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8215460E0B for ; Wed, 27 Oct 2021 15:28:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237611AbhJ0PbC (ORCPT ); Wed, 27 Oct 2021 11:31:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57932 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237820AbhJ0PbB (ORCPT ); Wed, 27 Oct 2021 11:31:01 -0400 Received: from mail-pf1-x430.google.com (mail-pf1-x430.google.com [IPv6:2607:f8b0:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F1062C0613B9 for ; Wed, 27 Oct 2021 08:28:35 -0700 (PDT) Received: by mail-pf1-x430.google.com with SMTP id y7so3045511pfg.8 for ; Wed, 27 Oct 2021 08:28:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=jluBW5yA9LvugmQi8oyfDy8/cabbakiUXPqo4utsaB8=; b=IXIkAF60iwH8Ca28unKtkkjCxMxH4jsRE7rdlyRpHRKxqRH5DKvzKzXeE1xZpeP67E xwOJxCxtNAW/vuRZ9/cA++xLC0bu82EJesdjjIouYVg3x2VESqFJeksK7bKKBVif038n GNlri9Hc+F1u7CW4lPLn9JPRn52da4aBC4xsr93HTbSLq1yGzKbznkaiM+WfpWPTb1nX 8Hjyo7QQx66GQF0REMEMDncs7WF5cqEgNENljeKIdAyawTn2njGp/q6Q7uPOzyYDFpEX mqf5isD4pvLAp694w88H9zUwbgY74QXFwiejeE2dZlhZt757K0HlOnfUIVAivKet6eGr 4Dpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=jluBW5yA9LvugmQi8oyfDy8/cabbakiUXPqo4utsaB8=; b=mCVsOzIz7LUKXcyXtPDneGik040ligrx80WAj6Qgjom/HbnTUHCLwSQozf8ihEpGEl 1EDVfcGaQG/eJAoqd/VGOnUVliE2tYSR3zRsjqXJOlQD17ArywdcnxvdWkxDjF6xAw98 ZMNPbMxmF3xWk0TCTxAviF8JUxnAOap+hdMTNzN+brH7PZfpuRObZ4rWgp0D935UEzjM pKWNMc20u7yylFaJvtMYC6b974H39XypqEOKHpVn0YmumWS7A4XPCQKKsrrYOCIP2Lsx UHF9kO1ihPEdfvaL3Q3mQ7cDMuIIC5BcaLg532eaMnRt7kuEFyy6sBSQYNXkYROaMP+c +UvQ== X-Gm-Message-State: AOAM530/kMYCW3yJ7Wlvl28FK9+h3yOwplL8PBLTSyo1AzEZmq+Aa0Sc nahF7i9vGUortGmXJE4iMkBdag== X-Google-Smtp-Source: ABdhPJxibfpJFn220g32tVsxXXYwD2JThHpi8b5HJLrZMbbjn5Hu0UDQk4ZV4kEcRQbC7q9gao3DeQ== X-Received: by 2002:a05:6a00:2405:b0:44c:1ec3:8dbe with SMTP id z5-20020a056a00240500b0044c1ec38dbemr33619608pfh.33.1635348515143; Wed, 27 Oct 2021 08:28:35 -0700 (PDT) Received: from google.com (157.214.185.35.bc.googleusercontent.com. [35.185.214.157]) by smtp.gmail.com with ESMTPSA id y19sm340714pfn.23.2021.10.27.08.28.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Oct 2021 08:28:34 -0700 (PDT) Date: Wed, 27 Oct 2021 15:28:31 +0000 From: Sean Christopherson To: Paolo Bonzini Cc: Marc Zyngier , Huacai Chen , Aleksandar Markovic , Paul Mackerras , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Christian Borntraeger , Janosch Frank , James Morse , Alexandru Elisei , Suzuki K Poulose , Atish Patra , David Hildenbrand , Cornelia Huck , Claudio Imbrenda , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-mips@vger.kernel.org, kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, David Matlack , Oliver Upton , Jing Zhang Subject: Re: [PATCH v2 00/43] KVM: Halt-polling and x86 APICv overhaul Message-ID: References: <20211009021236.4122790-1-seanjc@google.com> <614858dd-106c-64cc-04bc-f1887b2054d1@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org On Wed, Oct 27, 2021, Paolo Bonzini wrote: > On 27/10/21 16:41, Sean Christopherson wrote: > > The other thing I don't like about having the WARN in the loop is that it suggests > > that something other than the vCPU can modify the NDST and SN fields, which is > > wrong and confusing (for me). > > Yeah, I can agree with that. Can you add it in a comment above the cmpxchg > loop, it can be as simple as > > /* The processor can set ON concurrently. */ > > when you respin patch 21 and the rest of the series? I can definitely add a comment, but I think that comment is incorrect. AIUI, the CPU is the one thing in the system that _doesn't_ set ON, at least not without IPI virtualization (haven't read that spec yet). KVM (software) sets it when emulating IPIs, and the IOMMU (hardware) sets it for "real" posted interrupts, but the CPU (sans IPI virtualization) only clears ON when processing an IRQ on the notification vector. So something like this? /* ON can be set concurrently by a different vCPU or by hardware. */