* [PATCH v2] MIPS: Makefile: Remove "ifdef need-compiler" for Kbuild.platforms
@ 2021-12-10 4:05 Tiezhu Yang
2021-12-10 16:22 ` Nathan Chancellor
0 siblings, 1 reply; 5+ messages in thread
From: Tiezhu Yang @ 2021-12-10 4:05 UTC (permalink / raw)
To: Thomas Bogendoerfer
Cc: Jason Self, Masahiro Yamada, Ryutaroh Matsumoto,
Nathan Chancellor, linux-mips, linux-kernel
After commit 13ceb48bc19c ("MIPS: Loongson2ef: Remove unnecessary
{as,cc}-option calls"), no need to use "ifdef need-compiler" for
Kbuild.platforms, because the cause of the build issue mentioned
in commit 0706f74f719e ("MIPS: fix *-pkg builds for loongson2ef
platform") has been disappeared, so just remove it.
Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
---
v2: fix the typo "casue" --> "cause" in the commit message,
sorry for that.
arch/mips/Makefile | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/mips/Makefile b/arch/mips/Makefile
index ace7f03..e036fc0 100644
--- a/arch/mips/Makefile
+++ b/arch/mips/Makefile
@@ -253,9 +253,7 @@ endif
#
# Board-dependent options and extra files
#
-ifdef need-compiler
include $(srctree)/arch/mips/Kbuild.platforms
-endif
ifdef CONFIG_PHYSICAL_START
load-y = $(CONFIG_PHYSICAL_START)
--
2.1.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH v2] MIPS: Makefile: Remove "ifdef need-compiler" for Kbuild.platforms
2021-12-10 4:05 [PATCH v2] MIPS: Makefile: Remove "ifdef need-compiler" for Kbuild.platforms Tiezhu Yang
@ 2021-12-10 16:22 ` Nathan Chancellor
2021-12-10 16:39 ` Masahiro Yamada
0 siblings, 1 reply; 5+ messages in thread
From: Nathan Chancellor @ 2021-12-10 16:22 UTC (permalink / raw)
To: Tiezhu Yang
Cc: Thomas Bogendoerfer, Jason Self, Masahiro Yamada,
Ryutaroh Matsumoto, linux-mips, linux-kernel
On Fri, Dec 10, 2021 at 12:05:05PM +0800, Tiezhu Yang wrote:
> After commit 13ceb48bc19c ("MIPS: Loongson2ef: Remove unnecessary
> {as,cc}-option calls"), no need to use "ifdef need-compiler" for
> Kbuild.platforms, because the cause of the build issue mentioned
> in commit 0706f74f719e ("MIPS: fix *-pkg builds for loongson2ef
> platform") has been disappeared, so just remove it.
>
> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
Reviewed-by: Nathan Chancellor <nathan@kernel.org>
> ---
>
> v2: fix the typo "casue" --> "cause" in the commit message,
> sorry for that.
>
> arch/mips/Makefile | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/mips/Makefile b/arch/mips/Makefile
> index ace7f03..e036fc0 100644
> --- a/arch/mips/Makefile
> +++ b/arch/mips/Makefile
> @@ -253,9 +253,7 @@ endif
> #
> # Board-dependent options and extra files
> #
> -ifdef need-compiler
> include $(srctree)/arch/mips/Kbuild.platforms
> -endif
>
> ifdef CONFIG_PHYSICAL_START
> load-y = $(CONFIG_PHYSICAL_START)
> --
> 2.1.0
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v2] MIPS: Makefile: Remove "ifdef need-compiler" for Kbuild.platforms
2021-12-10 16:22 ` Nathan Chancellor
@ 2021-12-10 16:39 ` Masahiro Yamada
2021-12-13 0:35 ` Ryutaroh Matsumoto
0 siblings, 1 reply; 5+ messages in thread
From: Masahiro Yamada @ 2021-12-10 16:39 UTC (permalink / raw)
To: Nathan Chancellor
Cc: Tiezhu Yang, Thomas Bogendoerfer, Jason Self, Ryutaroh Matsumoto,
open list:BROADCOM NVRAM DRIVER, Linux Kernel Mailing List
On Sat, Dec 11, 2021 at 1:22 AM Nathan Chancellor <nathan@kernel.org> wrote:
>
> On Fri, Dec 10, 2021 at 12:05:05PM +0800, Tiezhu Yang wrote:
> > After commit 13ceb48bc19c ("MIPS: Loongson2ef: Remove unnecessary
> > {as,cc}-option calls"), no need to use "ifdef need-compiler" for
> > Kbuild.platforms, because the cause of the build issue mentioned
> > in commit 0706f74f719e ("MIPS: fix *-pkg builds for loongson2ef
> > platform") has been disappeared, so just remove it.
> >
> > Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
>
> Reviewed-by: Nathan Chancellor <nathan@kernel.org>
>
> > ---
> >
> > v2: fix the typo "casue" --> "cause" in the commit message,
> > sorry for that.
> >
> > arch/mips/Makefile | 2 --
> > 1 file changed, 2 deletions(-)
> >
> > diff --git a/arch/mips/Makefile b/arch/mips/Makefile
> > index ace7f03..e036fc0 100644
> > --- a/arch/mips/Makefile
> > +++ b/arch/mips/Makefile
> > @@ -253,9 +253,7 @@ endif
> > #
> > # Board-dependent options and extra files
> > #
> > -ifdef need-compiler
> > include $(srctree)/arch/mips/Kbuild.platforms
> > -endif
> >
> > ifdef CONFIG_PHYSICAL_START
> > load-y = $(CONFIG_PHYSICAL_START)
> > --
> > 2.1.0
> >
Nathan's patch cleaned up arch/mips/loognson2ef/Platform,
but I still see similar code in arch/mips/sgi-ip22/Platform.
ifdef CONFIG_SGI_IP28
ifeq ($(call cc-option-yn,-march=r10000 -mr10k-cache-barrier=store), n)
$(error gcc doesn't support needed option -mr10k-cache-barrier=store)
endif
endif
Doesn't this cause a failure of *-pkg builds for sgi-ip22 platform?
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v2] MIPS: Makefile: Remove "ifdef need-compiler" for Kbuild.platforms
2021-12-10 16:39 ` Masahiro Yamada
@ 2021-12-13 0:35 ` Ryutaroh Matsumoto
2021-12-13 2:09 ` Nathan Chancellor
0 siblings, 1 reply; 5+ messages in thread
From: Ryutaroh Matsumoto @ 2021-12-13 0:35 UTC (permalink / raw)
To: masahiroy; +Cc: nathan, yangtiezhu, tsbogend, jason, linux-mips, linux-kernel
From: Masahiro Yamada <masahiroy@kernel.org>
Subject: Re: [PATCH v2] MIPS: Makefile: Remove "ifdef need-compiler" for Kbuild.platforms
Date: Sat, 11 Dec 2021 01:39:10 +0900
> Nathan's patch cleaned up arch/mips/loognson2ef/Platform,
> but I still see similar code in arch/mips/sgi-ip22/Platform.
>
>
> ifdef CONFIG_SGI_IP28
> ifeq ($(call cc-option-yn,-march=r10000 -mr10k-cache-barrier=store), n)
> $(error gcc doesn't support needed option -mr10k-cache-barrier=store)
> endif
> endif
>
>
> Doesn't this cause a failure of *-pkg builds for sgi-ip22 platform?
Yes, it does, as reported at
https://github.com/ClangBuiltLinux/linux/issues/1543
Best regards, Ryutaroh Matsumo
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] MIPS: Makefile: Remove "ifdef need-compiler" for Kbuild.platforms
2021-12-13 0:35 ` Ryutaroh Matsumoto
@ 2021-12-13 2:09 ` Nathan Chancellor
0 siblings, 0 replies; 5+ messages in thread
From: Nathan Chancellor @ 2021-12-13 2:09 UTC (permalink / raw)
To: Ryutaroh Matsumoto
Cc: masahiroy, yangtiezhu, tsbogend, jason, linux-mips, linux-kernel
On Mon, Dec 13, 2021 at 09:35:20AM +0900, Ryutaroh Matsumoto wrote:
> From: Masahiro Yamada <masahiroy@kernel.org>
> Subject: Re: [PATCH v2] MIPS: Makefile: Remove "ifdef need-compiler" for Kbuild.platforms
> Date: Sat, 11 Dec 2021 01:39:10 +0900
> > Nathan's patch cleaned up arch/mips/loognson2ef/Platform,
> > but I still see similar code in arch/mips/sgi-ip22/Platform.
> >
> >
> > ifdef CONFIG_SGI_IP28
> > ifeq ($(call cc-option-yn,-march=r10000 -mr10k-cache-barrier=store), n)
> > $(error gcc doesn't support needed option -mr10k-cache-barrier=store)
> > endif
> > endif
> >
> >
> > Doesn't this cause a failure of *-pkg builds for sgi-ip22 platform?
>
> Yes, it does, as reported at
> https://github.com/ClangBuiltLinux/linux/issues/1543
It seems like that section can be removed for the same reason as my
patch (that flag is supported with GCC 5.1.0) then this patch can be
applied without any issues.
Cheers,
Nathan
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-12-13 2:09 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-12-10 4:05 [PATCH v2] MIPS: Makefile: Remove "ifdef need-compiler" for Kbuild.platforms Tiezhu Yang
2021-12-10 16:22 ` Nathan Chancellor
2021-12-10 16:39 ` Masahiro Yamada
2021-12-13 0:35 ` Ryutaroh Matsumoto
2021-12-13 2:09 ` Nathan Chancellor
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).