From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB743C433F5 for ; Mon, 10 Jan 2022 16:30:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237492AbiAJQae (ORCPT ); Mon, 10 Jan 2022 11:30:34 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34226 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237471AbiAJQad (ORCPT ); Mon, 10 Jan 2022 11:30:33 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7CC4FC06173F; Mon, 10 Jan 2022 08:30:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=FcxY0AcFPqarLpf7v6qBIQEnVP2lYCe9YcoGjVtbp+8=; b=SL36wzarhDHVddRltdQMBE23mc IYPjRqt9vGY0hJ+O+Pt3NEqD67mWrggl+Kcy1i5E2WG+1iqDNtWzO3HC/XwfYRx7bn+A8vl1wAMlR jJF/C/E/+CmlYA+C8nThER7ESllKofjjGS3LhOQJ3lUtfXVXooRzugIYkVM6c8vMbLTs0Ib0wiuOq R+qMAkH4rOmFnEGrUA+gCI23C1IzFu9o1LHaapJtTqjl/mUj8SztpVPqoLTuBjDAwLZWdKHpclSEJ jd3tIyorl/yiIgBq0aTkeP40xm5NyR+Igcsmef/uUBVA1QoP7zKSzRdVQ2wnbCjie1Fv69PYUgreC QBcFRXOw==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1n6xYm-00CMnJ-8F; Mon, 10 Jan 2022 16:30:16 +0000 Date: Mon, 10 Jan 2022 08:30:16 -0800 From: Christoph Hellwig To: Arnd Bergmann Cc: Guo Ren , Palmer Dabbelt , Anup Patel , gregkh , liush , Wei Fu , Drew Fustini , Wang Junqiang , Christoph Hellwig , Linux Kernel Mailing List , linux-riscv , linux-csky@vger.kernel.org, linux-s390 , sparclinux , linuxppc-dev , inux-parisc@vger.kernel.org, "open list:BROADCOM NVRAM DRIVER" , Linux ARM , the arch/x86 maintainers , Guo Ren , Jeff Layton , "J. Bruce Fields" , Linux FS-devel Mailing List Subject: Re: [PATCH V2 03/17] asm-generic: fcntl: compat: Remove duplicate definitions Message-ID: References: <20211228143958.3409187-1-guoren@kernel.org> <20211228143958.3409187-4-guoren@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org On Mon, Jan 10, 2022 at 02:35:19PM +0100, Arnd Bergmann wrote: > > +#if !defined(CONFIG_64BIT) || defined(CONFIG_COMPAT) > > #ifndef F_GETLK64 > > #define F_GETLK64 12 /* using 'struct flock64' */ > > #define F_SETLK64 13 > > The problem here is that include/uapi/ headers cannot contain checks for > CONFIG_* symbols because those may have different meanings in user space > compared to kernel. > > This is a preexisting problem in the header, but I think the change > makes it worse. FYI, this is what I did in my old branch, which also sidesteps the duplicate value problem on parisc. The rebase is untested so far, but I can spend some cycles on finishing it: http://git.infradead.org/users/hch/misc.git/shortlog/refs/heads/fcntl-asm-generic-cleanup