* [PATCH 2/4] clk: loongson1: Terminate clk_div_table with sentinel element [not found] <20220128230922.2047140-1-j.neuschaefer@gmx.net> @ 2022-01-28 23:09 ` Jonathan Neuschäfer 2022-02-01 13:57 ` Philippe Mathieu-Daudé 0 siblings, 1 reply; 3+ messages in thread From: Jonathan Neuschäfer @ 2022-01-28 23:09 UTC (permalink / raw) To: linux-clk Cc: linux-kernel, Jonathan Neuschäfer, Keguang Zhang, Michael Turquette, Stephen Boyd, linux-mips In order that the end of a clk_div_table can be detected, it must be terminated with a sentinel element (.div = 0). Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net> --- drivers/clk/loongson1/clk-loongson1c.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/clk/loongson1/clk-loongson1c.c b/drivers/clk/loongson1/clk-loongson1c.c index 703f87622cf5f..6b29ae9ede3e5 100644 --- a/drivers/clk/loongson1/clk-loongson1c.c +++ b/drivers/clk/loongson1/clk-loongson1c.c @@ -37,6 +37,7 @@ static const struct clk_div_table ahb_div_table[] = { [1] = { .val = 1, .div = 4 }, [2] = { .val = 2, .div = 3 }, [3] = { .val = 3, .div = 3 }, + [4] = { .val = 0, .div = 0 }, }; void __init ls1x_clk_init(void) -- 2.34.1 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 2/4] clk: loongson1: Terminate clk_div_table with sentinel element 2022-01-28 23:09 ` [PATCH 2/4] clk: loongson1: Terminate clk_div_table with sentinel element Jonathan Neuschäfer @ 2022-02-01 13:57 ` Philippe Mathieu-Daudé 2022-02-01 19:43 ` Jonathan Neuschäfer 0 siblings, 1 reply; 3+ messages in thread From: Philippe Mathieu-Daudé @ 2022-02-01 13:57 UTC (permalink / raw) To: Jonathan Neuschäfer Cc: linux-clk, open list, Keguang Zhang, Michael Turquette, Stephen Boyd, open list:BROADCOM NVRAM DRIVER On Mon, Jan 31, 2022 at 12:48 PM Jonathan Neuschäfer <j.neuschaefer@gmx.net> wrote: > > In order that the end of a clk_div_table can be detected, it must be > terminated with a sentinel element (.div = 0). > > Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net> > --- > drivers/clk/loongson1/clk-loongson1c.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/clk/loongson1/clk-loongson1c.c b/drivers/clk/loongson1/clk-loongson1c.c > index 703f87622cf5f..6b29ae9ede3e5 100644 > --- a/drivers/clk/loongson1/clk-loongson1c.c > +++ b/drivers/clk/loongson1/clk-loongson1c.c > @@ -37,6 +37,7 @@ static const struct clk_div_table ahb_div_table[] = { > [1] = { .val = 1, .div = 4 }, > [2] = { .val = 2, .div = 3 }, > [3] = { .val = 3, .div = 3 }, > + [4] = { .val = 0, .div = 0 }, Easier to review when self-explicit: [4] = { /* sentinel */ } Preferably updated: Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org> And eventually: Fixes: b4626a7f4892 ("CLK: Add Loongson1C clock support") > }; > > void __init ls1x_clk_init(void) > -- > 2.34.1 > ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 2/4] clk: loongson1: Terminate clk_div_table with sentinel element 2022-02-01 13:57 ` Philippe Mathieu-Daudé @ 2022-02-01 19:43 ` Jonathan Neuschäfer 0 siblings, 0 replies; 3+ messages in thread From: Jonathan Neuschäfer @ 2022-02-01 19:43 UTC (permalink / raw) To: Philippe Mathieu-Daudé Cc: Jonathan Neuschäfer, linux-clk, open list, Keguang Zhang, Michael Turquette, Stephen Boyd, open list:BROADCOM NVRAM DRIVER [-- Attachment #1: Type: text/plain, Size: 1294 bytes --] On Tue, Feb 01, 2022 at 02:57:03PM +0100, Philippe Mathieu-Daudé wrote: > On Mon, Jan 31, 2022 at 12:48 PM Jonathan Neuschäfer > <j.neuschaefer@gmx.net> wrote: > > > > In order that the end of a clk_div_table can be detected, it must be > > terminated with a sentinel element (.div = 0). > > > > Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net> > > --- > > drivers/clk/loongson1/clk-loongson1c.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/clk/loongson1/clk-loongson1c.c b/drivers/clk/loongson1/clk-loongson1c.c > > index 703f87622cf5f..6b29ae9ede3e5 100644 > > --- a/drivers/clk/loongson1/clk-loongson1c.c > > +++ b/drivers/clk/loongson1/clk-loongson1c.c > > @@ -37,6 +37,7 @@ static const struct clk_div_table ahb_div_table[] = { > > [1] = { .val = 1, .div = 4 }, > > [2] = { .val = 2, .div = 3 }, > > [3] = { .val = 3, .div = 3 }, > > + [4] = { .val = 0, .div = 0 }, > > Easier to review when self-explicit: > > [4] = { /* sentinel */ } > > Preferably updated: > Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > > And eventually: > Fixes: b4626a7f4892 ("CLK: Add Loongson1C clock support") All good suggestions, I'll incorporate them into v2. Thanks, Jonathan [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-02-01 19:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20220128230922.2047140-1-j.neuschaefer@gmx.net>
2022-01-28 23:09 ` [PATCH 2/4] clk: loongson1: Terminate clk_div_table with sentinel element Jonathan Neuschäfer
2022-02-01 13:57 ` Philippe Mathieu-Daudé
2022-02-01 19:43 ` Jonathan Neuschäfer
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).