Re: [PATCH v2 10/26] KVM: x86/mmu: Use common code to free kvm_mmu_page structs

David Matlack
2022-03-22T22:33:50Z

On Tue, Mar 15, 2022 at 3:23 AM Peter Xu <peterx@redhat.com> wrote:
>
> On Fri, Mar 11, 2022 at 12:25:12AM +0000, David Matlack wrote:
> > static void tdp_mmu_free_sp(struct kvm_mmu_page *sp)
> > {
> > - free_page((unsigned long)sp->spt);
> > - kmem_cache_free(mmu_page_header_cache, sp);
> > + kvm_mmu_free_shadow_page(sp);
> > }
>
> Perhaps tdp_mmu_free_sp() can be dropped altogether with this?

It certainly can but I prefer to keep it for 2 reasons:
- Smaller diff.
- It mirrors tdp_mmu_alloc_sp(), which I prefer to keep as well but
I'll explain that in the next patch.

>
> Reviewed-by: Peter Xu <peterx@redhat.com>
>
> --
> Peter Xu
>