From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C9FCC433EF for ; Tue, 15 Mar 2022 10:39:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347116AbiCOKkh (ORCPT ); Tue, 15 Mar 2022 06:40:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49286 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233588AbiCOKkg (ORCPT ); Tue, 15 Mar 2022 06:40:36 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 9EB36506D2 for ; Tue, 15 Mar 2022 03:39:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1647340763; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=kJDd/9JiDZbTHZohyZFbEtBTCygNnRdmmrmfy8MFg0M=; b=SNrc0B7LfQET7HJElrLhlhklWn3/m126GaZV1xU2K1WinqUGy2QgUbrj2rYoqtg86TzXjW YFjOGiSXRwwpw1YAJS2cdJh79LrXai3wFKUZ3HFlB6KAVbx1lM1MJNPBQTKwnl+GYKVrqK rEPPDitgjWmsZbmERBL0Bo1YH+iqWYA= Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-352-iucauFItO-eXdPo4Yai4pA-1; Tue, 15 Mar 2022 06:39:22 -0400 X-MC-Unique: iucauFItO-eXdPo4Yai4pA-1 Received: by mail-pj1-f71.google.com with SMTP id cp14-20020a17090afb8e00b001c6018fe017so1767049pjb.4 for ; Tue, 15 Mar 2022 03:39:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=kJDd/9JiDZbTHZohyZFbEtBTCygNnRdmmrmfy8MFg0M=; b=STksw5LxrphDVZzEv9JjiqUtznLMIjB9CZuC2do00y8jeQU1/1u2j0PgTl+ALdPUlm vhKhN5SNxZmKRwXEG3SVIKypEFzx8DqzSX7PXj2BqEmdpeMDLUpTHwh4nhlERCGP5/sU KAyKc6LJ229nzUjvLJfbooZZ718vwz3a9JNjIMA8si1SaJrpNZazyGIgI5Rduc/wuk+y lDUL/3gWgO8AGQqv2zP5HT28KyH5SdoCteJR9L6E1wxFOO7Q5ZixoE1mT5q9f1f4p7f3 CGg2ZxuBHyoVZRWDIfvtckeIHJWWy9PoJBv9a5Qbdk0++4e64f6ENX2C97lSlY7caB3Z rCCQ== X-Gm-Message-State: AOAM530V4ShPiLvXhxljA6dzVDanwZNYYlGfoNFwkBXwwlxTZ/S4DcX2 X9axNIsgVkG4QfA52cA8Q5Dl7zgw/F24Ji3vTMSUZk3fPPiM0ArMky6AmrhB7PCJ1Iv76FJP1Nj e5EdeIZv//gfHICsUSZocvQ== X-Received: by 2002:a05:6a00:140f:b0:4e0:6995:9c48 with SMTP id l15-20020a056a00140f00b004e069959c48mr27468837pfu.59.1647340760977; Tue, 15 Mar 2022 03:39:20 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwSfNOcUi9xy2ekJmnOxedBPrTrKX0N/yrTIaL/Gy94SQN4Gb5kFP9OF6Ce9WSip5I+m8Q7zA== X-Received: by 2002:a05:6a00:140f:b0:4e0:6995:9c48 with SMTP id l15-20020a056a00140f00b004e069959c48mr27468818pfu.59.1647340760732; Tue, 15 Mar 2022 03:39:20 -0700 (PDT) Received: from xz-m1.local ([191.101.132.43]) by smtp.gmail.com with ESMTPSA id q2-20020a056a00150200b004f8d80ced3csm4351131pfu.40.2022.03.15.03.39.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Mar 2022 03:39:20 -0700 (PDT) Date: Tue, 15 Mar 2022 18:39:11 +0800 From: Peter Xu To: David Matlack Cc: Paolo Bonzini , Marc Zyngier , Huacai Chen , Aleksandar Markovic , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Sean Christopherson , Andrew Jones , Ben Gardon , maciej.szmigiero@oracle.com, "moderated list:KERNEL VIRTUAL MACHINE FOR ARM64 (KVM/arm64)" , "open list:KERNEL VIRTUAL MACHINE FOR MIPS (KVM/mips)" , "open list:KERNEL VIRTUAL MACHINE FOR MIPS (KVM/mips)" , "open list:KERNEL VIRTUAL MACHINE FOR RISC-V (KVM/riscv)" , Peter Feiner Subject: Re: [PATCH v2 15/26] KVM: x86/mmu: Update page stats in __rmap_add() Message-ID: References: <20220311002528.2230172-1-dmatlack@google.com> <20220311002528.2230172-16-dmatlack@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220311002528.2230172-16-dmatlack@google.com> Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org On Fri, Mar 11, 2022 at 12:25:17AM +0000, David Matlack wrote: > Update the page stats in __rmap_add() rather than at the call site. This > will avoid having to manually update page stats when splitting huge > pages in a subsequent commit. > > No functional change intended. > > Reviewed-by: Ben Gardon > Signed-off-by: David Matlack Reviewed-by: Peter Xu -- Peter Xu