[PATCH v2 1/2] dt-bindings: timer: Add PWM compatible for X1000 SoC

[PATCH v2 1/2] dt-bindings: timer: Add PWM compatible for X1000 SoC

[Aidan MacDonald]

The PWM hardware on the X1000 SoC is almost identical to other
Ingenic SoCs, so it can be used with only minor driver changes.

Signed-off-by: Aidan MacDonald <aidanmacdonald.0x0@gmail.com>
---
It seems Thierry picked up the driver patch separately (thanks for
that) so here's the DTS changes on their own. Would've uploaded a
v2 sooner but I was busy the past couple weeks and couldn't spend
any time on kernel stuff. I guess this isn't a v2 per se, but for
completeness:

v1: https://lore.kernel.org/linux-mips/20220209231141.20184-1-aidanmacdonald.0x0@gmail.com/

 Documentation/devicetree/bindings/timer/ingenic,tcu.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/timer/ingenic,tcu.yaml b/Documentation/devicetree/bindings/timer/ingenic,tcu.yaml
index 7fb37eae9da7..d541cf2067bc 100644
--- a/Documentation/devicetree/bindings/timer/ingenic,tcu.yaml
+++ b/Documentation/devicetree/bindings/timer/ingenic,tcu.yaml
@@ -152,6 +152,7 @@ patternProperties:
           - enum:
               - ingenic,jz4740-pwm
               - ingenic,jz4725b-pwm
+              - ingenic,x1000-pwm
           - items:
               - enum:
                   - ingenic,jz4760-pwm
-- 
2.34.1

[PATCH v2 2/2] mips: dts: ingenic: x1000: Add PWM device tree node

[Aidan MacDonald]

Copied from the jz4740 devicetree and trimmed to 5 timers, which
is what the hardware supports.

Signed-off-by: Aidan MacDonald <aidanmacdonald.0x0@gmail.com>
---
 arch/mips/boot/dts/ingenic/x1000.dtsi | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/arch/mips/boot/dts/ingenic/x1000.dtsi b/arch/mips/boot/dts/ingenic/x1000.dtsi
index 8bd27edef216..0dcf37527c8e 100644
--- a/arch/mips/boot/dts/ingenic/x1000.dtsi
+++ b/arch/mips/boot/dts/ingenic/x1000.dtsi
@@ -127,6 +127,19 @@ wdt: watchdog@0 {
 			clocks = <&tcu TCU_CLK_WDT>;
 			clock-names = "wdt";
 		};
+
+		pwm: pwm@40 {
+			compatible = "ingenic,x1000-pwm";
+			reg = <0x40 0x80>;
+
+			#pwm-cells = <3>;
+
+			clocks = <&tcu TCU_CLK_TIMER0>, <&tcu TCU_CLK_TIMER1>,
+				 <&tcu TCU_CLK_TIMER2>, <&tcu TCU_CLK_TIMER3>,
+				 <&tcu TCU_CLK_TIMER4>;
+			clock-names = "timer0", "timer1", "timer2",
+				      "timer3", "timer4";
+		};
 	};
 
 	rtc: rtc@10003000 {
-- 
2.34.1

Re: [PATCH v2 1/2] dt-bindings: timer: Add PWM compatible for X1000 SoC

[Thierry Reding]

[-- Attachment #1: Type: text/plain, Size: 887 bytes --]

On Thu, Feb 24, 2022 at 11:41:33PM +0000, Aidan MacDonald wrote:
> The PWM hardware on the X1000 SoC is almost identical to other
> Ingenic SoCs, so it can be used with only minor driver changes.
> 
> Signed-off-by: Aidan MacDonald <aidanmacdonald.0x0@gmail.com>
> ---
> It seems Thierry picked up the driver patch separately (thanks for
> that) so here's the DTS changes on their own. Would've uploaded a
> v2 sooner but I was busy the past couple weeks and couldn't spend
> any time on kernel stuff. I guess this isn't a v2 per se, but for
> completeness:
> 
> v1: https://lore.kernel.org/linux-mips/20220209231141.20184-1-aidanmacdonald.0x0@gmail.com/
> 
>  Documentation/devicetree/bindings/timer/ingenic,tcu.yaml | 1 +
>  1 file changed, 1 insertion(+)

Looks like I also somehow ended up applying this snippet, though
possibly from the earlier patch.

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH v2 2/2] mips: dts: ingenic: x1000: Add PWM device tree node

[Thierry Reding]

[-- Attachment #1: Type: text/plain, Size: 1263 bytes --]

On Thu, Feb 24, 2022 at 11:41:34PM +0000, Aidan MacDonald wrote:
> Copied from the jz4740 devicetree and trimmed to 5 timers, which
> is what the hardware supports.
> 
> Signed-off-by: Aidan MacDonald <aidanmacdonald.0x0@gmail.com>
> ---
>  arch/mips/boot/dts/ingenic/x1000.dtsi | 13 +++++++++++++
>  1 file changed, 13 insertions(+)

However I don't see this upstream yet, neither in Linus' tree nor in
linux-next. Paul, do you still have this on your radar?

Thierry

> 
> diff --git a/arch/mips/boot/dts/ingenic/x1000.dtsi b/arch/mips/boot/dts/ingenic/x1000.dtsi
> index 8bd27edef216..0dcf37527c8e 100644
> --- a/arch/mips/boot/dts/ingenic/x1000.dtsi
> +++ b/arch/mips/boot/dts/ingenic/x1000.dtsi
> @@ -127,6 +127,19 @@ wdt: watchdog@0 {
>  			clocks = <&tcu TCU_CLK_WDT>;
>  			clock-names = "wdt";
>  		};
> +
> +		pwm: pwm@40 {
> +			compatible = "ingenic,x1000-pwm";
> +			reg = <0x40 0x80>;
> +
> +			#pwm-cells = <3>;
> +
> +			clocks = <&tcu TCU_CLK_TIMER0>, <&tcu TCU_CLK_TIMER1>,
> +				 <&tcu TCU_CLK_TIMER2>, <&tcu TCU_CLK_TIMER3>,
> +				 <&tcu TCU_CLK_TIMER4>;
> +			clock-names = "timer0", "timer1", "timer2",
> +				      "timer3", "timer4";
> +		};
>  	};
>  
>  	rtc: rtc@10003000 {
> -- 
> 2.34.1
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH v2 2/2] mips: dts: ingenic: x1000: Add PWM device tree node

[Paul Cercueil]

Hi Thierry,

Le ven., avril 22 2022 at 18:12:05 +0200, Thierry Reding 
<thierry.reding@gmail.com> a écrit :
> On Thu, Feb 24, 2022 at 11:41:34PM +0000, Aidan MacDonald wrote:
>>  Copied from the jz4740 devicetree and trimmed to 5 timers, which
>>  is what the hardware supports.
>> 
>>  Signed-off-by: Aidan MacDonald <aidanmacdonald.0x0@gmail.com>
>>  ---
>>   arch/mips/boot/dts/ingenic/x1000.dtsi | 13 +++++++++++++
>>   1 file changed, 13 insertions(+)
> 
> However I don't see this upstream yet, neither in Linus' tree nor in
> linux-next. Paul, do you still have this on your radar?

I don't have a tree so that would be a patch for Thomas (Cc'd) to go 
through the linux-mips tree.
(Note to Thomas: patch 1 is already applied in the pwm tree)

The changes look good though, so:

Reviewed-by: Paul Cercueil <paul@crapouillou.net>

Cheers,
-Paul

> 
> Thierry
> 
>> 
>>  diff --git a/arch/mips/boot/dts/ingenic/x1000.dtsi 
>> b/arch/mips/boot/dts/ingenic/x1000.dtsi
>>  index 8bd27edef216..0dcf37527c8e 100644
>>  --- a/arch/mips/boot/dts/ingenic/x1000.dtsi
>>  +++ b/arch/mips/boot/dts/ingenic/x1000.dtsi
>>  @@ -127,6 +127,19 @@ wdt: watchdog@0 {
>>   			clocks = <&tcu TCU_CLK_WDT>;
>>   			clock-names = "wdt";
>>   		};
>>  +
>>  +		pwm: pwm@40 {
>>  +			compatible = "ingenic,x1000-pwm";
>>  +			reg = <0x40 0x80>;
>>  +
>>  +			#pwm-cells = <3>;
>>  +
>>  +			clocks = <&tcu TCU_CLK_TIMER0>, <&tcu TCU_CLK_TIMER1>,
>>  +				 <&tcu TCU_CLK_TIMER2>, <&tcu TCU_CLK_TIMER3>,
>>  +				 <&tcu TCU_CLK_TIMER4>;
>>  +			clock-names = "timer0", "timer1", "timer2",
>>  +				      "timer3", "timer4";
>>  +		};
>>   	};
>> 
>>   	rtc: rtc@10003000 {
>>  --
>>  2.34.1
>>