From: Nathan Chancellor <nathan@kernel.org>
To: "Maciej W. Rozycki" <macro@orcam.me.uk>
Cc: Paul Cercueil <paul@crapouillou.net>,
kernel test robot <lkp@intel.com>,
llvm@lists.linux.dev, kbuild-all@lists.01.org,
linux-kernel@vger.kernel.org,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
linux-mips <linux-mips@vger.kernel.org>
Subject: Re: arch/mips/include/asm/checksum.h:195:9: error: unsupported inline asm: input with type 'unsigned long' matching output with type '__wsum' (aka 'unsigned int')
Date: Fri, 20 May 2022 08:52:45 -0700 [thread overview]
Message-ID: <Yoe5TafDskZ9JDSW@dev-arch.thelio-3990X> (raw)
In-Reply-To: <alpine.DEB.2.21.2205200510350.52080@angie.orcam.me.uk>
On Fri, May 20, 2022 at 12:08:02PM +0100, Maciej W. Rozycki wrote:
> On Thu, 19 May 2022, Paul Cercueil wrote:
>
> > About the real issue: Maybe the last "addu" in csum_tcpudp_nofold() should be
> > a "daddu"?
>
> It doesn't matter whether there is ADDU or DADDU anymore, given that
> commit 198688edbf77 ("MIPS: Fix inline asm input/output type mismatch in
> checksum.h used with Clang") has added a redundant 32-bit sign-extension
> operation right afterwards, regressing size/performance by an extra
> instruction in this performance-critical code as a workaround for a stupid
> compiler.
Shouldn't this concern have been addressed by Tiezhu's follow up?
https://lore.kernel.org/1617359240-16609-1-git-send-email-yangtiezhu@loongson.cn/
I guess it never got picked up?
Cheers,
Nathan
next prev parent reply other threads:[~2022-05-20 15:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <202205200128.layu7VXF-lkp@intel.com>
2022-05-19 17:45 ` arch/mips/include/asm/checksum.h:195:9: error: unsupported inline asm: input with type 'unsigned long' matching output with type '__wsum' (aka 'unsigned int') Paul Cercueil
2022-05-20 8:38 ` [kbuild-all] " Chen, Rong A
2022-05-20 11:08 ` Maciej W. Rozycki
2022-05-20 15:52 ` Nathan Chancellor [this message]
2022-05-22 20:48 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yoe5TafDskZ9JDSW@dev-arch.thelio-3990X \
--to=nathan@kernel.org \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=lkp@intel.com \
--cc=llvm@lists.linux.dev \
--cc=macro@orcam.me.uk \
--cc=paul@crapouillou.net \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox