From: Sam Ravnborg <sam@ravnborg.org>
To: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Cc: paul@crapouillou.net, airlied@linux.ie,
linux-mips@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/ingenic: Use resource_size function on resource object
Date: Fri, 24 Jun 2022 19:25:05 +0200 [thread overview]
Message-ID: <YrXzccaCsBpPHTYw@ravnborg.org> (raw)
In-Reply-To: <20220624013159.88646-1-jiapeng.chong@linux.alibaba.com>
Hi Jiapeng,
On Fri, Jun 24, 2022 at 09:31:59AM +0800, Jiapeng Chong wrote:
> This was found by coccicheck:
>
> ./drivers/gpu/drm/ingenic/ingenic-drm-drv.c:1149:35-38: WARNING: Suspicious code. resource_size is maybe missing with res.
>
Nice one, now I have to go back and fix my code as well.
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
next prev parent reply other threads:[~2022-06-24 17:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-24 1:31 [PATCH] drm/ingenic: Use resource_size function on resource object Jiapeng Chong
2022-06-24 17:25 ` Sam Ravnborg [this message]
2022-06-24 19:00 ` Paul Cercueil
-- strict thread matches above, loose matches on Subject: below --
2022-03-03 8:08 Jiapeng Chong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YrXzccaCsBpPHTYw@ravnborg.org \
--to=sam@ravnborg.org \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=jiapeng.chong@linux.alibaba.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=paul@crapouillou.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox