From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7AE9AC433EF for ; Sun, 3 Jul 2022 06:43:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231261AbiGCGno (ORCPT ); Sun, 3 Jul 2022 02:43:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53404 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231252AbiGCGno (ORCPT ); Sun, 3 Jul 2022 02:43:44 -0400 Received: from mailrelay2-1.pub.mailoutpod1-cph3.one.com (mailrelay2-1.pub.mailoutpod1-cph3.one.com [46.30.210.183]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 060D264C8 for ; Sat, 2 Jul 2022 23:43:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ravnborg.org; s=rsa1; h=in-reply-to:content-type:mime-version:references:message-id:subject:cc:to: from:date:from; bh=vxP0cGw3hHh8TfpWoKjeipnz7SqgYobDoDSTvlK7xfI=; b=BdYzAY7AndzrdqXiZrVmQ+K3Y+sJHfZ71LyfcIm95V83WcdXusc6jj3tVIp+LwGtablMQ3VIE6tMF laGLsSRfgztZj/KABU97clWyFT5lNp5Oy/EbAUPcHNQC14gqrjyeZ+/PRnBsYipc1qalyo+x7mehkd PjIGQ80L6+lMug8l33Jk2SaE/r3MD3eeZRRJaxf4xLgd0hbY2GYHHduvanzjNfvfkPneuI52AFweNj IZELEobn/pWDWqOaOQbTnu/m7Yk2aM3GoxH7Al/A1Vj5YMEfsWFdgpnWXV9pAEYvy4iIlvMWFdGjcl gJhBk2ODXhFdTTS6amjCQl7RihyIDAw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=ravnborg.org; s=ed1; h=in-reply-to:content-type:mime-version:references:message-id:subject:cc:to: from:date:from; bh=vxP0cGw3hHh8TfpWoKjeipnz7SqgYobDoDSTvlK7xfI=; b=QJPUfLbpvJmfb1Na9QQPmRMMP/16yIZVld0HfuL7gtHH7x14JBK1p/OoSeWTcK3R1SErQxvhLBSPp xZMyBDXDg== X-HalOne-Cookie: 62bbb06fc9a29970a031891bb17428932ea70f5a X-HalOne-ID: 787f57d8-fa9b-11ec-a917-d0431ea8a290 Received: from mailproxy4.cst.dirpod4-cph3.one.com (2-105-2-98-cable.dk.customer.tdc.net [2.105.2.98]) by mailrelay2.pub.mailoutpod1-cph3.one.com (Halon) with ESMTPSA id 787f57d8-fa9b-11ec-a917-d0431ea8a290; Sun, 03 Jul 2022 06:43:39 +0000 (UTC) Date: Sun, 3 Jul 2022 08:43:37 +0200 From: Sam Ravnborg To: Paul Cercueil Cc: David Airlie , Daniel Vetter , linux-mips@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, list@opendingux.net, Christophe Branchereau , stable@vger.kernel.org Subject: Re: [PATCH] drm/ingenic: Use the highest possible DMA burst size Message-ID: References: <20220702230727.66704-1-paul@crapouillou.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220702230727.66704-1-paul@crapouillou.net> Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org Hi Paul, On Sun, Jul 03, 2022 at 12:07:27AM +0100, Paul Cercueil wrote: > Until now, when running at the maximum resolution of 1280x720 at 32bpp > on the JZ4770 SoC the output was garbled, the X/Y position of the > top-left corner of the framebuffer warping to a random position with > the whole image being offset accordingly, every time a new frame was > being submitted. > > This problem can be eliminated by using a bigger burst size for the DMA. Are there any alignment constraints of the framebuffer that depends on the burst size? I am hit by this with some atmel IP - which is why I ask. Patch looks good and is a-b. > > Set in each soc_info structure the maximum burst size supported by the > corresponding SoC, and use it in the driver. > > Set the new value using regmap_update_bits() instead of > regmap_set_bits(), since we do want to override the old value of the > burst size. (Note that regmap_set_bits() wasn't really valid before for > the same reason, but it never seemed to be a problem). > > Cc: > Fixes: 90b86fcc47b4 ("DRM: Add KMS driver for the Ingenic JZ47xx SoCs") > Signed-off-by: Paul Cercueil Acked-by: Sam Ravnborg