From: Sasha Levin <sashal@kernel.org>
To: Jiaxun Yang <jiaxun.yang@flygoat.com>
Cc: linux-kernel@vger.kernel.org,
"stable@vger.kernel.org" <stable@vger.kernel.org>,
"Daniel Borkmann" <daniel@iogearbox.net>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Johan Almbladh" <johan.almbladh@anyfinetworks.com>,
"Thomas Bogendoerfer" <tsbogend@alpha.franken.de>,
"Alexei Starovoitov" <ast@kernel.org>,
"Andrii Nakryiko" <andrii@kernel.org>,
"paulburton@kernel.org" <paulburton@kernel.org>,
"linux-mips@vger.kernel.org" <linux-mips@vger.kernel.org>,
bpf@vger.kernel.org
Subject: Re: [PATCH AUTOSEL 6.3 08/59] bpf, mips: Implement DADDI workarounds for JIT
Date: Thu, 18 May 2023 13:03:01 -0400 [thread overview]
Message-ID: <ZGZaRfsA/FTvZcsX@sashalap> (raw)
In-Reply-To: <50FCC591-D86A-46A3-AF4A-DD68D2FACC78@flygoat.com>
On Fri, May 05, 2023 at 01:04:14PM +0100, Jiaxun Yang wrote:
>
>
>> 2023年5月4日 20:40，Sasha Levin <sashal@kernel.org> 写道：
>>
>> From: Jiaxun Yang <jiaxun.yang@flygoat.com>
>>
>> [ Upstream commit bbefef2f07080cd502a93cb1c529e1c8a6c4ac8e ]
>>
>> For DADDI errata we just workaround by disable immediate operation
>> for BPF_ADD / BPF_SUB to avoid generation of DADDIU.
>>
>> All other use cases in JIT won't cause overflow thus they are all safe.
>>
>> Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
>> Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
>> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>> Acked-by: Johan Almbladh <johan.almbladh@anyfinetworks.com>
>> Link: https://lore.kernel.org/bpf/20230228113305.83751-2-jiaxun.yang@flygoat.com
>> Signed-off-by: Sasha Levin <sashal@kernel.org>
>
>Hi Sasha,
>
>I think this patch should count as a functional improvement instead of regression fix.
>
>Please drop it from stable queue.
Dropped, thanks!
--
Thanks,
Sasha
prev parent reply other threads:[~2023-05-18 17:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230504194142.3805425-1-sashal@kernel.org>
2023-05-04 19:40 ` [PATCH AUTOSEL 6.3 08/59] bpf, mips: Implement DADDI workarounds for JIT Sasha Levin
2023-05-05 12:04 ` Jiaxun Yang
2023-05-18 17:03 ` Sasha Levin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZGZaRfsA/FTvZcsX@sashalap \
--to=sashal@kernel.org \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=jiaxun.yang@flygoat.com \
--cc=johan.almbladh@anyfinetworks.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=paulburton@kernel.org \
--cc=philmd@linaro.org \
--cc=stable@vger.kernel.org \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox