From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99E1DC7EE2D for ; Mon, 22 May 2023 11:22:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233371AbjEVLWk (ORCPT ); Mon, 22 May 2023 07:22:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34570 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233344AbjEVLWY (ORCPT ); Mon, 22 May 2023 07:22:24 -0400 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EF80C5275; Mon, 22 May 2023 04:17:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=cQTiKEc/43ERh/RUjjvIJQkEsJdOq6qRkauNBfX0QXQ=; b=p9m/ILtgZZh20NKGMrXp1m9S79 L3gjgt3hqJWh343H0TOYKs01/G2BPEuhvFC4TMuRPeU+MY+G/63vgoqDRNSKM39yVvKzOTaMjmZFK 7LM8lsFJeYjGWosrrrGG5miTPAuK0YTizFt0WQTN+y4vi/M34EkH3zTVqOfVyGhSWIOf8ow6+E/// 7SsMn4KhRSRjr9A7KCnECWwdnNE+HTrXL6yLyaObfuKu+fRhMgUnrXcHYHyRgw+uyKRbUhZTX2eMd dspexsNkPMSmOqiOaZOzjcHaV7Or01naZ8gCOX7wKpbxrnL7eOBmMEZkr02uGpGm9yxIp2RZVNEOy 4Up4YdGA==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:59006) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1q13XQ-0006UY-2o; Mon, 22 May 2023 12:17:16 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1q13XE-0007tn-CU; Mon, 22 May 2023 12:17:04 +0100 Date: Mon, 22 May 2023 12:17:04 +0100 From: "Russell King (Oracle)" To: Andrew Cooper Cc: tglx@linutronix.de, James.Bottomley@hansenpartnership.com, arjan@linux.intel.com, arnd@arndb.de, boris.ostrovsky@oracle.com, brgerst@gmail.com, catalin.marinas@arm.com, deller@gmx.de, dwmw2@infradead.org, gpiccoli@igalia.com, guoren@kernel.org, jgross@suse.com, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, lucjan.lucjanov@gmail.com, mark.rutland@arm.com, mikelley@microsoft.com, oleksandr@natalenko.name, palmer@dabbelt.com, paul.walmsley@sifive.com, paulmck@kernel.org, pbonzini@redhat.com, pmenzel@molgen.mpg.de, ross.philipson@oracle.com, sabrapan@amazon.com, seanjc@google.com, thomas.lendacky@amd.com, tsbogend@alpha.franken.de, usama.arif@bytedance.com, will@kernel.org, x86@kernel.org, xen-devel@lists.xenproject.org, Jeffrey Hugo Subject: Re: [PATCH] x86/apic: Fix use of X{,2}APIC_ENABLE in asm with older binutils Message-ID: References: <20230512203426.452963764@linutronix.de> <20230522105738.2378364-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230522105738.2378364-1-andrew.cooper3@citrix.com> Sender: Russell King (Oracle) Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org Hi, Please can you tell me what the relevance of this patch is to me, and thus why I'm included in the Cc list? I have never touched this file, not in its current path nor a previous path according to git. Thanks. On Mon, May 22, 2023 at 11:57:38AM +0100, Andrew Cooper wrote: > "x86/smpboot: Support parallel startup of secondary CPUs" adds the first use > of X2APIC_ENABLE in assembly, but older binutils don't tolerate the UL suffix. > > Switch to using BIT() instead. > > Fixes: 7e75178a0950 ("x86/smpboot: Support parallel startup of secondary CPUs") > Reported-by: Jeffrey Hugo > Tested-by: Jeffrey Hugo > Signed-off-by: Andrew Cooper > --- > arch/x86/include/asm/apicdef.h | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/arch/x86/include/asm/apicdef.h b/arch/x86/include/asm/apicdef.h > index bf546dfb6e58..4b125e5b3187 100644 > --- a/arch/x86/include/asm/apicdef.h > +++ b/arch/x86/include/asm/apicdef.h > @@ -2,6 +2,8 @@ > #ifndef _ASM_X86_APICDEF_H > #define _ASM_X86_APICDEF_H > > +#include > + > /* > * Constants for various Intel APICs. (local APIC, IOAPIC, etc.) > * > @@ -140,8 +142,8 @@ > #define APIC_BASE (fix_to_virt(FIX_APIC_BASE)) > #define APIC_BASE_MSR 0x800 > #define APIC_X2APIC_ID_MSR 0x802 > -#define XAPIC_ENABLE (1UL << 11) > -#define X2APIC_ENABLE (1UL << 10) > +#define XAPIC_ENABLE BIT(11) > +#define X2APIC_ENABLE BIT(10) > > #ifdef CONFIG_X86_32 > # define MAX_IO_APICS 64 > > base-commit: 0c7ffa32dbd6b09a87fea4ad1de8b27145dfd9a6 > -- > 2.30.2 > > -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!