From: Sean Christopherson <seanjc@google.com>
To: Raghavendra Rao Ananta <rananta@google.com>
Cc: Marc Zyngier <maz@kernel.org>,
Oliver Upton <oliver.upton@linux.dev>,
James Morse <james.morse@arm.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Huacai Chen <chenhuacai@kernel.org>,
Zenghui Yu <yuzenghui@huawei.com>,
Anup Patel <anup@brainfault.org>,
Atish Patra <atishp@atishpatra.org>,
Jing Zhang <jingzhangos@google.com>,
Reiji Watanabe <reijiw@google.com>,
Colton Lewis <coltonlewis@google.com>,
David Matlack <dmatlack@google.com>,
linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev,
linux-mips@vger.kernel.org, kvm-riscv@lists.infradead.org,
linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
kvm@vger.kernel.org
Subject: Re: [PATCH v7 02/12] KVM: arm64: Use kvm_arch_flush_remote_tlbs()
Date: Tue, 8 Aug 2023 08:07:43 -0700 [thread overview]
Message-ID: <ZNJaPxTtPRCv0HOl@google.com> (raw)
In-Reply-To: <CAJHc60zN-dc2E-fS7fuXgkrfGD9bqW6tMy2GRZxbHOeZv0ZOBw@mail.gmail.com>
On Fri, Aug 04, 2023, Raghavendra Rao Ananta wrote:
> On Wed, Aug 2, 2023 at 4:28 PM Raghavendra Rao Ananta
> <rananta@google.com> wrote:
> >
> > Sure, I'll change it to kvm_arch_flush_vm_tlbs() in v8.
> >
> While working on the renaming, I realized that since this function is
> called from kvm_main.c's kvm_flush_remote_tlbs(). Do we want to rename
> this and the other kvm_flush_*() functions that the series introduces
> to match their kvm_arch_flush_*() counterparts?
Hmm, if we're going to rename one arch hook, then yes, I think it makes sense to
rename all the common APIs and arch hooks to match.
However, x86 is rife with the "remote_tlbs" nomenclature, and renaming the common
APIs will just push the inconsistencies into x86. While I 100% agree that the
current naming is flawed, I am not willing to end up with x86 being partially
converted.
I think I'm ok renaming all of x86's many hooks? But I'd definitely want input
from more x86 folks, and the size and scope of this series would explode. Unless
Marc objects and/or has a better idea, the least awful option is probably to ignore
the poor "remote_tlbs" naming and tackle it in a separate series.
Sorry for not noticiing this earlier, I didn't realize just how much x86 uses
remote_tlbs.
> (spiraling more into this, we also have the 'remote_tlb_flush_requests' and
> 'remote_tlb_flush' stats)
Regardless of what we decide for the APIs, definitely leave the stats alone. The
names are ABI. We could preserve the names and changes the struct fields, but that
would be a net negative IMO.
next prev parent reply other threads:[~2023-08-08 17:02 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-22 2:22 [PATCH v7 00/12] KVM: arm64: Add support for FEAT_TLBIRANGE Raghavendra Rao Ananta
2023-07-22 2:22 ` [PATCH v7 01/12] KVM: Rename kvm_arch_flush_remote_tlb() to kvm_arch_flush_remote_tlbs() Raghavendra Rao Ananta
2023-07-27 10:24 ` Marc Zyngier
2023-07-31 17:21 ` Raghavendra Rao Ananta
2023-07-31 21:42 ` Sean Christopherson
2023-08-01 0:42 ` Raghavendra Rao Ananta
2023-08-02 15:54 ` Marc Zyngier
2023-08-02 16:10 ` Sean Christopherson
2023-08-02 23:30 ` Raghavendra Rao Ananta
2023-07-22 2:22 ` [PATCH v7 02/12] KVM: arm64: Use kvm_arch_flush_remote_tlbs() Raghavendra Rao Ananta
2023-07-24 9:13 ` Shaoqin Huang
2023-07-27 10:25 ` Marc Zyngier
2023-07-31 21:50 ` Sean Christopherson
2023-08-02 15:55 ` Marc Zyngier
2023-08-02 23:28 ` Raghavendra Rao Ananta
2023-08-04 18:19 ` Raghavendra Rao Ananta
2023-08-08 15:07 ` Sean Christopherson [this message]
2023-08-08 16:19 ` Raghavendra Rao Ananta
2023-08-08 16:43 ` Marc Zyngier
2023-08-08 16:46 ` Raghavendra Rao Ananta
2023-07-22 2:22 ` [PATCH v7 03/12] KVM: Remove CONFIG_HAVE_KVM_ARCH_TLB_FLUSH_ALL Raghavendra Rao Ananta
2023-07-24 9:13 ` Shaoqin Huang
2023-07-22 2:22 ` [PATCH v7 04/12] KVM: Allow range-based TLB invalidation from common code Raghavendra Rao Ananta
2023-07-31 21:55 ` Sean Christopherson
2023-08-01 0:39 ` Raghavendra Rao Ananta
2023-08-07 4:06 ` Anup Patel
2023-07-22 2:22 ` [PATCH v7 05/12] KVM: Move kvm_arch_flush_remote_tlbs_memslot() to " Raghavendra Rao Ananta
2023-07-27 10:53 ` Marc Zyngier
2023-07-31 17:30 ` Raghavendra Rao Ananta
2023-08-07 4:06 ` Anup Patel
2023-07-22 2:22 ` [PATCH v7 06/12] arm64: tlb: Refactor the core flush algorithm of __flush_tlb_range Raghavendra Rao Ananta
2023-07-27 10:58 ` Marc Zyngier
2023-07-31 17:36 ` Raghavendra Rao Ananta
2023-08-02 15:58 ` Marc Zyngier
2023-08-02 23:31 ` Raghavendra Rao Ananta
2023-07-22 2:22 ` [PATCH v7 07/12] KVM: arm64: Implement __kvm_tlb_flush_vmid_range() Raghavendra Rao Ananta
2023-07-24 9:21 ` Shaoqin Huang
2023-07-27 12:40 ` Marc Zyngier
2023-07-31 17:45 ` Raghavendra Rao Ananta
2023-07-22 2:22 ` [PATCH v7 08/12] KVM: arm64: Define kvm_tlb_flush_vmid_range() Raghavendra Rao Ananta
2023-07-27 12:47 ` Marc Zyngier
2023-07-27 13:01 ` Marc Zyngier
2023-07-31 18:01 ` Raghavendra Rao Ananta
2023-08-02 23:25 ` Marc Zyngier
2023-07-22 2:22 ` [PATCH v7 09/12] KVM: arm64: Implement kvm_arch_flush_remote_tlbs_range() Raghavendra Rao Ananta
2023-07-27 12:48 ` Marc Zyngier
2023-07-22 2:22 ` [PATCH v7 10/12] KVM: arm64: Flush only the memslot after write-protect Raghavendra Rao Ananta
2023-07-22 2:22 ` [PATCH v7 11/12] KVM: arm64: Invalidate the table entries upon a range Raghavendra Rao Ananta
2023-07-22 2:22 ` [PATCH v7 12/12] KVM: arm64: Use TLBI range-based intructions for unmap Raghavendra Rao Ananta
2023-07-24 9:34 ` Shaoqin Huang
2023-07-24 16:47 ` Raghavendra Rao Ananta
2023-07-25 2:32 ` Shaoqin Huang
2023-07-25 17:23 ` Raghavendra Rao Ananta
2023-07-26 4:06 ` Shaoqin Huang
2023-07-27 13:12 ` Marc Zyngier
2023-07-31 18:26 ` Raghavendra Rao Ananta
2023-08-02 23:28 ` Marc Zyngier
2023-08-02 23:33 ` Raghavendra Rao Ananta
2023-07-31 21:57 ` [PATCH v7 00/12] KVM: arm64: Add support for FEAT_TLBIRANGE Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZNJaPxTtPRCv0HOl@google.com \
--to=seanjc@google.com \
--cc=anup@brainfault.org \
--cc=atishp@atishpatra.org \
--cc=chenhuacai@kernel.org \
--cc=coltonlewis@google.com \
--cc=dmatlack@google.com \
--cc=james.morse@arm.com \
--cc=jingzhangos@google.com \
--cc=kvm-riscv@lists.infradead.org \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=maz@kernel.org \
--cc=oliver.upton@linux.dev \
--cc=pbonzini@redhat.com \
--cc=rananta@google.com \
--cc=reijiw@google.com \
--cc=suzuki.poulose@arm.com \
--cc=yuzenghui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).