From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Jiri Slaby <jirislaby@kernel.org>
Cc: "Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Wolfram Sang" <wsa+renesas@sang-engineering.com>,
linux-mips@vger.kernel.org,
"Jonas Gorski" <jonas.gorski@gmail.com>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH 1/6] serial: 8250: remove AR7 support
Date: Thu, 21 Sep 2023 14:30:35 +0300 [thread overview]
Message-ID: <ZQwpWyWo3Pur7TEJ@smile.fi.intel.com> (raw)
In-Reply-To: <1165e159-62d1-4abd-88d7-b8eaeaf797df@kernel.org>
On Thu, Sep 21, 2023 at 01:21:46PM +0200, Jiri Slaby wrote:
> On 21. 09. 23, 13:16, Andy Shevchenko wrote:
> > On Thu, Sep 21, 2023 at 12:36:05PM +0200, Philippe Mathieu-Daudé wrote:
> > > On 20/9/23 22:10, Wolfram Sang wrote:
...
> > > > -#define PORT_AR7 18 /* Texas Instruments AR7 internal UART */
> > >
> > > I'm a bit surprised definitions are removed from the uAPI, isn't
> > > it expected to be very stable? Shouldn't it be better to keep it
> > > defined but modify the comment, mentioning "obsolete" or "deprecated"?
> >
> > The numbers up to 20 must stay, they are being used somewhere, setserial
> > implementation in busybox (IIRC).
>
> But they define it if we don't:
> #ifndef PORT_AR7
> # define PORT_AR7 18
> #endif
Yep, but the problem is that we may not use that number anyway, because two
different versions of kernel can clash on the same version of tool that will
think about AR7 while it's something different. That's why instead of having
reserved space, better to leave with names assigned.
> > NAK.
> I don't mind either way. But likely we should reserve the field if we go and
> remove it (setserial has a number->string mapping in busybox). Hm, then
> reserving it or keep it? Perhaps keep it is better... So ack the NACK :).
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-09-21 17:53 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-20 20:10 [PATCH 0/6] remove AR7 platform and associated drivers Wolfram Sang
2023-09-20 20:10 ` [PATCH 1/6] serial: 8250: remove AR7 support Wolfram Sang
2023-09-20 21:25 ` Florian Fainelli
2023-09-21 7:31 ` Greg Kroah-Hartman
2023-09-21 10:36 ` Philippe Mathieu-Daudé
2023-09-21 11:16 ` Andy Shevchenko
2023-09-21 11:21 ` Jiri Slaby
2023-09-21 11:30 ` Andy Shevchenko [this message]
2023-09-21 12:04 ` Wolfram Sang
2023-09-21 11:18 ` Andy Shevchenko
2023-09-20 20:10 ` [PATCH 2/6] mtd: parsers: ar7: remove support Wolfram Sang
2023-09-20 21:26 ` Florian Fainelli
2023-09-20 20:10 ` [PATCH 3/6] vlynq: remove bus driver Wolfram Sang
2023-09-20 21:26 ` Florian Fainelli
2023-09-21 10:37 ` Philippe Mathieu-Daudé
2023-09-21 12:06 ` Wolfram Sang
2023-09-21 12:32 ` Philippe Mathieu-Daudé
2023-09-20 20:10 ` [PATCH 4/6] watchdog: ar7_wdt: remove driver to prepare for platform removal Wolfram Sang
2023-09-20 20:14 ` Guenter Roeck
2023-09-20 21:26 ` Florian Fainelli
2023-09-20 20:10 ` [PATCH 5/6] net: cpmac: " Wolfram Sang
2023-09-20 21:26 ` Florian Fainelli
2023-09-20 20:10 ` [PATCH 6/6] MIPS: AR7: remove platform Wolfram Sang
2023-09-20 21:28 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZQwpWyWo3Pur7TEJ@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=f.fainelli@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=jonas.gorski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=philmd@linaro.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).