From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7F92E92FFA for ; Fri, 6 Oct 2023 08:25:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231177AbjJFIZA (ORCPT ); Fri, 6 Oct 2023 04:25:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35996 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231140AbjJFIY4 (ORCPT ); Fri, 6 Oct 2023 04:24:56 -0400 Received: from elvis.franken.de (elvis.franken.de [193.175.24.41]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 2B5BDFC; Fri, 6 Oct 2023 01:24:54 -0700 (PDT) Received: from uucp by elvis.franken.de with local-rmail (Exim 3.36 #1) id 1qog8g-0002lN-00; Fri, 06 Oct 2023 10:24:50 +0200 Received: by alpha.franken.de (Postfix, from userid 1000) id E4D8CC0250; Fri, 6 Oct 2023 10:22:14 +0200 (CEST) Date: Fri, 6 Oct 2023 10:22:14 +0200 From: Thomas Bogendoerfer To: =?utf-8?B?QXLEsW7DpyDDnE5BTA==?= Cc: Sergio Paracuellos , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , linux-mips@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH] mips: dts: ralink: mt7621: define each reset as an item Message-ID: References: <20230917103753.52644-1-arinc.unal@arinc9.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230917103753.52644-1-arinc.unal@arinc9.com> Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org On Sun, Sep 17, 2023 at 01:37:53PM +0300, Arınç ÜNAL wrote: > Each item of the resets property should define a reset. Split the item with > two resets on the ethernet node into two separate items. > > Sort the items of the clocks property to the same line as a trivial change. > > Signed-off-by: Arınç ÜNAL > --- > arch/mips/boot/dts/ralink/mt7621.dtsi | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/arch/mips/boot/dts/ralink/mt7621.dtsi b/arch/mips/boot/dts/ralink/mt7621.dtsi > index 7caed0d14f11..35a10258f235 100644 > --- a/arch/mips/boot/dts/ralink/mt7621.dtsi > +++ b/arch/mips/boot/dts/ralink/mt7621.dtsi > @@ -300,14 +300,13 @@ ethernet: ethernet@1e100000 { > compatible = "mediatek,mt7621-eth"; > reg = <0x1e100000 0x10000>; > > - clocks = <&sysc MT7621_CLK_FE>, > - <&sysc MT7621_CLK_ETH>; > + clocks = <&sysc MT7621_CLK_FE>, <&sysc MT7621_CLK_ETH>; > clock-names = "fe", "ethif"; > > #address-cells = <1>; > #size-cells = <0>; > > - resets = <&sysc MT7621_RST_FE &sysc MT7621_RST_ETH>; > + resets = <&sysc MT7621_RST_FE>, <&sysc MT7621_RST_ETH>; > reset-names = "fe", "eth"; > > interrupt-parent = <&gic>; > -- > 2.39.2 > applied to mips-next. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]