From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="laBeXsEB" Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1A76DB2; Mon, 4 Dec 2023 05:32:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1701696758; x=1733232758; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=Dkr4auhuaXm/2CFkaCr6ysuuxc8iZhZ8/KeupfzqlRg=; b=laBeXsEBWrrgfDWBwIBfDhhrlg+aCO5FYS76PfYZuT4mZBvVewWCm4Z4 7nPsV3Zz3WlYa+VmKRi/qlh7x4ELsjvce8vw4F5sybk/ALUMfIKLQIieC l/eKbL/G7bMHqtitgNJ9qtMcXSObPh/a/0lrWXHzL+TbrkcWw4PYhmQhR wCFLZDYRoF5ORb7cvpNZiqvbNnx4xszvY5KXxjCnwTfcxkgzIiBe775zo I6WpUv6lgVRgXK0ctKfcxIwS6+F+FFGgzLv4BCJvWFPeQ8Wf9DtBKLFcC XZ+xDqxJEY1eDSKQFp8Pru+yzObEY09ouY/2RQwMWO8O2jC0aMzf0+4kC g==; X-IronPort-AV: E=McAfee;i="6600,9927,10913"; a="7059246" X-IronPort-AV: E=Sophos;i="6.04,249,1695711600"; d="scan'208";a="7059246" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Dec 2023 05:32:37 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10913"; a="720323840" X-IronPort-AV: E=Sophos;i="6.04,249,1695711600"; d="scan'208";a="720323840" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga003.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Dec 2023 05:32:27 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1rA93f-00000001lCW-1RPq; Mon, 04 Dec 2023 15:32:23 +0200 Date: Mon, 4 Dec 2023 15:32:23 +0200 From: Andy Shevchenko To: Geert Uytterhoeven Cc: Marek Szyprowski , Linus Walleij , Bartosz Golaszewski , Rasmus Villemoes , Jonathan =?iso-8859-1?Q?Neusch=E4fer?= , Krzysztof Kozlowski , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Geert Uytterhoeven , Biju Das , Claudiu Beznea , Jianlong Huang , linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, openbmc@lists.ozlabs.org, linux-mips@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Ray Jui , Scott Branden , Broadcom internal kernel review list , Dong Aisheng , Fabio Estevam , Shawn Guo , Jacky Bai , Pengutronix Kernel Team , Sascha Hauer , NXP Linux Team , Sean Wang , Paul Cercueil , Lakshmi Sowjanya D , Bjorn Andersson , Andy Gross , Konrad Dybcio , Emil Renner Berthing , Hal Feng , Krzysztof Kozlowski Subject: Re: [PATCH v4 12/23] pinctrl: mediatek: Make use of PINCTRL_GROUP_DESC() Message-ID: References: <20231129161459.1002323-1-andriy.shevchenko@linux.intel.com> <20231129161459.1002323-13-andriy.shevchenko@linux.intel.com> <9e4e65de-7234-4234-8091-796277a1f1c5@samsung.com> Precedence: bulk X-Mailing-List: linux-mips@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Mon, Dec 04, 2023 at 02:19:10PM +0100, Geert Uytterhoeven wrote: > Hi Andy, > > On Mon, Dec 4, 2023 at 2:10 PM Andy Shevchenko > wrote: > > On Mon, Dec 04, 2023 at 12:40:38PM +0100, Marek Szyprowski wrote: > > > On 29.11.2023 17:06, Andy Shevchenko wrote: > > > > Make use of PINCTRL_GROUP_DESC() instead of open coding it. > > > > > PINCTRL_GROUP_DESC() macro from drivers/pinctrl/core.h contains a cast > > > to (struct group_desc), what breaks users of the above macros. > > > > There is no cast (*). > > Thanks for report, I will check. > > > > But this was v4 of the series and LKP actually sent a positive feedback. > > Besides that I have tested this locally with modules enabled. > > > > *) It's a compound literal, _not_ a cast. > > Taking above into consideration I'm wondering what compilers > > are in use? > > kisskb reported the following m68k failures to me: > linux-next/m68k-allmodconfig/m68k-gcc8 > linux-next/m68k-allmodconfig/m68k-gcc11 > linux-next/m68k-allmodconfig/m68k-gcc12 > > However, according to [1], linux-next/m68k-allmodconfig/m68k-gcc13 > did succeed, so I guess you are using gcc13? Yes, I compiled with these: $ gcc --version gcc (Debian 13.2.0-5) 13.2.0 Copyright (C) 2023 Free Software Foundation, Inc. This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. $ clang --version Debian clang version 16.0.6 (16) Target: x86_64-pc-linux-gnu Thread model: posix InstalledDir: /usr/bin -- With Best Regards, Andy Shevchenko