Re: [PATCH] MIPS: loongson64: fix boot failure

[Thomas Bogendoerfer <tsbogend@alpha.franken.de>]

On Mon, Dec 25, 2023 at 05:30:25PM +0800, Huang Pei wrote:
>  arch/mips/loongson64/numa.c | 2 --
>  2 files changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/mips/kernel/traps.c b/arch/mips/kernel/traps.c
> index 246c6a6b0261..9b632b4c10c3 100644
> --- a/arch/mips/kernel/traps.c
> +++ b/arch/mips/kernel/traps.c
> @@ -2007,7 +2007,8 @@ unsigned long vi_handlers[64];
>  
>  void reserve_exception_space(phys_addr_t addr, unsigned long size)
>  {
> -	memblock_reserve(addr, size);
> +	if(memblock_is_region_memory(addr, size))
> +		memblock_reserve(addr, size);
>  }

I don't think this is a good idea, reserve_exception_space() is called
in cpu_probe() and at that point memblock setup hasn't been done. So
we end up in a situation commit bd67b711bfaa ("MIPS: kernel: Reserve
exception base early to prevent corruption") fixed.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]