From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EF79831B824; Thu, 25 Dec 2025 12:35:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766666127; cv=none; b=JP6jrMRlppciHeE220gO+zmUuih5/ASAdYXwOXdQGrWT/NqgtwQRLgQz3/EHAIvGrGG0I+SvUGdgURieTW1B6MgKCJ1vIElX7yhjoSO5ygYqW1uAlD1zoPhnjcX/Ie8wYqGQCF1nNK9rXhn4eb5gZ0lK8ag3ILlHT4cLvKqUXYs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766666127; c=relaxed/simple; bh=+vuBMibyabze3gYZvwPkDyuzvUQwmEe5MvGF5wEybDo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=pQzz5f9ObXboCVTOMhPY/oAU/RL7tJKDYwYE3aWVy78UoCocdWaSS7IAM/dPZ3wmbNPHXjymlRVBX0GjpxBDphkoGBGXKOVGu8hzeR5l16CYXu+lgsFkxFJayngZ9OMxO4YYWTB1lsUG0peIFduIz/T/hYevgCzZCZBOqqUdV+c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=k9liGzbC; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="k9liGzbC" Received: by smtp.kernel.org (Postfix) with ESMTPSA id DD921C4CEF1; Thu, 25 Dec 2025 12:35:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1766666126; bh=+vuBMibyabze3gYZvwPkDyuzvUQwmEe5MvGF5wEybDo=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=k9liGzbCArYjoHUVQKVQ96N0Iv1gsEsudK7lioooQolKoz/hpf7xv0klybSAcwqBE LzatWmIHqEIassiTDxxluxiGfBKC5+Pj1F4Aul+UMuSQz2tF8crsPOQeCK3T3TShB/ UnxztnqujQib+eb1UuYfJcZFGnt+DtaxepZfPPMIiv6EhWyTUzPhB6ImbbvSjt2BZ9 iWIRFrWgTsrlRUgAClbbrraZAaVv3uWmHHwMR1OLO8/l/zyvuODuFpvdNDAN5Nn4XE f5EpFd8uvIERsrL48BYTw0BEh5UhhWY6LZUatchpsOzJLgmvOQ0jjGRXUjUHqGCXGt kPqzqT32YHGJw== Message-ID: Date: Thu, 25 Dec 2025 13:35:20 +0100 Precedence: bulk X-Mailing-List: linux-mips@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/4] mips: bmips: dts: fix qspi register order To: Jonas Gorski , Kamal Dasu , Broadcom internal kernel review list , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Florian Fainelli , Thomas Bogendoerfer , =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= Cc: Kamal Dasu , linux-spi@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org References: <20251225102533.30772-1-jonas.gorski@gmail.com> <20251225102533.30772-5-jonas.gorski@gmail.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJoF1BKBQkWlnSaAAoJEBuTQ307 QWKbHukP/3t4tRp/bvDnxJfmNdNVn0gv9ep3L39IntPalBFwRKytqeQkzAju0whYWg+R/rwp +r2I1Fzwt7+PTjsnMFlh1AZxGDmP5MFkzVsMnfX1lGiXhYSOMP97XL6R1QSXxaWOpGNCDaUl ajorB0lJDcC0q3xAdwzRConxYVhlgmTrRiD8oLlSCD5baEAt5Zw17UTNDnDGmZQKR0fqLpWy 786Lm5OScb7DjEgcA2PRm17st4UQ1kF0rQHokVaotxRM74PPDB8bCsunlghJl1DRK9s1aSuN hL1Pv9VD8b4dFNvCo7b4hfAANPU67W40AaaGZ3UAfmw+1MYyo4QuAZGKzaP2ukbdCD/DYnqi tJy88XqWtyb4UQWKNoQqGKzlYXdKsldYqrLHGoMvj1UN9XcRtXHST/IaLn72o7j7/h/Ac5EL 8lSUVIG4TYn59NyxxAXa07Wi6zjVL1U11fTnFmE29ALYQEXKBI3KUO1A3p4sQWzU7uRmbuxn naUmm8RbpMcOfa9JjlXCLmQ5IP7Rr5tYZUCkZz08LIfF8UMXwH7OOEX87Y++EkAB+pzKZNNd hwoXulTAgjSy+OiaLtuCys9VdXLZ3Zy314azaCU3BoWgaMV0eAW/+gprWMXQM1lrlzvwlD/k whyy9wGf0AEPpLssLVt9VVxNjo6BIkt6d1pMg6mHsUEVzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmgXUF8FCRaWWyoACgkQG5NDfTtBYptO0w//dlXJs5/42hAXKsk+PDg3wyEFb4NpyA1v qmx7SfAzk9Hf6lWwU1O6AbqNMbh6PjEwadKUk1m04S7EjdQLsj/MBSgoQtCT3MDmWUUtHZd5 RYIPnPq3WVB47GtuO6/u375tsxhtf7vt95QSYJwCB+ZUgo4T+FV4hquZ4AsRkbgavtIzQisg Dgv76tnEv3YHV8Jn9mi/Bu0FURF+5kpdMfgo1sq6RXNQ//TVf8yFgRtTUdXxW/qHjlYURrm2 H4kutobVEIxiyu6m05q3e9eZB/TaMMNVORx+1kM3j7f0rwtEYUFzY1ygQfpcMDPl7pRYoJjB dSsm0ZuzDaCwaxg2t8hqQJBzJCezTOIkjHUsWAK+tEbU4Z4SnNpCyM3fBqsgYdJxjyC/tWVT AQ18NRLtPw7tK1rdcwCl0GFQHwSwk5pDpz1NH40e6lU+NcXSeiqkDDRkHlftKPV/dV+lQXiu jWt87ecuHlpL3uuQ0ZZNWqHgZoQLXoqC2ZV5KrtKWb/jyiFX/sxSrodALf0zf+tfHv0FZWT2 zHjUqd0t4njD/UOsuIMOQn4Ig0SdivYPfZukb5cdasKJukG1NOpbW7yRNivaCnfZz6dTawXw XRIV/KDsHQiyVxKvN73bThKhONkcX2LWuD928tAR6XMM2G5ovxLe09vuOzzfTWQDsm++9UKF a/A= In-Reply-To: <20251225102533.30772-5-jonas.gorski@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 25/12/2025 11:25, Jonas Gorski wrote: > Align the register order to the schema. Fixes warnings like: > > arch/mips/boot/dts/brcm/bcm97435svmb.dtb: spi@41d200 (brcm,spi-brcmstb-qspi): reg-names:0: 'cs_reg' is not one of ['hif_mspi', 'mspi'] > from schema $id: http://devicetree.org/schemas/spi/brcm,spi-bcm-qspi.yaml > arch/mips/boot/dts/brcm/bcm97435svmb.dtb: spi@41d200 (brcm,spi-brcmstb-qspi): reg-names:1: 'bspi' was expected > from schema $id: http://devicetree.org/schemas/spi/brcm,spi-bcm-qspi.yaml > arch/mips/boot/dts/brcm/bcm97435svmb.dtb: spi@41d200 (brcm,spi-brcmstb-qspi): reg-names:2: 'bspi' is not one of ['intr_regs', 'intr_status_reg', 'cs_reg'] > from schema $id: http://devicetree.org/schemas/spi/brcm,spi-bcm-qspi.yaml Trim redundant parts. You do not need to paste schema path every time. Full path to DTB also is not really necessary, IMO. > > Signed-off-by: Jonas Gorski > --- > arch/mips/boot/dts/brcm/bcm7125.dtsi | 4 ++-- > arch/mips/boot/dts/brcm/bcm7346.dtsi | 4 ++-- > arch/mips/boot/dts/brcm/bcm7358.dtsi | 4 ++-- > arch/mips/boot/dts/brcm/bcm7360.dtsi | 4 ++-- > arch/mips/boot/dts/brcm/bcm7362.dtsi | 4 ++-- > arch/mips/boot/dts/brcm/bcm7420.dtsi | 4 ++-- > arch/mips/boot/dts/brcm/bcm7425.dtsi | 4 ++-- > arch/mips/boot/dts/brcm/bcm7435.dtsi | 4 ++-- > 8 files changed, 16 insertions(+), 16 deletions(-) > > diff --git a/arch/mips/boot/dts/brcm/bcm7125.dtsi b/arch/mips/boot/dts/brcm/bcm7125.dtsi > index dd1cc3cda694..81ee0f49b645 100644 > --- a/arch/mips/boot/dts/brcm/bcm7125.dtsi > +++ b/arch/mips/boot/dts/brcm/bcm7125.dtsi > @@ -250,8 +250,8 @@ qspi: spi@443000 { > compatible = "brcm,spi-brcmstb-qspi", > "brcm,spi-bcm-qspi"; > clocks = <&upg_clk>; > - reg = <0x440920 0x4 0x443200 0x188 0x443000 0x50>; > - reg-names = "cs_reg", "hif_mspi", "bspi"; > + reg = <0x443200 0x188 0x443000 0x50 0x440920 0x4>; > + reg-names = "hif_mspi", "bspi", "cs_reg"; So order is anyway broken by this change, thus you can as well rename it to mspi, right? Best regards, Krzysztof